xen-netback: stop the VIF thread before unbinding IRQs
Subsystems (3)
PATCH 1/1 xen-netback: stop the VIF thread before unbinding IRQs
From: David Vrabel <[email protected]>
If the VIF thread is still running after unbinding the Tx and Rx IRQs in xenvif_disconnect(), the thread may attempt to raise an event which will BUG (as the irq is unbound).
--- drivers/net/xen-netback/interface.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/xen-netback/interface.c +3 -3
@@ -461,6 +461,9 @@ void xenvif_disconnect(struct xenvif *vif)if (netif_carrier_ok (vif->dev))xenvif_carrier_off (vif); +if (vif->task) +kthread_stop (vif->task); +if (vif->tx_irq) {if (vif->tx_irq == vif->rx_irq)unbind_from_irqhandler (vif->tx_irq, vif);
@@ -471,9 +474,6 @@ void xenvif_disconnect(struct xenvif *vif) vif->tx_irq =0 ; } -if (vif->task) -kthread_stop (vif->task); -xenvif_unmap_frontend_rings (vif); }
Signature · 1 line
1.7.2.5
Quoted 7 lines · David Vrabel
From: David Vrabel <[email protected]>
If the VIF thread is still running after unbinding the Tx and Rx IRQs in
xenvif_disconnect(), the thread may attempt to raise an event which will BUG (as the irq is unbound).Signed-off-by David Vrabel <[email protected]>
Thanks
Wei.
Quoted 35 lines
--- drivers/net/xen-netback/interface.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/net/xen-netback/interface.c +3
-3@@ -461,6 +461,9 @@ void xenvif_disconnect(struct xenvif *vif)if (netif_carrier_ok (vif->dev))xenvif_carrier_off (vif); +if (vif->task) +kthread_stop (vif->task); +if (vif->tx_irq) {if (vif->tx_irq == vif->rx_irq)unbind_from_irqhandler (vif->tx_irq, vif);@@ -471,9 +474,6 @@ void xenvif_disconnect(struct xenvif *vif) vif->tx_irq =0 ; } -if (vif->task) -kthread_stop (vif->task); -xenvif_unmap_frontend_rings (vif); }Signature · 6 lines
1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 7 lines · David Vrabel
From: David Vrabel <[email protected]>
If the VIF thread is still running after unbinding the Tx and Rx IRQs in
xenvif_disconnect(), the thread may attempt to raise an event which will BUG (as the irq is unbound).Signed-off-by David Vrabel <[email protected]>
Thanks
Wei.
Quoted 35 lines
--- drivers/net/xen-netback/interface.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)drivers/net/xen-netback/interface.c +3
-3@@ -461,6 +461,9 @@ void xenvif_disconnect(struct xenvif *vif)if (netif_carrier_ok (vif->dev))xenvif_carrier_off (vif); +if (vif->task) +kthread_stop (vif->task); +if (vif->tx_irq) {if (vif->tx_irq == vif->rx_irq)unbind_from_irqhandler (vif->tx_irq, vif);@@ -471,9 +474,6 @@ void xenvif_disconnect(struct xenvif *vif) vif->tx_irq =0 ; } -if (vif->task) -kthread_stop (vif->task); -xenvif_unmap_frontend_rings (vif); }Signature · 6 lines
1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
From: David Vrabel <[email protected]>
Date: Thu, 21 Nov 2013 15:26:09 +0000
Quoted 7 lines
From: David Vrabel <[email protected]>
If the VIF thread is still running after unbinding the Tx and Rx IRQs in
xenvif_disconnect(), the thread may attempt to raise an event which will BUG (as the irq is unbound).Signed-off-by David Vrabel <[email protected]>
Applied.
From: David Vrabel <[email protected]>
Date: Thu, 21 Nov 2013 15:26:09 +0000
Quoted 7 lines
From: David Vrabel <[email protected]>
If the VIF thread is still running after unbinding the Tx and Rx IRQs in
xenvif_disconnect(), the thread may attempt to raise an event which will BUG (as the irq is unbound).Signed-off-by David Vrabel <[email protected]>
Applied.