Skip to contentSkip to conversation

libcap-ng: disable on avr32 which lacks TLS

PATCH Superseded Samuel Martin 3 participants 5 messages Nov 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 libcap-ng: disable on avr32 which lacks TLS

libcap-ng needs TLS support, which is not available on avr32. Also, disable reverse dependencies.

Fixes:
http://autobuild.buildroot.net/results/73c/73c7c211a51c312bbe4eb6a540f3ad9c92c79ebe/

---
changes v1 -> v2:
- add the 'depends on' statement to the ofono comment (ThomasP)

---
 package/libcap-ng/Config.in | 1 +
 package/ofono/Config.in     | 2 ++
 2 files changed, 3 insertions(+)
package/libcap-ng/Config.in +1 -0
index d1663cd..da5b447 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBCAP_NG
 	bool "libcap-ng"
+	depends on !BR2_avr32 # lacks TLS
 	help
 	  The libcap-ng library is intended to make programming with
 	  posix capabilities much easier than the traditional libcap
package/ofono/Config.in +2 -0
index c431e08..1cb41ea 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO
 	depends on BR2_USE_WCHAR # gettext, libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
 	depends on BR2_USE_MMU # dbus
+	depends on !BR2_avr32 # libcap-ng
 	select BR2_PACKAGE_LIBCAP_NG
 	select BR2_PACKAGE_DBUS
 	select BR2_PACKAGE_LIBGLIB2
@@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO
 	  http://ofono.org/
 
 comment "ofono needs a toolchain w/ wchar, threads"
+	depends on !BR2_avr32
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH v2 1/1 libcap-ng: disable on avr32 which lacks TLS

Samuel,

Samuel Martin <[email protected]> wrote on 11/22/2013 03:26:47 AM:

[...]

Quoted 13 lines
package/ofono/Config.in +1 -0
index c431e08..1cb41ea 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO
    depends on BR2_USE_WCHAR # gettext, libglib2
    depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
    depends on BR2_USE_MMU # dbus
+   depends on !BR2_avr32 # libcap-ng
    select BR2_PACKAGE_LIBCAP_NG
    select BR2_PACKAGE_DBUS
    select BR2_PACKAGE_LIBGLIB2

package/ofono/Config.in config BR2_PACKAGE_OFONO · line 18

Quoted 3 lines
package/ofono/Config.in +0 -0
@@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO
      http://ofono.org/
 
 comment "ofono needs a toolchain w/ wchar, threads"

Wouldn't you want comment above saying and !avr32 or something to that extent?

package/ofono/Config.in config BR2_PACKAGE_OFONO · line 21

Quoted 3 lines
package/ofono/Config.in +1 -0
+   depends on !BR2_avr32
    depends on BR2_USE_MMU
    depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Thanks,
-Ryan

#2 lore raw

PATCH v2 1/1 libcap-ng: disable on avr32 which lacks TLS

Hi Ryan,

2013/11/22 Ryan Barnett <[email protected]>

Quoted 21 lines

Samuel,

Samuel Martin <[email protected]> wrote on 11/22/2013 03:26:47 AM:

[...]

Quoted 15 lines
package/ofono/Config.in +1 -0
index c431e08..1cb41ea 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO
    depends on BR2_USE_WCHAR # gettext, libglib2
    depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
    depends on BR2_USE_MMU # dbus
+   depends on !BR2_avr32 # libcap-ng
    select BR2_PACKAGE_LIBCAP_NG
    select BR2_PACKAGE_DBUS
    select BR2_PACKAGE_LIBGLIB2
@@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO
      http://ofono.org/
 
Quoted 5 lines

package/ofono/Config.in config BR2_PACKAGE_OFONO · line 18

Quoted 1 line
package/ofono/Config.in +0 -0
 comment "ofono needs a toolchain w/ wchar, threads"

Wouldn't you want comment above saying and !avr32 or something to that extent?

According to the manual (
http://git.buildroot.net/buildroot/tree/docs/manual/adding-packages-directory.txt#n213),
this is not needed.

Quoted 8 lines

package/ofono/Config.in config BR2_PACKAGE_OFONO · line 21

Quoted 3 lines
package/ofono/Config.in +1 -0
+   depends on !BR2_avr32
    depends on BR2_USE_MMU
    depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Thanks,
-Ryan

Regards,

Signature · 4 lines
Samuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131122/cd0af86b/attachment.html>
#3 lore raw

PATCH v2 1/1 libcap-ng: disable on avr32 which lacks TLS

Samuel Martin <[email protected]> wrote on 11/22/2013 03:39:17 AM:

Quoted 1 line

2013/11/22 Ryan Barnett <[email protected]>

[...]

Quoted 5 lines
Quoted 2 lines

Wouldn't you want comment above saying and !avr32 or something to that extent?

According to the manual
(

http://git.buildroot.net/buildroot/tree/docs/manual/adding-packages-directory.txt#n213
),

Quoted 2 lines

this is not needed.

Thanks for the information as I didn't remember off the top of my head! So disregard my comment then :)

Thanks,
-Ryan

#4 lore raw

PATCH v2 1/1 libcap-ng: disable on avr32 which lacks TLS

In reply to Samuel Martin
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Samuel" == Samuel Martin <[email protected]> writes:

libcap-ng needs TLS support, which is not available on avr32. Also, disable reverse dependencies.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/73c/73c7c211a51c312bbe4eb6a540f3ad9c92c79ebe/

---
changes v1 -> v2:
- add the 'depends on' statement to the ofono comment (ThomasP)

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard