Skip to contentSkip to conversation

Staging:comedi:pcmmio Fixed a printk format in debug section

PATCH In review Abhishek Sudhakaran 2 participants 2 messages Nov 23, 2013 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging:comedi:pcmmio Fixed a printk format in debug section

Fixed a printk statement in the debug section
where the string terminator was misplaced.

---
 drivers/staging/comedi/drivers/pcmmio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcmmio.c +1 -1
index 14cee3a..bc1f44c 100644
@@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
 #ifdef DAMMIT_ITS_BROKEN
 		/* DEBUG */
 		printk
-		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
+		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
 		     " data_in %02x ", byte_no, (unsigned)write_mask_byte,
 		     (unsigned)data_byte, offset, ioaddr, (unsigned)byte);
 #endif
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw
Quoted 13 lines · Abhishek Sudhakaran

Fixed a printk statement in the debug section
where the string terminator was misplaced.

---
 drivers/staging/comedi/drivers/pcmmio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcmmio.c +0 -0
index 14cee3a..bc1f44c 100644

drivers/staging/comedi/drivers/pcmmio.c static int pcmmio_dio_insn_bits(struct comedi_device *dev, · line 279

Quoted 7 lines
drivers/staging/comedi/drivers/pcmmio.c +1 -1
@@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
 #ifdef DAMMIT_ITS_BROKEN
 		/* DEBUG */
 		printk
-		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
+		    (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
 		     " data_in %02x ", byte_no, (unsigned)write_mask_byte,
 		     (unsigned)data_byte, offset, ioaddr, (unsigned)byte);

Did you build this patch? I think the original code is correct, and your change will cause an error, right?

greg k-h