Skip to contentSkip to conversation

mei: Fix typo in client.c

PATCH In review Masanari Iida 3 participants 8 messages Nov 23, 2013 – Nov 25, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 mei: Fix typo in client.c

Correct spelling typo in comments within mei/client.c

---
 drivers/misc/mei/client.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/misc/mei/client.c +7 -7
index 87c96e4..3aa379f 100644
@@ -263,10 +263,10 @@ struct mei_cl_cb *mei_cl_find_read_cb(struct mei_cl *cl)
 	return NULL;
 }
 
-/** mei_cl_link: allocte host id in the host map
+/** mei_cl_link: allocate host id in the host map
  *
  * @cl - host client
- * @id - fixed host id or -1 for genereting one
+ * @id - fixed host id or -1 for generating one
  *
  * returns 0 on success
  *	-EINVAL on incorrect values
@@ -282,7 +282,7 @@ int mei_cl_link(struct mei_cl *cl, int id)
 
 	dev = cl->dev;
 
-	/* If Id is not asigned get one*/
+	/* If Id is not assigned get one*/
 	if (id == MEI_HOST_CLIENT_ID_ANY)
 		id = find_first_zero_bit(dev->host_clients_map,
 					MEI_CLIENTS_MAX);
@@ -378,7 +378,7 @@ void mei_host_client_init(struct work_struct *work)
 
 
 /**
- * mei_cl_disconnect - disconnect host clinet form the me one
+ * mei_cl_disconnect - disconnect host client from the me one
  *
  * @cl: host client
  *
@@ -457,7 +457,7 @@ free:
  *
  * @cl: private data of the file object
  *
- * returns ture if other client is connected, 0 - otherwise.
+ * returns true if other client is connected, 0 - otherwise.
  */
 bool mei_cl_is_other_connecting(struct mei_cl *cl)
 {
@@ -481,7 +481,7 @@ bool mei_cl_is_other_connecting(struct mei_cl *cl)
 }
 
 /**
- * mei_cl_connect - connect host clinet to the me one
+ * mei_cl_connect - connect host client to the me one
  *
  * @cl: host client
  *
@@ -775,7 +775,7 @@ int mei_cl_irq_write_complete(struct mei_cl *cl, struct mei_cl_cb *cb,
  * @cl: host client
  * @cl: write callback with filled data
  *
- * returns numbe of bytes sent on success, <0 on failure.
+ * returns number of bytes sent on success, <0 on failure.
  */
 int mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, bool blocking)
 {
Signature · 1 line
1.8.5.rc1.28.g7061504
#1 lore raw

PATCH 2/3 mei: Fix typo in mei/nfc.c

Correct spelling typo in comments and debug messages.

---
 drivers/misc/mei/nfc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/misc/mei/nfc.c +5 -5
index 994ca4a..7e8590e 100644
@@ -163,7 +163,7 @@ static int mei_nfc_build_bus_name(struct mei_nfc_dev *ndev)
 			return 0;
 
 		default:
-			dev_err(&dev->pdev->dev, "Unknow radio type 0x%x\n",
+			dev_err(&dev->pdev->dev, "Unknown radio type 0x%x\n",
 				ndev->radio_type);
 
 			return -EINVAL;
@@ -175,14 +175,14 @@ static int mei_nfc_build_bus_name(struct mei_nfc_dev *ndev)
 			ndev->bus_name = "pn544";
 			return 0;
 		default:
-			dev_err(&dev->pdev->dev, "Unknow radio type 0x%x\n",
+			dev_err(&dev->pdev->dev, "Unknown radio type 0x%x\n",
 				ndev->radio_type);
 
 			return -EINVAL;
 		}
 
 	default:
-		dev_err(&dev->pdev->dev, "Unknow vendor ID 0x%x\n",
+		dev_err(&dev->pdev->dev, "Unknown vendor ID 0x%x\n",
 			ndev->vendor_id);
 
 		return -EINVAL;
@@ -428,7 +428,7 @@ static void mei_nfc_init(struct work_struct *work)
 	mutex_unlock(&dev->device_lock);
 
 	if (mei_nfc_if_version(ndev) < 0) {
-		dev_err(&dev->pdev->dev, "Could not get the NFC interfave version");
+		dev_err(&dev->pdev->dev, "Could not get the NFC interface version");
 
 		goto err;
 	}
@@ -481,7 +481,7 @@ int mei_nfc_host_init(struct mei_device *dev)
 	struct mei_cl *cl_info, *cl = NULL;
 	int i, ret;
 
-	/* already initialzed */
+	/* already initialized */
 	if (ndev->cl_info)
 		return 0;
 
Signature · 1 line
1.8.5.rc1.28.g7061504
#3 lore raw

PATCH 3/3 mei: Fix typo in mei drivers

In reply to Masanari Iida

Correct spelling typo in comments within mei.

---
 drivers/misc/mei/amthif.c  |  4 ++--
 drivers/misc/mei/debugfs.c |  2 +-
 drivers/misc/mei/hbm.c     | 12 ++++++------
 drivers/misc/mei/mei_dev.h |  2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)
drivers/misc/mei/amthif.c +2 -2
index d22c686..71971ef 100644
@@ -177,7 +177,7 @@ int mei_amthif_read(struct mei_device *dev, struct file *file,
 	unsigned long timeout;
 	int i;
 
-	/* Only Posible if we are in timeout */
+	/* Only Possible if we are in timeout */
 	if (!cl || cl != &dev->iamthif_cl) {
 		dev_dbg(&dev->pdev->dev, "bad file ext.\n");
 		return -ETIMEDOUT;
@@ -249,7 +249,7 @@ int mei_amthif_read(struct mei_device *dev, struct file *file,
 	    cb->response_buffer.size);
 	dev_dbg(&dev->pdev->dev, "amthif cb->buf_idx - %lu\n", cb->buf_idx);
 
-	/* length is being turncated to PAGE_SIZE, however,
+	/* length is being truncated to PAGE_SIZE, however,
 	 * the buf_idx may point beyond */
 	length = min_t(size_t, length, (cb->buf_idx - *offset));
 
drivers/misc/mei/debugfs.c +1 -1
index e3870f2..10b172a 100644
@@ -43,7 +43,7 @@ static ssize_t mei_dbgfs_read_meclients(struct file *fp, char __user *ubuf,
 
 	mutex_lock(&dev->device_lock);
 
-	/*  if the driver is not enabled the list won't b consitent */
+	/*  if the driver is not enabled the list won't b consistent */
 	if (dev->dev_state != MEI_DEV_ENABLED)
 		goto out;
 
drivers/misc/mei/hbm.c +6 -6
index 9b3a0fb..96fed82 100644
@@ -90,7 +90,7 @@ void mei_hbm_cl_hdr(struct mei_cl *cl, u8 hbm_cmd, void *buf, size_t len)
  * @file: private data of the file object.
  * @disconn: disconnection request.
  *
- * returns true if addres are same
+ * returns true if address are same
  */
 static inline
 bool mei_hbm_cl_addr_equal(struct mei_cl *cl, void *buf)
@@ -268,7 +268,7 @@ static int mei_hbm_prop_req(struct mei_device *dev)
 }
 
 /**
- * mei_hbm_stop_req_prepare - perpare stop request message
+ * mei_hbm_stop_req_prepare - prepare stop request message
  *
  * @dev - mei device
  * @mei_hdr - mei message header
@@ -289,7 +289,7 @@ static void mei_hbm_stop_req_prepare(struct mei_device *dev,
 }
 
 /**
- * mei_hbm_cl_flow_control_req - sends flow control requst.
+ * mei_hbm_cl_flow_control_req - sends flow control request.
  *
  * @dev: the device structure
  * @cl: client info
@@ -451,7 +451,7 @@ int mei_hbm_cl_connect_req(struct mei_device *dev, struct mei_cl *cl)
 }
 
 /**
- * mei_hbm_cl_connect_res - connect resposne from the ME
+ * mei_hbm_cl_connect_res - connect response from the ME
  *
  * @dev: the device structure
  * @rs: connect response bus message
@@ -506,7 +506,7 @@ static void mei_hbm_cl_connect_res(struct mei_device *dev,
 
 /**
  * mei_hbm_fw_disconnect_req - disconnect request initiated by me
- *  host sends disoconnect response
+ *  host sends disconnect response
  *
  * @dev: the device structure.
  * @disconnect_req: disconnect request bus message from the me
@@ -687,7 +687,7 @@ void mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 				mei_hbm_me_cl_allocate(dev);
 				dev->hbm_state = MEI_HBM_CLIENT_PROPERTIES;
 
-				/* first property reqeust */
+				/* first property request */
 				mei_hbm_prop_req(dev);
 		} else {
 			dev_err(&dev->pdev->dev, "reset: unexpected enumeration response hbm.\n");
drivers/misc/mei/mei_dev.h +1 -1
index 406f68e..a994190 100644
@@ -65,7 +65,7 @@ extern const uuid_le mei_wd_guid;
  * that can be opened to the driver.
  *
  * Limit to 255: 256 Total Clients
- * minus internal client for MEI Bus Messags
+ * minus internal client for MEI Bus Messages
  */
 #define  MEI_MAX_OPEN_HANDLE_COUNT (MEI_CLIENTS_MAX - 1)
 
Signature · 1 line
1.8.5.rc1.28.g7061504
#5 lore raw

Re: [PATCH 3/3] [trivial] mei: Fix typo in mei drivers

In reply to Masanari Iida
Quoted 15 lines · Masanari Iida

Correct spelling typo in comments within mei.

---
 drivers/misc/mei/amthif.c  |  4 ++--
 drivers/misc/mei/debugfs.c |  2 +-
 drivers/misc/mei/hbm.c     | 12 ++++++------
 drivers/misc/mei/mei_dev.h |  2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)
drivers/misc/mei/debugfs.c +0 -0
index e3870f2..10b172a 100644

drivers/misc/mei/debugfs.c static ssize_t mei_dbgfs_read_meclients(struct file *fp, char __user *ubuf, · line 46

Quoted 5 lines
drivers/misc/mei/debugfs.c +1 -1
@@ -43,7 +43,7 @@ static ssize_t mei_dbgfs_read_meclients(struct file *fp, char __user *ubuf,
 
 	mutex_lock(&dev->device_lock);
 
-	/*  if the driver is not enabled the list won't b consitent */
+	/*  if the driver is not enabled the list won't b consistent */

be

drivers/misc/mei/hbm.c void mei_hbm_cl_hdr(struct mei_cl *cl, u8 hbm_cmd, void *buf, size_t len) · line 93

Quoted 13 lines
drivers/misc/mei/debugfs.c +0 -0
 	if (dev->dev_state != MEI_DEV_ENABLED)
 		goto out;
 
drivers/misc/mei/hbm.c +1 -1
index 9b3a0fb..96fed82 100644
@@ -90,7 +90,7 @@ void mei_hbm_cl_hdr(struct mei_cl *cl, u8 hbm_cmd, void *buf, size_t len)
  * @file: private data of the file object.
  * @disconn: disconnection request.
  *
- * returns true if addres are same
+ * returns true if address are same

addresses

Quoted 3 lines
drivers/misc/mei/hbm.c +0 -0
  */
 static inline
 bool mei_hbm_cl_addr_equal(struct mei_cl *cl, void *buf)
Signature · 1 line
~Randy
#6 lore raw

RE: [PATCH 3/3] [trivial] mei: Fix typo in mei drivers

Quoted 16 lines

drivers/misc/mei/debugfs.c static ssize_t mei_dbgfs_read_meclients(struct file *fp, char

Quoted 14 lines


 drivers/misc/mei/amthif.c  |  4 ++--
 drivers/misc/mei/debugfs.c |  2 +-
 drivers/misc/mei/hbm.c     | 12 ++++++------
 drivers/misc/mei/mei_dev.h |  2 +-
 4 files changed, 10 insertions(+), 10 deletions(-)
drivers/misc/mei/debugfs.c +0 -0
index e3870f2..10b172a 100644
@@ -43,7 +43,7 @@ static ssize_t mei_dbgfs_read_meclients(struct file *fp, char

__user *ubuf,

Quoted 1 line
Quoted 6 lines

drivers/misc/mei/debugfs.c static ssize_t mei_dbgfs_read_meclients(struct file *fp, char __user *ubuf, · line 46

Quoted 4 lines
drivers/misc/mei/debugfs.c +1 -1
 	mutex_lock(&dev->device_lock);
 
-	/*  if the driver is not enabled the list won't b consitent */
+	/*  if the driver is not enabled the list won't b consistent */

be

Actually, this I already have fixed in my queue.
Will post shortly

Thanks
Tomas