f2fs: adds a tracepoint for submit_read_page
Subsystems (3)
PATCH 1/2 f2fs: adds a tracepoint for submit_read_page
This patch adds a tracepoint for submit_read_page.
--- fs/f2fs/data.c | 1 + include/trace/events/f2fs.h | 30 ++++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+)
fs/f2fs/data.c +1 -0
@@ -448,6 +448,7 @@ alloc_new: io->last_block_in_bio = blk_addr;mutex_unlock (&io->io_mutex); +trace_f2fs_submit_read_page (page, blk_addr, rw); }/*
include/trace/events/f2fs.h +30 -0
@@ -453,6 +453,36 @@ TRACE_EVENT_CONDITION(f2fs_readpage, show_bio_type(__entry->type)) ); +TRACE_EVENT (f2fs_submit_read_page, + + TP_PROTO(struct page *page, block_t blk_addr, int rw), + +TP_ARGS (page, blk_addr, rw), + +TP_STRUCT__entry ( + __field(dev_t, dev) + __field(ino_t, ino) + __field(int, rw) + __field(pgoff_t, index) +__field (block_t, block) + ), + +TP_fast_assign ( + __entry->dev = page->mapping->host->i_sb->s_dev; + __entry->ino = page->mapping->host->i_ino; + __entry->rw = rw; + __entry->index = page->index; + __entry->block = blk_addr; + ), + +TP_printk ("dev = (%d,%d), ino = %lu, bio_type = %s, " +"index = %lu, blkaddr = 0x%llx" , +show_dev_ino (__entry), +show_bio_type (__entry->rw), + (unsigned long )__entry->index, + (unsigned long long )__entry->block) +); + TRACE_EVENT(f2fs_get_data_block, TP_PROTO(struct inode *inode, sector_t iblock, struct buffer_head *bh, int ret),
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
Hi,
We need to avoid redundancy as much as possible.
So, how about this patch?
Quoted 1 line
From
7b4a4f1628a1a793942c7f675e6afecece64b659Mon Sep 17 00:00:00 2001
From: Chao Yu <[email protected]>
Date: Wed, 20 Nov 2013 16:40:10 +0800
Subject: [PATCH] f2fs: adds a tracepoint for submit_read_page
This patch adds a tracepoint for submit_read_page.
--- fs/f2fs/data.c | 1 + fs/f2fs/segment.c | 2 +- include/trace/events/f2fs.h | 25 +++++++++++++++++++++---- 3 files changed, 23 insertions(+), 5 deletions(-)
fs/f2fs/data.c +1 -0
@@ -462,6 +462,7 @@ alloc_new: io->last_block_in_bio = blk_addr;mutex_unlock (&io->io_mutex); +trace_f2fs_submit_read_page (page, rw,META , blk_addr); }/*
fs/f2fs/segment.c +1 -1
@@ -925,7 +925,7 @@ retry: io->last_block_in_bio = blk_addr;mutex_unlock (&io->io_mutex); -trace_f2fs_submit_write_page (page, blk_addr, type); +trace_f2fs_submit_write_page (page,WRITE , type, blk_addr); } void f2fs_wait_on_page_writeback(struct page *page,
include/trace/events/f2fs.h +5 -4
@@ -674,15 +674,16 @@ DEFINE_EVENT(f2fs__page, f2fs_vm_page_mkwrite,TP_ARGS (page, type) ); -TRACE_EVENT(f2fs_submit_write_page, +DECLARE_EVENT_CLASS(f2fs_io_page, - TP_PROTO(struct page *page, block_t blk_addr, int type), + TP_PROTO(struct page *page, int rw, int type, block_t blk_addr), - TP_ARGS(page, blk_addr, type), + TP_ARGS(page, rw, type, blk_addr), TP_STRUCT__entry( __field(dev_t, dev) __field(ino_t, ino) + __field(int, rw) __field(int, type) __field(pgoff_t, index) __field(block_t, block)
@@ -691,18 +692,34 @@ TRACE_EVENT(f2fs_submit_write_page,TP_fast_assign ( __entry->dev = page->mapping->host->i_sb->s_dev; __entry->ino = page->mapping->host->i_ino; + __entry->rw = rw; __entry->type = type; __entry->index = page->index; __entry->block = blk_addr; ), - TP_printk("dev = (%d,%d), ino = %lu, %s, index = %lu, blkaddr = 0x%
llx",
+ TP_printk("dev = (%d,%d), ino = %lu, %s, %s, index = %lu, blkaddr = 0x
%llx",
show_dev_ino(__entry),
+ show_bio_type(__entry->rw),
show_block_type(__entry->type), (unsigned long)__entry->index, (unsigned long long)__entry->block)
);
+DEFINE_EVENT(f2fs_io_page, f2fs_submit_write_page, +
+ TP_PROTO(struct page *page, int rw, int type, block_t blk_addr),
+
+ TP_ARGS(page, rw, type, blk_addr)
+);
+
+DEFINE_EVENT(f2fs_io_page, f2fs_submit_read_page, +
+ TP_PROTO(struct page *page, int rw, int type, block_t blk_addr),
+
+ TP_ARGS(page, rw, type, blk_addr)
+);
+
TRACE_EVENT(f2fs_write_checkpoint,
TP_PROTO(struct super_block *sb, bool is_umount, char *msg),
Signature · 14 lines
1.8.4.474.g128a96c -- Jaegeuk Kim Samsung ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
Hi,
Quoted 11 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, November 24, 2013 11:09 AM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]; 谭姝
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: adds a tracepoint forsubmit_read_pageHi,
We need to avoid redundancy as much as possible.
So, how about this patch?
Ah, It's more neat!
Thanks. :)
Quoted 10 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Sunday, November 24, 2013 11:51 AM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]; 谭姝
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: adds a tracepoint forf2fs_submit_read_bioHi,
Again, this tracepoint alos can be integrated with
write_bioslike this.
Alright, Thanks!
Regards,
Yu
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html