Remove fields from "ip -6 route show" output that distort results.
PATCH 1/1 Remove fields from "ip -6 route show" output that distort results.
"ip -6 route show" prints stuff like "rtt 38ms rttvar 38ms cwnd 10", which sometimes changes while an OpenVPN test is running, resulting in spurious failures in the "ifconfig/route must be restored identically after OpenVPN ends" test. Not all fields are there all the time, so use "sed" to get rid of whatever is printed this time.
Only relevant to linux builds with "--enable-iproute2".
--- tests/t_client.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/t_client.sh.in +1 -1
@@ -103,7 +103,7 @@ get_ifconfig_route() echo "-- linux iproute2 --" @IPROUTE@ addr show | grep -v valid_lft @IPROUTE@ route show - @IPROUTE@ -o -6 route show | grep -v ' cache' | sed -e 's/expires [0-9]*sec//' + @IPROUTE@ -o -6 route show | grep -v ' cache' | sed -E -e 's/ expires [0-9]*sec//' -e 's/ (mtu|hoplimit|cwnd) [0-9]+//g' -e 's/ (rtt|rttvar) [0-9]+ms//g' return fi
Signature · 1 line
1.8.1.5
Am 24.11.13 17:13, schrieb Gert Doering:
Quoted 7 lines
"ip -6 route show" prints stuff like "rtt 38ms rttvar 38ms cwnd 10", which sometimes changes while an OpenVPN test is running, resulting in spurious failures in the "ifconfig/route must be restored identically after OpenVPN ends" test. Not all fields are there all the time, so use "sed" to get rid of whatever is printed this time.
ACK. We disucssed that on the Munich meeting.
Arne
Patch has been applied to the master and release/2.3 branch, with a slightly changed commit message (to make clear that this is about t_client.sh, not about openvpn itself).
commit 8c19087034cb1076874075b9e2896ea3f7be59cf (master) commit 8a553107046b5f214f869f936ba198535571e941 (release/2.3)
Author: Gert Doering <[email protected]...> Date: Sun Nov 24 17:13:04 2013 +0100
t_client.sh: ignore fields from "ip -6 route show" output that distort results.
Signed-off-by: Gert Doering <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: http://article.gmane.org/gmane.network.openvpn.devel/8047--
kind regards,