Skip to contentSkip to conversation

net: remove outdated comment for ipv4 and ipv6 protocol handler

PATCH Superseded [email protected] 3 participants 4 messages Nov 25, 2013 – Nov 28, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: remove outdated comment for ipv4 and ipv6 protocol handler

From: Baker Zhang <[email protected]>

since f9242b6b28d61295f2bf7e8adfb1060b382e5381,
there are not pretended hash tables for ipv4 or
ipv6 protocol handler.

---
inet_add_protocol/inet_del_protocol and inet6_del_protocol are very simple in current version.

so I remove the outdated comment instead of fixing them, just like inet6_add_protocol.

 net/ipv4/protocol.c | 8 --------
 net/ipv6/protocol.c | 4 ----
 2 files changed, 12 deletions(-)
net/ipv4/protocol.c +0 -8
index ce84846..46d6a1c 100644
@@ -31,10 +31,6 @@
 const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;
 const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS] __read_mostly;
 
-/*
- *	Add a protocol handler to the hash tables
- */
-
 int inet_add_protocol(const struct net_protocol *prot, unsigned char protocol)
 {
 	if (!prot->netns_ok) {
@@ -55,10 +51,6 @@ int inet_add_offload(const struct net_offload *prot, unsigned char protocol)
 }
 EXPORT_SYMBOL(inet_add_offload);
 
-/*
- *	Remove a protocol from the hash tables.
- */
-
 int inet_del_protocol(const struct net_protocol *prot, unsigned char protocol)
 {
 	int ret;
net/ipv6/protocol.c +0 -4
index 22d1bd4..e048cf1 100644
@@ -36,10 +36,6 @@ int inet6_add_protocol(const struct inet6_protocol *prot, unsigned char protocol
 }
 EXPORT_SYMBOL(inet6_add_protocol);
 
-/*
- *	Remove a protocol from the hash tables.
- */
-
 int inet6_del_protocol(const struct inet6_protocol *prot, unsigned char protocol)
 {
 	int ret;
Signature · 1 line
1.8.3.2
#2 lore raw

PATCH v2 1/1 net: remove outdated comment for ipv4 and ipv6 protocol handler

In reply to [email protected]

From: Baker Zhang <[email protected]>

since f9242b6b28d61295f2bf7e8adfb1060b382e5381
inet: Sanitize inet{,6} protocol demux.

there are not pretended hash tables for ipv4 or
ipv6 protocol handler.

---
V1:
inet_add_protocol/inet_del_protocol and inet6_del_protocol are very simple in current version.

so I remove the outdated comment instead of fixing them, just like inet6_add_protocol.

V2:
Add summary line in parens.
URL:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=f9242b6b28d61295f2bf7e8adfb1060b382e5381

 net/ipv4/protocol.c | 8 --------
 net/ipv6/protocol.c | 4 ----
 2 files changed, 12 deletions(-)
net/ipv4/protocol.c +0 -8
index ce84846..46d6a1c 100644
@@ -31,10 +31,6 @@
 const struct net_protocol __rcu *inet_protos[MAX_INET_PROTOS] __read_mostly;
 const struct net_offload __rcu *inet_offloads[MAX_INET_PROTOS] __read_mostly;
 
-/*
- *	Add a protocol handler to the hash tables
- */
-
 int inet_add_protocol(const struct net_protocol *prot, unsigned char protocol)
 {
 	if (!prot->netns_ok) {
@@ -55,10 +51,6 @@ int inet_add_offload(const struct net_offload *prot, unsigned char protocol)
 }
 EXPORT_SYMBOL(inet_add_offload);
 
-/*
- *	Remove a protocol from the hash tables.
- */
-
 int inet_del_protocol(const struct net_protocol *prot, unsigned char protocol)
 {
 	int ret;
net/ipv6/protocol.c +0 -4
index 22d1bd4..e048cf1 100644
@@ -36,10 +36,6 @@ int inet6_add_protocol(const struct inet6_protocol *prot, unsigned char protocol
 }
 EXPORT_SYMBOL(inet6_add_protocol);
 
-/*
- *	Remove a protocol from the hash tables.
- */
-
 int inet6_del_protocol(const struct inet6_protocol *prot, unsigned char protocol)
 {
 	int ret;
Signature · 1 line
1.8.3.2