Skip to contentSkip to conversation

lftp: new package.

PATCH Superseded Arnaud Rébillout 2 participants 7 messages Nov 25, 2013 – Dec 3, 2013

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 lftp: new package.

Here comes a second version of the patch to include lftp in buildroot.

Improvements from v1:
* Config.in
* Typo corrected
* lftp.mk
* LFTP_SOURCE removed
* LFTP_AUTORECONF set to YES
* POST_INSTALL_TARGET factorized a lot
* patches:
* Signed-off
* Patch the m4 file instead of the configure script

Best regards,
Arnaud.

#1 lore raw

PATCH 1/1 lftp: new package.

LFTP is a sophisticated ftp/http client, and a file transfer program supporting a number of network protocols. Like BASH, it has job control and uses the readline library for input. It has bookmarks, a built-in mirror command, and can transfer several files in parallel. It was designed with reliability in mind.

---
 package/Config.in                                  |  1 +
 ...osix_fallocate-m4-check-for-cross-compile.patch | 32 +++++++++++
 ...02-Check-whether-posix_fallocate-compiles.patch | 55 ++++++++++++++++++
 package/lftp/Config.in                             | 65 ++++++++++++++++++++++
 package/lftp/lftp.mk                               | 54 ++++++++++++++++++
 5 files changed, 207 insertions(+)
 create mode 100644 package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch
 create mode 100644 package/lftp/0002-Check-whether-posix_fallocate-compiles.patch
 create mode 100644 package/lftp/Config.in
 create mode 100644 package/lftp/lftp.mk
package/Config.in +1 -0
index 311cc6c..bcaa8f3 100644
@@ -814,6 +814,7 @@ source "package/iputils/Config.in"
 source "package/iw/Config.in"
 source "package/kismet/Config.in"
 source "package/knock/Config.in"
+source "package/lftp/Config.in"
 source "package/lighttpd/Config.in"
 source "package/linknx/Config.in"
 source "package/links/Config.in"
package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch new file +32 -0
new file mode 100644
index 0000000..3c7209f
@@ -0,0 +1,32 @@
+From 8a49b00a4f746f0bdc1b2490a260f98e872d0e9c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arnaud=20R=C3=A9billout?= <[email protected]>
+Date: Mon, 25 Nov 2013 11:03:59 +0100
+Subject: [PATCH 1/2] Fix posix_fallocate m4 check for cross-compile.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+If we're cross-compiling, it's very unlikely that we use old glibc or
+AIX. So we assume that posix_fallocate works.
+
+Signed-off-by: Arnaud R?billout <[email protected]>
+---
+ m4/lftp.m4 | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/m4/lftp.m4 b/m4/lftp.m4
+index 6d7ad9c..c8efb28 100644
+--- a/m4/lftp.m4
++++ b/m4/lftp.m4
+@@ -271,6 +271,8 @@ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
+        i_cv_posix_fallocate_works=yes
+      ], [
+        i_cv_posix_fallocate_works=no
++     ], [
++       i_cv_posix_fallocate_works=yes
+      ])
+    ])
+    if test x$i_cv_posix_fallocate_works = xyes; then
+-- 
+1.8.4.4
+
package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +55 -0

55 lines not on this page · raw message

package/lftp/Config.in new file +65 -0

65 lines not on this page · raw message

package/lftp/lftp.mk new file +54 -0

54 lines not on this page · raw message

Signature · 1 line
1.8.4.4
#2 lore raw

PATCH 1/1 lftp: new package.

Quoted 14 lines · Arnaud R?billout

LFTP is a sophisticated ftp/http client, and a file transfer program supporting a number of network protocols. Like BASH, it has job control and uses the readline library for input. It has bookmarks, a built-in mirror command, and can transfer several files in parallel. It was designed with reliability in mind.

---
  package/Config.in                                  |  1 +
  ...osix_fallocate-m4-check-for-cross-compile.patch | 32 +++++++++++
  ...02-Check-whether-posix_fallocate-compiles.patch | 55 ++++++++++++++++++
  package/lftp/Config.in                             | 65 ++++++++++++++++++++++
  package/lftp/lftp.mk                               | 54 ++++++++++++++++++
  5 files changed, 207 insertions(+)
Quoted 2 lines

create mode 100644 package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch create mode 100644 package/lftp/0002-Check-whether-posix_fallocate-compiles.patch

Since these two patches actually fix the same problem, it's better to
squash them into a single patch.

Quoted 89 lines

create mode 100644 package/lftp/Config.in
create mode 100644 package/lftp/lftp.mk

package/Config.in +1 -0
index 311cc6c..bcaa8f3 100644
@@ -814,6 +814,7 @@ source "package/iputils/Config.in"
  source "package/iw/Config.in"
  source "package/kismet/Config.in"
  source "package/knock/Config.in"
+source "package/lftp/Config.in"
  source "package/lighttpd/Config.in"
  source "package/linknx/Config.in"
  source "package/links/Config.in"
package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch new file +32 -0
new file mode 100644
index 0000000..3c7209f
@@ -0,0 +1,32 @@
+From 8a49b00a4f746f0bdc1b2490a260f98e872d0e9c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arnaud=20R=C3=A9billout?= <[email protected]>
+Date: Mon, 25 Nov 2013 11:03:59 +0100
+Subject: [PATCH 1/2] Fix posix_fallocate m4 check for cross-compile.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+If we're cross-compiling, it's very unlikely that we use old glibc or
+AIX. So we assume that posix_fallocate works.
+
+Signed-off-by: Arnaud R?billout <[email protected]>
+---
+ m4/lftp.m4 | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/m4/lftp.m4 b/m4/lftp.m4
+index 6d7ad9c..c8efb28 100644
+--- a/m4/lftp.m4
++++ b/m4/lftp.m4
+@@ -271,6 +271,8 @@ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
+        i_cv_posix_fallocate_works=yes
+      ], [
+        i_cv_posix_fallocate_works=no
++     ], [
++       i_cv_posix_fallocate_works=yes
+      ])
+    ])
+    if test x$i_cv_posix_fallocate_works = xyes; then
+--
+1.8.4.4
+
package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +30 -0
new file mode 100644
index 0000000..b137a52
@@ -0,0 +1,55 @@
+From 99674dbf332427b6e2778643af026133cc2edac6 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arnaud=20R=C3=A9billout?= <[email protected]>
+Date: Mon, 25 Nov 2013 13:22:24 +0100
+Subject: [PATCH 2/2] Check whether posix_fallocate compiles.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+uClibc doesn't provide posix_fallocate as of 0.9.33.2, but some patches
+exist to add this function.
+
+Therefore, the only way to know if posix_fallocate is present is to do a
+compile test.
+
+Signed-off-by: Arnaud R?billout <[email protected]>
+---
+ m4/lftp.m4 | 15 +++++++++++++++
+ 1 file changed, 15 insertions(+)
+
+diff --git a/m4/lftp.m4 b/m4/lftp.m4
+index c8efb28..d489bec 100644
+--- a/m4/lftp.m4
++++ b/m4/lftp.m4
+@@ -244,6 +244,20 @@ AC_DEFUN([LFTP_ENVIRON_CHECK],[
+
+ dnl Taken from dovecot
+ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
++   dnl * Ensure posix_fallocate is provided by the C library.
++   AC_CACHE_CHECK([whether posix_fallocate() compiles],[i_cv_posix_fallocate_compiles],[
++     AC_LINK_IFELSE([

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch line 40

Quoted 10 lines
package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +10 -0
++       #include <fcntl.h>
++       int main() {
++         posix_fallocate(0, 0, 0);
++       }
++     ], [
++       i_cv_posix_fallocate_compiles=yes
++     ], [
++       i_cv_posix_fallocate_compiles=no
++     ])
++   ])

I think it would be simpler to work the other way round: to the
AC_LINK_IFELSE in the cross-compiling branch of AC_TRY_RUN. Then you don't need the additional variable, you can just write to posix_fallocate_works.

Can you also send the patch upstream so they can comment on it?

Quoted 45 lines
package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +15 -0
++   if test x$i_cv_posix_fallocate_compiles = xyes; then
+    dnl * Old glibcs have broken posix_fallocate(). Make sure not to use it.
+    dnl * It may also be broken in AIX.
+    AC_CACHE_CHECK([whether posix_fallocate() works],[i_cv_posix_fallocate_works],[
+@@ -278,6 +292,7 @@ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
+    if test x$i_cv_posix_fallocate_works = xyes; then
+      AC_DEFINE(HAVE_POSIX_FALLOCATE, 1, [Define if you have a working posix_fallocate()])
+    fi
++   fi
+ ])
+
+ AC_DEFUN([LFTP_POSIX_FADVISE_CHECK],[
+--
+1.8.4.4
+
package/lftp/Config.in new file +24 -0
new file mode 100644
index 0000000..df4062a
@@ -0,0 +1,65 @@
+config BR2_PACKAGE_LFTP
+	bool "lftp"
+	depends on BR2_USE_WCHAR
+	depends on BR2_INSTALL_LIBSTDCPP
+	select BR2_PACKAGE_READLINE
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_GNUTLS if !BR2_PACKAGE_OPENSSL
+	help
+	  LFTP is a sophisticated ftp/http client, and a file transfer program
+	  supporting a number of network protocols. Like BASH, it has job
+	  control and uses the readline library for input. It has bookmarks,
+	  a built-in mirror command, and can transfer several files in parallel.
+	  It was designed with reliability in mind.
+
+	  http://lftp.yar.ru/
+
+if BR2_PACKAGE_LFTP
+
+comment "Commands"
+
+config BR2_PACKAGE_LFTP_CMD_MIRROR
+	bool "Mirror command"
+	help
+	  Enable mirror command

package/lftp/Config.in line 34

Quoted 10 lines
package/lftp/Config.in new file +10 -0
+
+config BR2_PACKAGE_LFTP_CMD_SLEEP
+	bool "Sleep command"
+	help
+	  Enable sleep command
+
+config BR2_PACKAGE_LFTP_CMD_TORRENT
+	bool "Torrent command"
+	help
+	  Enable torrent command

Is it needed/useful to have all these options? Do they have a big
impact on size?

Quoted 39 lines
package/lftp/Config.in new file +31 -0
+
+comment "Protocols"
+
+config BR2_PACKAGE_LFTP_PROTO_FISH
+	bool "FISH protocol"
+	default y
+	help
+	  Enable FISH protocol
+
+config BR2_PACKAGE_LFTP_PROTO_FTP
+	bool "FTP protocol"
+	default y
+	help
+	  Enable FTP protocol
+
+config BR2_PACKAGE_LFTP_PROTO_HTTP
+	bool "HTTP protocol"
+	default y
+	help
+	  Enable HTTP protocol
+
+config BR2_PACKAGE_LFTP_PROTO_SFTP
+	bool "SFTP protocol"
+	default y
+	help
+	  Enable SFTP protocol
+
+endif  # BR2_PACKAGE_LFTP
+
+comment "lftp requires a toolchain w/ C++, wchar"
+	depends on !(BR2_USE_WCHAR && BR2_INSTALL_LIBSTDCPP)
package/lftp/lftp.mk new file +2 -0
new file mode 100644
index 0000000..faf9f37
@@ -0,0 +1,54 @@
+################################################################################
+#

package/lftp/lftp.mk line 12

Quoted 10 lines
package/lftp/lftp.mk new file +10 -0
+# lftp
+#
+################################################################################
+
+LFTP_VERSION = 4.4.10
+LFTP_SITE    = http://lftp.yar.ru/ftp
+LFTP_LICENSE = GPLv3+
+LFTP_LICENSE_FILES = COPYING
+LFTP_AUTORECONF = YES
+LFTP_DEPENDENCIES  = readline zlib

Is the readline dependency required?

Quoted 10 lines
package/lftp/lftp.mk new file +10 -0
+
+LFTP_CONF_OPT += --with-modules
+
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LFTP_DEPENDENCIES += gnutls
+LFTP_CONF_OPT += --with-gnutls
+else
+LFTP_CONF_OPT += --without-gnutls
+endif
+

package/lftp/lftp.mk line 32

Quoted 10 lines
package/lftp/lftp.mk new file +10 -0
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LFTP_DEPENDENCIES += openssl
+LFTP_CONF_OPT += --with-openssl
+else
+LFTP_CONF_OPT += --without-openssl
+endif
+
+# Remove /usr/share/lftp
+define LFTP_REMOVE_DATA
+        $(RM) -fr $(TARGET_DIR)/usr/share/lftp

What kind of data is stored there? If it's help text, the user may
want it.

Regards,
Arnout

Quoted 23 lines
package/lftp/lftp.mk new file +22 -0
+endef
+
+LFTP_POST_INSTALL_TARGET_HOOKS += LFTP_REMOVE_DATA
+
+# Optional commands and protocols
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_MIRROR) += cmd-mirror.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_SLEEP) += cmd-sleep.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_CMD_TORRENT) += cmd-torrent.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_FISH) += proto-fish.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_FTP) += proto-ftp.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_HTTP) += proto-http.so
+LFTP_MODULES_TO_REMOVE-$(BR2_PACKAGE_LFTP_PROTO_SFTP) += proto-sftp.so
+
+define LFTP_REMOVE_MODULES
+	for f in $(LFTP_MODULES_TO_REMOVE-) ; do \
+		$(RM) -f $(TARGET_DIR)/usr/lib/lftp/$(LFTP_VERSION)/$$f ; \
+	done
+endef
+
+LFTP_POST_INSTALL_TARGET_HOOKS += LFTP_REMOVE_MODULES
+
+$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#3 lore raw

PATCH 1/1 lftp: new package.

Hello Arnout,

Quoted 23 lines · Arnout Vandecappelle
Quoted 17 lines · Arnaud R?billout

LFTP is a sophisticated ftp/http client, and a file transfer program supporting a number of network protocols. Like BASH, it has job control and uses the readline library for input. It has bookmarks, a built-in mirror command, and can transfer several files in parallel. It was designed with reliability in mind.

---
  package/Config.in                                  |  1 +
  ...osix_fallocate-m4-check-for-cross-compile.patch | 32 +++++++++++
  ...02-Check-whether-posix_fallocate-compiles.patch | 55 
++++++++++++++++++
  package/lftp/Config.in                             | 65 
++++++++++++++++++++++
  package/lftp/lftp.mk                               | 54 
++++++++++++++++++
  5 files changed, 207 insertions(+)
Quoted 4 lines

create mode 100644
package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch
create mode 100644
package/lftp/0002-Check-whether-posix_fallocate-compiles.patch

Quoted 2 lines

Since these two patches actually fix the same problem, it's better to
squash them into a single patch.

OK.

Quoted 112 lines
Quoted 98 lines

create mode 100644 package/lftp/Config.in
create mode 100644 package/lftp/lftp.mk

package/Config.in +1 -0
index 311cc6c..bcaa8f3 100644
@@ -814,6 +814,7 @@ source "package/iputils/Config.in"
  source "package/iw/Config.in"
  source "package/kismet/Config.in"
  source "package/knock/Config.in"
+source "package/lftp/Config.in"
  source "package/lighttpd/Config.in"
  source "package/linknx/Config.in"
  source "package/links/Config.in"
(quoted diff) +0 -0

a/package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch b/package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch new file mode 100644
index 0000000..3c7209f
--- /dev/null
+++
b/package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch

package/lftp/0001-Fix-posix_fallocate-m4-check-for-cross-compile.patch new file +32 -0
@@ -0,0 +1,32 @@
+From 8a49b00a4f746f0bdc1b2490a260f98e872d0e9c Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arnaud=20R=C3=A9billout?= <[email protected]>
+Date: Mon, 25 Nov 2013 11:03:59 +0100
+Subject: [PATCH 1/2] Fix posix_fallocate m4 check for cross-compile.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+If we're cross-compiling, it's very unlikely that we use old glibc or
+AIX. So we assume that posix_fallocate works.
+
+Signed-off-by: Arnaud R?billout <[email protected]>
+---
+ m4/lftp.m4 | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/m4/lftp.m4 b/m4/lftp.m4
+index 6d7ad9c..c8efb28 100644
+--- a/m4/lftp.m4
++++ b/m4/lftp.m4
+@@ -271,6 +271,8 @@ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
+        i_cv_posix_fallocate_works=yes
+      ], [
+        i_cv_posix_fallocate_works=no
++     ], [
++       i_cv_posix_fallocate_works=yes
+      ])
+    ])
+    if test x$i_cv_posix_fallocate_works = xyes; then
+--
+1.8.4.4
+
(quoted diff) +0 -0

a/package/lftp/0002-Check-whether-posix_fallocate-compiles.patch b/package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file mode 100644
index 0000000..b137a52

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +12 -0
@@ -0,0 +1,55 @@
+From 99674dbf332427b6e2778643af026133cc2edac6 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Arnaud=20R=C3=A9billout?= <[email protected]>
+Date: Mon, 25 Nov 2013 13:22:24 +0100
+Subject: [PATCH 2/2] Check whether posix_fallocate compiles.
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+uClibc doesn't provide posix_fallocate as of 0.9.33.2, but some patches
+exist to add this function.
+
+Therefore, the only way to know if posix_fallocate is present is to 

do a

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +17 -0
+compile test.
+
+Signed-off-by: Arnaud R?billout <[email protected]>
+---
+ m4/lftp.m4 | 15 +++++++++++++++
+ 1 file changed, 15 insertions(+)
+
+diff --git a/m4/lftp.m4 b/m4/lftp.m4
+index c8efb28..d489bec 100644
+--- a/m4/lftp.m4
++++ b/m4/lftp.m4
+@@ -244,6 +244,20 @@ AC_DEFUN([LFTP_ENVIRON_CHECK],[
+
+ dnl Taken from dovecot
+ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[
++   dnl * Ensure posix_fallocate is provided by the C library.
++   AC_CACHE_CHECK([whether posix_fallocate() 

compiles],[i_cv_posix_fallocate_compiles],[
++ AC_LINK_IFELSE([
++ #include <fcntl.h>
++ int main() {

Quoted 8 lines

++ posix_fallocate(0, 0, 0);
++ }
++ ], [
++ i_cv_posix_fallocate_compiles=yes
++ ], [
++ i_cv_posix_fallocate_compiles=no
++ ])
++ ])

I think it would be simpler to work the other way round: to the
AC_LINK_IFELSE in the cross-compiling branch of AC_TRY_RUN. Then you don't need the additional variable, you can just write to posix_fallocate_works.

Quoted 1 line

Can you also send the patch upstream so they can comment on it?

OK, I've done that but I didn't receive a reply yet.

Quoted 57 lines
Quoted 57 lines

++ if test x$i_cv_posix_fallocate_compiles = xyes; then
+ dnl * Old glibcs have broken posix_fallocate(). Make sure not to
use it.

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +2 -0
+    dnl * It may also be broken in AIX.
+    AC_CACHE_CHECK([whether posix_fallocate() 

works],[i_cv_posix_fallocate_works],[
+@@ -278,6 +292,7 @@ AC_DEFUN([LFTP_POSIX_FALLOCATE_CHECK],[

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +2 -0
+    if test x$i_cv_posix_fallocate_works = xyes; then
+      AC_DEFINE(HAVE_POSIX_FALLOCATE, 1, [Define if you have a 

working posix_fallocate()])

package/lftp/0002-Check-whether-posix_fallocate-compiles.patch new file +8 -0
+    fi
++   fi
+ ])
+
+ AC_DEFUN([LFTP_POSIX_FADVISE_CHECK],[
+--
+1.8.4.4
+
package/lftp/Config.in new file +9 -0
new file mode 100644
index 0000000..df4062a
@@ -0,0 +1,65 @@
+config BR2_PACKAGE_LFTP
+    bool "lftp"
+    depends on BR2_USE_WCHAR
+    depends on BR2_INSTALL_LIBSTDCPP
+    select BR2_PACKAGE_READLINE
+    select BR2_PACKAGE_ZLIB
+    select BR2_PACKAGE_GNUTLS if !BR2_PACKAGE_OPENSSL
+    help
+      LFTP is a sophisticated ftp/http client, and a file transfer 

program

package/lftp/Config.in new file +2 -0
+      supporting a number of network protocols. Like BASH, it has job
+      control and uses the readline library for input. It has 

bookmarks,
+ a built-in mirror command, and can transfer several files in
parallel.

package/lftp/Config.in new file +17 -0
+      It was designed with reliability in mind.
+
+      http://lftp.yar.ru/
+
+if BR2_PACKAGE_LFTP
+
+comment "Commands"
+
+config BR2_PACKAGE_LFTP_CMD_MIRROR
+    bool "Mirror command"
+    help
+      Enable mirror command
+
+config BR2_PACKAGE_LFTP_CMD_SLEEP
+    bool "Sleep command"
+    help
+      Enable sleep command
Quoted 8 lines

package/lftp/Config.in line 34

Quoted 5 lines
package/lftp/Config.in new file +5 -0
+
+config BR2_PACKAGE_LFTP_CMD_TORRENT
+    bool "Torrent command"
+    help
+      Enable torrent command

Is it needed/useful to have all these options? Do they have a big
impact on size?

Yep, they save a significant amount of space.

Here are the mandatory things for lftp. Alltogether, it's 1080 Kb.

$ du -h output/target/usr/bin/lftp*
44K    output/target/usr/bin/lftp
4.0K    output/target/usr/bin/lftpget
$ du -h output/target/usr/lib/liblftp-* | grep -v -e '^0' -e 'la$'
276K    output/target/usr/lib/liblftp-jobs.so.0.0.0
512K    output/target/usr/lib/liblftp-tasks.so.0.0.0
$ du -h output/target/usr/lib/lftp/4.4.10/liblftp*
232K    output/target/usr/lib/lftp/4.4.10/liblftp-network.so
12K    output/target/usr/lib/lftp/4.4.10/liblftp-pty.so

Now come the things that can be disabled:

$ du -h output/target/usr/lib/lftp/4.4.10/* | grep -v liblftp
44K    output/target/usr/lib/lftp/4.4.10/cmd-mirror.so
16K    output/target/usr/lib/lftp/4.4.10/cmd-sleep.so
164K    output/target/usr/lib/lftp/4.4.10/cmd-torrent.so
24K    output/target/usr/lib/lftp/4.4.10/proto-file.so
32K    output/target/usr/lib/lftp/4.4.10/proto-fish.so
128K    output/target/usr/lib/lftp/4.4.10/proto-ftp.so
84K    output/target/usr/lib/lftp/4.4.10/proto-http.so
76K    output/target/usr/lib/lftp/4.4.10/proto-sftp.so

For my use case, I disable cmd-torrent, and all the proto except ftp (and proto-file, which can't be disabled).
It saves 356Kb. To me it's not a bad score.

In the Config file I offer the choice to disable/enable everything just for the sake of offering every option possible, but I agree that some options may be useless.
For example, cmd-sleep doesn't save much space, compared to the total size of lftp.

Tell me what you prefer about that. Also, if you prefer to present the options in a sub-menu instead of the main menu, or if you think a default setting should be set (like enabling ftp by defaut, because the name lftp suggests that it deals with ftp...).

Quoted 44 lines
Quoted 44 lines
package/lftp/Config.in new file +31 -0
+
+comment "Protocols"
+
+config BR2_PACKAGE_LFTP_PROTO_FISH
+    bool "FISH protocol"
+    default y
+    help
+      Enable FISH protocol
+
+config BR2_PACKAGE_LFTP_PROTO_FTP
+    bool "FTP protocol"
+    default y
+    help
+      Enable FTP protocol
+
+config BR2_PACKAGE_LFTP_PROTO_HTTP
+    bool "HTTP protocol"
+    default y
+    help
+      Enable HTTP protocol
+
+config BR2_PACKAGE_LFTP_PROTO_SFTP
+    bool "SFTP protocol"
+    default y
+    help
+      Enable SFTP protocol
+
+endif  # BR2_PACKAGE_LFTP
+
+comment "lftp requires a toolchain w/ C++, wchar"
+    depends on !(BR2_USE_WCHAR && BR2_INSTALL_LIBSTDCPP)
package/lftp/lftp.mk new file +5 -0
new file mode 100644
index 0000000..faf9f37
@@ -0,0 +1,54 @@
+################################################################################ 
 
+#
+# lftp
+#
+################################################################################ 
Quoted 9 lines

package/lftp/lftp.mk line 12

Quoted 7 lines
package/lftp/lftp.mk new file +7 -0
+
+LFTP_VERSION = 4.4.10
+LFTP_SITE    = http://lftp.yar.ru/ftp
+LFTP_LICENSE = GPLv3+
+LFTP_LICENSE_FILES = COPYING
+LFTP_AUTORECONF = YES
+LFTP_DEPENDENCIES  = readline zlib

Is the readline dependency required?

Yes it is, lftp is an interactive client. It won't compile without.

Quoted 16 lines
Quoted 16 lines
package/lftp/lftp.mk new file +15 -0
+
+LFTP_CONF_OPT += --with-modules
+
+ifeq ($(BR2_PACKAGE_GNUTLS),y)
+LFTP_DEPENDENCIES += gnutls
+LFTP_CONF_OPT += --with-gnutls
+else
+LFTP_CONF_OPT += --without-gnutls
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LFTP_DEPENDENCIES += openssl
+LFTP_CONF_OPT += --with-openssl
+else
+LFTP_CONF_OPT += --without-openssl
Quoted 8 lines

package/lftp/lftp.mk line 32

Quoted 5 lines
package/lftp/lftp.mk new file +5 -0
+endif
+
+# Remove /usr/share/lftp
+define LFTP_REMOVE_DATA
+        $(RM) -fr $(TARGET_DIR)/usr/share/lftp

What kind of data is stored there? If it's help text, the user may
want it.

Here it is:

$ du -h output/target/usr/share/lftp/*
4.0K    output/target/usr/share/lftp/convert-mozilla-cookies
4.0K    output/target/usr/share/lftp/import-ncftp
4.0K    output/target/usr/share/lftp/import-netscape
4.0K    output/target/usr/share/lftp/verify-file
4.0K    output/target/usr/share/lftp/xdg-move

Some bash and per scripts, that seem to be dedicated to specific needs. I don't think it's useful for anyone using buildroot.

Best regards,
Arnaud

#4 lore raw

PATCH 1/1 lftp: new package.

Quoted 4 lines · Arnaud R?billout

Hello Arnout,

Quoted 1 line · Arnout Vandecappelle

On 25/11/13 13:55, Arnaud R?billout wrote:

[snip]

Quoted 46 lines
Quoted 13 lines
Quoted 13 lines
package/lftp/Config.in new file +13 -0
+if BR2_PACKAGE_LFTP
+
+comment "Commands"
+
+config BR2_PACKAGE_LFTP_CMD_MIRROR
+    bool "Mirror command"
+    help
+      Enable mirror command
+
+config BR2_PACKAGE_LFTP_CMD_SLEEP
+    bool "Sleep command"
+    help
+      Enable sleep command
Quoted 8 lines

package/lftp/Config.in line 34

Quoted 5 lines
package/lftp/Config.in new file +5 -0
+
+config BR2_PACKAGE_LFTP_CMD_TORRENT
+    bool "Torrent command"
+    help
+      Enable torrent command

Is it needed/useful to have all these options? Do they have a big
impact on size?

Yep, they save a significant amount of space.

Here are the mandatory things for lftp. Alltogether, it's 1080 Kb.

$ du -h output/target/usr/bin/lftp*
44K    output/target/usr/bin/lftp
4.0K    output/target/usr/bin/lftpget
$ du -h output/target/usr/lib/liblftp-* | grep -v -e '^0' -e 'la$'
276K    output/target/usr/lib/liblftp-jobs.so.0.0.0
512K    output/target/usr/lib/liblftp-tasks.so.0.0.0
$ du -h output/target/usr/lib/lftp/4.4.10/liblftp*
232K    output/target/usr/lib/lftp/4.4.10/liblftp-network.so
12K    output/target/usr/lib/lftp/4.4.10/liblftp-pty.so

Now come the things that can be disabled:

$ du -h output/target/usr/lib/lftp/4.4.10/* | grep -v liblftp
44K    output/target/usr/lib/lftp/4.4.10/cmd-mirror.so
16K    output/target/usr/lib/lftp/4.4.10/cmd-sleep.so
164K    output/target/usr/lib/lftp/4.4.10/cmd-torrent.so
24K    output/target/usr/lib/lftp/4.4.10/proto-file.so
32K    output/target/usr/lib/lftp/4.4.10/proto-fish.so
128K    output/target/usr/lib/lftp/4.4.10/proto-ftp.so
84K    output/target/usr/lib/lftp/4.4.10/proto-http.so
76K    output/target/usr/lib/lftp/4.4.10/proto-sftp.so
Quoted 3 lines

For my use case, I disable cmd-torrent, and all the proto except ftp (and proto-file, which can't be disabled).
It saves 356Kb. To me it's not a bad score.

Agreed.

Quoted 6 lines

In the Config file I offer the choice to disable/enable everything just for the sake of offering every option possible, but I agree that some options may be useless.
For example, cmd-sleep doesn't save much space, compared to the total size of lftp.

If you feel like removing the options that don't make much of a
difference, please do. But otherwise, you can just leave things as is.

Quoted 5 lines

Tell me what you prefer about that. Also, if you prefer to present the options in a sub-menu instead of the main menu, or if you think a default setting should be set (like enabling ftp by defaut, because the name lftp suggests that it deals with ftp...).

Personally I don't like submenus, but we do have them for some
packages. So: choose whatever you prefer.

Enabling ftp by default makes sense but again is not strictly necessary.

[snip]

Your other replies were satisfactory, so after squashing the two
patches you'll probably get my Acked-by.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#5 lore raw

PATCH 1/1 lftp: new package.

Quoted 7 lines · Arnout Vandecappelle
Quoted 4 lines · Arnaud R?billout

Hello Arnout,

Quoted 1 line · Arnout Vandecappelle

On 25/11/13 13:55, Arnaud R?billout wrote:

[snip]

Quoted 1 line
Quoted 8 lines
Quoted 5 lines

In the Config file I offer the choice to disable/enable everything just for the sake of offering every option possible, but I agree that some options may be useless.
For example, cmd-sleep doesn't save much space, compared to the total size of lftp.

If you feel like removing the options that don't make much of a
difference, please do. But otherwise, you can just leave things as is.

OK, personnally I prefer to let every option visible, so that people may decide by themselves whether it's useful.

Quoted 9 lines
Quoted 8 lines

Tell me what you prefer about that. Also, if you prefer to present the options in a sub-menu instead of the main menu, or if you think a default
setting should be set (like enabling ftp by defaut, because the name lftp
suggests that it deals with ftp...).

Quoted 4 lines

Personally I don't like submenus, but we do have them for some
packages. So: choose whatever you prefer.

Enabling ftp by default makes sense but again is not strictly necessary.

Ok, I'll keep the same presentation.

Quoted 4 lines

Your other replies were satisfactory, so after squashing the two
patches you'll probably get my Acked-by.

Great ! Thanks a lot for taking time to review !

Best regards,
Arnaud

Signature · 12 lines
Arnaud R?billout
/D?veloppeur software/

SYSCOM Instruments SA,
Rue de l?Industrie 21,
1450 Ste-Croix, SUISSE
Tel : +41 (0) 24 455 44 11
Fax : +41 (0) 24 454 45 60
Visit us at www.syscom.ch <http://www.syscom.ch>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20131203/1f41fc47/attachment.html>
#6 lore raw

PATCH v2 1/1 lftp: new package.

In reply to Arnaud Rébillout

Hi Arnaud,

Quoted 12 lines · Arnaud R?billout

Here comes a second version of the patch to include lftp in buildroot.

Improvements from v1:
* Config.in
* Typo corrected
* lftp.mk
* LFTP_SOURCE removed
* LFTP_AUTORECONF set to YES
* POST_INSTALL_TARGET factorized a lot
* patches:
* Signed-off
* Patch the m4 file instead of the configure script

Such a changelog is normally included in the patch commit message
itself, like so:

lftp: new package

LFTP is a sophisticated ftp/http client, and a file transfer program
...

Signed-off-by ...

---
v2:
* Config.in: typo corrected
* ...

The part below --- is not included in the git history when Peter
commits it.

The advantage of this approach is that you can keep the history around
when you send v3 etc. of the patch. You update the patch using 'git commit --amend' or 'git rebase -i', and in the commit message you add the history below the --- line. On your side, the part below --- *will* be kept in the git history, so the next time you use git send-email, everything will be there.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F