net: fec_mxc: Fix setting of RCR for xMII
A message that is not in the archive (sent off-list or not yet received): 9848F2DB572E5649BA045B288BE08FBEE2A8C0@039-SN2MPN1-021.039d.mgd.msft.net
PATCH 1/2 net: fec_mxc: Fix setting of RCR for xMII
Hi Andy,
Quoted 4 lines · On Fri, Jul 20, 2012 at 07:35:30AM, Duan Fugang-B38611 wrote:
The changes is reasonable. Thanks!
Best Regards,
Andy
The change for MII_MODE is clear.
As to FCE, this can be discussed, and it depends on the hardware support. Actually, fec_open enables full-duplex in TCR regardless of xcv_type, so a further change could be to set the FCE bit for full-duplex flow control in fec_reg_setup regardless of xcv_type, or on the contrary, to make the full-duplex setting in fec_open depend on xcv_type. In the latter case, RCR[DRT] could also be set for the half-duplex case.
Best regards,
Beno?t