Skip to contentSkip to conversation

kexec/xen: Fix typo in __i386__ preprocessor identifier

PATCH In review Andrew Cooper 3 participants 7 messages Nov 26, 2013 – Dec 3, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kexec/xen: Fix typo in __i386__ preprocessor identifier

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>
---
 kexec/kexec-xen.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kexec/kexec-xen.c +1 -1
index e885246..d2bd7bf 100644
@@ -70,7 +70,7 @@ int xen_kexec_load(struct kexec_info *info)
 		: KEXEC_TYPE_DEFAULT;
 
 	arch = (info->kexec_flags & KEXEC_ARCH_MASK) >> 16;
-#if defined(_i386__) || defined(__x86_64__)
+#if defined(__i386__) || defined(__x86_64__)
 	if (!arch)
 		arch = EM_386;
 #endif
Signature · 7 lines
1.7.10.4


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec
Reviewed-by on v1 1/1
#2 lore raw
In reply to Andrew Cooper
Quoted 9 lines · Andrew Cooper

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>

Daniel

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#3 lore raw

Re: [PATCH] kexec-tools/xen: Fix typo in __i386__ preprocessor identifier

Ping?

Quoted 13 lines · Daniel Kiper
Quoted 9 lines · Andrew Cooper

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>

Daniel

#4 lore raw

Re: [PATCH] kexec-tools/xen: Fix typo in __i386__ preprocessor identifier

In reply to Daniel Kiper

Ping?

Quoted 5 lines · Daniel Kiper
Quoted 4 lines · Andrew Cooper

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

Quoted 8 lines
Quoted 5 lines
CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>

Daniel

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#5 lore raw

Re: [PATCH] kexec-tools/xen: Fix typo in __i386__ preprocessor identifier

Quoted 11 lines · Andrew Cooper
Quoted 10 lines · Daniel Kiper
Quoted 9 lines · Andrew Cooper

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>
Quoted 5 lines
Quoted 3 lines

Daniel

Ping?

Thanks, I had missed this.
I have applied it now.

#6 lore raw

Re: [PATCH] kexec-tools/xen: Fix typo in __i386__ preprocessor identifier

In reply to Andrew Cooper
Quoted 11 lines · Andrew Cooper
Quoted 10 lines · Daniel Kiper
Quoted 9 lines · Andrew Cooper

This typo was introduced in c/s c0b4a3f95dd80256cc6d7084436235e69b4933fb

It prevents a 32bit build of kexec from loading a 32bit crash image.

CC David Vrabel <[email protected]>
CC Daniel Kiper <[email protected]>
CC Simon Horman <[email protected]>
Quoted 5 lines
Quoted 3 lines

Daniel

Ping?

Thanks, I had missed this.
I have applied it now.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec