f2fs: remove unneeded code in punch_hole
Subsystems (2)
PATCH 1/1 f2fs: remove unneeded code in punch_hole
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE in fallocate, so we could remove the useless 'keep size' branch code which will never be excuted in punch_hole.
--- fs/f2fs/file.c | 6 ------ 1 file changed, 6 deletions(-)
fs/f2fs/file.c +0 -6
@@ -499,12 +499,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode) } } -if (!(mode &FALLOC_FL_KEEP_SIZE ) && -i_size_read (inode) <= (offset + len)) { -i_size_write (inode, offset); -mark_inode_dirty (inode); - } -return ret; }
Signature · 9 lines
1.7.9.5 ------------------------------------------------------------------------------ Shape the Mobile Experience: Free Subscription Software experts and developers: Be at the forefront of tech innovation. Intel(R) Software Adrenaline delivers strategic insight and game-changing conversations that shape the rapidly evolving mobile landscape. Sign up now. http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
Got it.
But, with this patch, we can also remove the parameter, int mode, in punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
2013-11-22 (금), 16:52 +0800, Chao Yu:
Quoted 27 lines
Because
FALLOC_FL_PUNCH_HOLEflag must be ORed withFALLOC_FL_KEEP_SIZEin fallocate, so we could remove the useless 'keep size' branch code which will never be excuted inpunch_hole.Signed-off-by Chao Yu <[email protected]>Signed-off-by Fan Li <[email protected]>--- fs/f2fs/file.c | 6 ------ 1 file changed, 6 deletions(-)fs/f2fs/file.c +0
-6@@ -499,12 +499,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode) } } -if (!(mode &FALLOC_FL_KEEP_SIZE ) && -i_size_read (inode) <= (offset + len)) { -i_size_write (inode, offset); -mark_inode_dirty (inode); - } -return ret; }
Signature · 15 lines
Jaegeuk Kim Samsung ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Hi,
Quoted 7 lines
-----Original Message-----
From: Jaegeuk Kim [mailto:[email protected]]
Sent: Wednesday, November 27, 2013 1:14 PM
To: Chao Yu
Cc: [email protected]; [email protected]; [email protected]; 谭姝; [email protected]
Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded code inpunch_hole
Quoted 6 lines
Got it.
But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
Right, we should remove it.
Thanks!
Quoted 33 lines
2013-11-22 (금), 16:52 +0800, Chao Yu:
Quoted 17 lines
Because
FALLOC_FL_PUNCH_HOLEflag must be ORed withFALLOC_FL_KEEP_SIZEin fallocate, so we could remove the useless 'keep size' branch code which will never be excuted inpunch_hole.Signed-off-by Chao Yu <[email protected]>Signed-off-by Fan Li <[email protected]>--- fs/f2fs/file.c | 6 ------ 1 file changed, 6 deletions(-)fs/f2fs/file.c +0
-0@@ -499,12 +499,6 @@ static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode) } }fs/f2fs/file.c static int punch_hole(struct inode *inode, loff_t offset, loff_t len, int mode) · line 504
Quoted 10 lines
fs/f2fs/file.c +0
-6-if (!(mode &FALLOC_FL_KEEP_SIZE ) && -i_size_read (inode) <= (offset + len)) { -i_size_write (inode, offset); -mark_inode_dirty (inode); - } -return ret; }--
Jaegeuk Kim
Samsung