spi: omap-100k: Style Fixes
cover spi: omap-100k: Style Fixes
First time contributer here submitting some style fixes.
I watched Greg Kroah-Hartman's youtube video about getting started with submitting patches and thought I would give it a try. I fixed up some errors and warnings that checkpatch.pl was giving. All patches are based off of linux-next.
Any feedback is much appreciated.
Thomas Behan (4):
spi: omap-100k: Fixed spacing on while loops
spi: omap-100k: Fixed spacing on -= operators
spi: omap-100k: Fixed spacing on commas
spi: omap-100k: Fixed style of sizeof operators
drivers/spi/spi-omap-100k.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-)
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/4 spi: omap-100k: Fixed spacing on while loops
checkpatch.pl generated several errors from "while(" statements which should have read "while (" to comply with the style guide. These errors have been fixed.
--- drivers/spi/spi-omap-100k.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/spi/spi-omap-100k.c +5 -5
@@ -147,7 +147,7 @@ static void spi100k_write_data(struct spi_master *master, int len, int data) spi100k->base + SPI_CTRL);/* Wait for bit ack send change */ -while ((readw (spi100k->base +SPI_STATUS ) &SPI_STATUS_WE ) !=SPI_STATUS_WE ); +while ((readw (spi100k->base +SPI_STATUS ) &SPI_STATUS_WE ) !=SPI_STATUS_WE );udelay (1000 );spi100k_disable_clock (master);
@@ -168,7 +168,7 @@ static int spi100k_read_data(struct spi_master *master, int len)SPI_CTRL_RD , spi100k->base + SPI_CTRL); -while ((readw (spi100k->base +SPI_STATUS ) &SPI_STATUS_RD ) !=SPI_STATUS_RD ); +while ((readw (spi100k->base +SPI_STATUS ) &SPI_STATUS_RD ) !=SPI_STATUS_RD );udelay (1000 ); dataL =readw (spi100k->base +SPI_RX_LSB );
@@ -226,7 +226,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)spi100k_write_data (spi->master, word_len, *tx++);if (xfer->rx_buf !=NULL ) *rx++ =spi100k_read_data (spi->master, word_len); - }while (c); + }while (c); }else if (word_len <=16 ) {u16 *rx;const u16 *tx;
@@ -239,7 +239,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)spi100k_write_data (spi->master,word_len, *tx++);if (xfer->rx_buf !=NULL ) *rx++ =spi100k_read_data (spi->master,word_len); - }while (c); + }while (c); }else if (word_len <=32 ) {u32 *rx;const u32 *tx;
@@ -252,7 +252,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)spi100k_write_data (spi->master,word_len, *tx);if (xfer->rx_buf !=NULL ) *rx =spi100k_read_data (spi->master,word_len); - }while (c); + }while (c); }return count - c; }
Signature · 6 lines
1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/4 spi: omap-100k: Fixed spacing on -= operators
In reply to Thomas Behancheckpatch.pl generated 3 errors from "x-=" statements which should have read "x -= x" to comply with the style guide. These errors have been fixed.
--- drivers/spi/spi-omap-100k.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/spi/spi-omap-100k.c +3 -3
@@ -221,7 +221,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) rx = xfer->rx_buf; tx = xfer->tx_buf; do { - c-=1; + c -= 1; if (xfer->tx_buf != NULL) spi100k_write_data(spi->master, word_len, *tx++); if (xfer->rx_buf != NULL)
@@ -234,7 +234,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) rx = xfer->rx_buf; tx = xfer->tx_buf; do { - c-=2; + c -= 2; if (xfer->tx_buf != NULL) spi100k_write_data(spi->master,word_len, *tx++); if (xfer->rx_buf != NULL)
@@ -247,7 +247,7 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer) rx = xfer->rx_buf; tx = xfer->tx_buf; do { - c-=4; + c -= 4; if (xfer->tx_buf != NULL) spi100k_write_data(spi->master,word_len, *tx); if (xfer->rx_buf != NULL)
Signature · 1 line
1.8.1.2
PATCH 3/4 spi: omap-100k: Fixed spacing on commas
In reply to Thomas Behancheckpatch.pl generated 5 errors due to missing spaces after commas. These errors have been fixed.
--- drivers/spi/spi-omap-100k.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/spi/spi-omap-100k.c +5 -5
@@ -155,7 +155,7 @@ static void spi100k_write_data(struct spi_master *master, int len, int data)static int spi100k_read_data (struct spi_master *master,int len) { -int dataH,dataL; +int dataH, dataL;struct omap1_spi100k *spi100k =spi_master_get_devdata (master);/* Always do at least 16 bits */
@@ -236,9 +236,9 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)do { c -=2 ;if (xfer->tx_buf !=NULL ) -spi100k_write_data (spi->master,word_len, *tx++); +spi100k_write_data (spi->master, word_len, *tx++);if (xfer->rx_buf !=NULL ) - *rx++ =spi100k_read_data (spi->master,word_len); + *rx++ =spi100k_read_data (spi->master, word_len); }while (c); }else if (word_len <=32 ) {u32 *rx;
@@ -249,9 +249,9 @@ omap1_spi100k_txrx_pio(struct spi_device *spi, struct spi_transfer *xfer)do { c -=4 ;if (xfer->tx_buf !=NULL ) -spi100k_write_data (spi->master,word_len, *tx); +spi100k_write_data (spi->master, word_len, *tx);if (xfer->rx_buf !=NULL ) - *rx =spi100k_read_data (spi->master,word_len); + *rx =spi100k_read_data (spi->master, word_len); }while (c); }return count - c;
Signature · 1 line
1.8.1.2
PATCH 4/4 spi: omap-100k: Fixed style of sizeof operators
In reply to Thomas Behancheckpatch.pl generated 2 warning due to "sizeof x" being used instead of "sizeof(x)". These warnings have been fixed.
--- drivers/spi/spi-omap-100k.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-omap-100k.c +2 -2
@@ -294,7 +294,7 @@ static int omap1_spi100k_setup(struct spi_device *spi) spi100k =spi_master_get_devdata (spi->master);if (!cs) { - cs =kzalloc (sizeof *cs,GFP_KERNEL ); + cs =kzalloc (sizeof (*cs),GFP_KERNEL );if (!cs)return -ENOMEM ; cs->base = spi100k->base + spi->chip_select *0x14 ;
@@ -411,7 +411,7 @@ static int omap1_spi100k_probe(struct platform_device *pdev)if (!pdev->id)return -EINVAL ; - master =spi_alloc_master (&pdev->dev,sizeof *spi100k); + master =spi_alloc_master (&pdev->dev,sizeof (*spi100k));if (master ==NULL ) {dev_dbg (&pdev->dev,"master allocation failed\n" );return -ENOMEM ;
Signature · 1 line
1.8.1.2