Input: define keys for WWAN and SES
Subsystems (2)
RFC PATCH 1/1 Input: define keys for WWAN and SES
This is just a RFC, so be nice to this "patch", please ;)
My goal is to add support for buttons on bcm47xx arch. However after analyzing existing database of devices I realized I don't know what code I should assign to some buttons.
First of all, older routers often have a "SES" button. SES stands for SecureEasySetup and is Broadcom's proprietary protocol which was later replaced with WPS (Wi-Fi Protected Setup).
Btw. WPS appeared to be broken because it's easy to attack it with brutal-force method. I'm not sure if any distribution have any interest in using that buttons, but it still would be nice to have support for them in kernel. One option is to add KEY_SES for this purpose. Is this the right way? It's similar to the KEY_WPS_BUTTON, but I wanted to somehow distinct them. Is there any other option? Should I use KEY_UNKNOWN or BTN_MISC or BTN_n?
Another thing is WWAN key. Some routers support mobile networks (for example Linksys 54G3G) and they may have button for enabling/disabling such connection. We already have KEY_BLUETOOTH, KEY_WLAN and KEY_UWB, but nothing for WWAN device control. I guess in future KEY_WWAN could be also supported in rfkill by mapping it to the RFKILL_TYPE_WWAN.
What do you think about this?
--- include/uapi/linux/input.h | 3 +++ 1 file changed, 3 insertions(+)
include/uapi/linux/input.h +3 -0
@@ -749,6 +749,9 @@ struct input_keymap_entry {#define BTN_TRIGGER_HAPPY39 0x2e6#define BTN_TRIGGER_HAPPY40 0x2e7 +#define KEY_WWAN 0x2e8/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +#define KEY_SES 0x2e9/* SecureEasySetup */ +/* We avoid low common keys in module aliases so they don't get huge. */ #define KEY_MIN_INTERESTING KEY_MUTE#define KEY_MAX 0x2ff
Signature · 1 line
1.7.10.4
Quoted 11 lines · Rafał Miłecki
This is just a RFC, so be nice to this "patch", please ;)
My goal is to add support for buttons on bcm47xx arch. However after analyzing existing database of devices I realized I don't know what code I should assign to some buttons.
First of all, older routers often have a "SES" button. SES stands for SecureEasySetup and is Broadcom's proprietary protocol which was later replaced with WPS (Wi-Fi Protected Setup).
Btw. WPS appeared to be broken because it's easy to attack it with brutal-force method.
Only a badly implemented WPS pin authentication is vulnerable to the brute force attack, as far as I know.
Quoted 6 lines
I'm not sure if any distribution have any interest
in using that buttons, but it still would be nice to have support for them in kernel. One option is to addKEY_SESfor this purpose. Is this the right way? It's similar to theKEY_WPS_BUTTON, but I wanted to somehow distinct them. Is there any other option? Should I useKEY_UNKNOWNorBTN_MISCorBTN_n?
I do not think you or someone else plans to implement SecureEasySetup on a device running current Linux kernel, why not use the WPS button key for for these button. If someone wants to implement this just use the WPS button key for that.
Quoted 17 lines
Another thing is WWAN key. Some routers support mobile networks (for example Linksys 54G3G) and they may have button for enabling/disabling such connection. We already have
KEY_BLUETOOTH,KEY_WLANandKEY_UWB, but nothing for WWAN device control. I guess in futureKEY_WWANcould be also supported in rfkill by mapping it to theRFKILL_TYPE_WWAN.What do you think about this?
--- include/uapi/linux/input.h | 3 +++ 1 file changed, 3 insertions(+)include/uapi/linux/input.h +0
-0
include/uapi/linux/input.h struct input_keymap_entry { · line 757
Quoted 9 lines
include/uapi/linux/input.h +3
-0@@ -749,6 +749,9 @@ struct input_keymap_entry {#define BTN_TRIGGER_HAPPY39 0x2e6#define BTN_TRIGGER_HAPPY40 0x2e7 +#define KEY_WWAN 0x2e8/* Wireless WAN (LTE, UMTS, GSM, etc.) */ +#define KEY_SES 0x2e9/* SecureEasySetup */ +/* We avoid low common keys in module aliases so they don't get huge. */ #define KEY_MIN_INTERESTING KEY_MUTE#define KEY_MAX 0x2ff
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
2013/11/28 Hauke Mehrtens <[email protected]>:
Quoted 7 lines · Rafał Miłecki
Quoted 6 lines
This is just a RFC, so be nice to this "patch", please ;)
My goal is to add support for buttons on bcm47xx arch. However after analyzing existing database of devices I realized I don't know what code I should assign to some buttons.
Quoted 8 lines
Quoted 5 lines
First of all, older routers often have a "SES" button. SES stands for SecureEasySetup and is Broadcom's proprietary protocol which was later replaced with WPS (Wi-Fi Protected Setup).
Btw. WPS appeared to be broken because it's easy to attack it with brutal-force method.Only a badly implemented WPS pin authentication is vulnerable to the brute force attack, as far as I know.
Oh, indeed, I missed that. Thanks!
Quoted 11 lines
Quoted 6 lines
I'm not sure if any distribution have any interest
in using that buttons, but it still would be nice to have support for them in kernel. One option is to addKEY_SESfor this purpose. Is this the right way? It's similar to theKEY_WPS_BUTTON, but I wanted to somehow distinct them. Is there any other option? Should I useKEY_UNKNOWNorBTN_MISCorBTN_n?I do not think you or someone else plans to implement SecureEasySetup on a device running current Linux kernel, why not use the WPS button key for for these button. If someone wants to implement this just use the WPS button key for that.
I'm just not sure about possible scenarios. I imagined end-user pressing SES button router and SES button on a device and complaining it's not working (because of SES being interpreted as WPS).
If you guys think we should just use WPS for the SES button, I'm OK with that. --
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 31 lines · Rafał Miłecki
2013/11/28 Hauke Mehrtens <[email protected]>:
Quoted 7 lines · Rafał Miłecki
Quoted 6 lines
This is just a RFC, so be nice to this "patch", please ;)
My goal is to add support for buttons on bcm47xx arch. However after analyzing existing database of devices I realized I don't know what code I should assign to some buttons.
Quoted 8 lines
Quoted 5 lines
First of all, older routers often have a "SES" button. SES stands for SecureEasySetup and is Broadcom's proprietary protocol which was later replaced with WPS (Wi-Fi Protected Setup).
Btw. WPS appeared to be broken because it's easy to attack it with brutal-force method.Only a badly implemented WPS pin authentication is vulnerable to the brute force attack, as far as I know.
Oh, indeed, I missed that. Thanks!
Quoted 11 lines
Quoted 6 lines
I'm not sure if any distribution have any interest
in using that buttons, but it still would be nice to have support for them in kernel. One option is to addKEY_SESfor this purpose. Is this the right way? It's similar to theKEY_WPS_BUTTON, but I wanted to somehow distinct them. Is there any other option? Should I useKEY_UNKNOWNorBTN_MISCorBTN_n?I do not think you or someone else plans to implement SecureEasySetup on a device running current Linux kernel, why not use the WPS button key for for these button. If someone wants to implement this just use the WPS button key for that.
Quoted 5 lines
I'm just not sure about possible scenarios. I imagined end-user pressing SES button router and SES button on a device and complaining it's not working (because of SES being interpreted as WPS).
If you guys think we should just use WPS for the SES button, I'm OK with that.
Isn't the fact that it returns WPS or SES an implementation detail?
Is WPS vs. SES just a software choice, or a hardware one? If it's a hardware one, you'd expect to have other ways to discover whether SES or WPS was requested (because that's the one supported by the hardware). If it's a software choice, then you'd expect the button to one or the other based on the software stack.
Or are both possible at the same time, and there are devices with both buttons?
Seems that adding a note that other similar "pairing" methods for Wi-Fi could be triggered when the button is used, in input.h would be enough.
Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
2013/11/28 Bastien Nocera <[email protected]>:
Quoted 15 lines · Rafał Miłecki
Quoted 5 lines
I'm just not sure about possible scenarios. I imagined end-user pressing SES button router and SES button on a device and complaining it's not working (because of SES being interpreted as WPS).
If you guys think we should just use WPS for the SES button, I'm OK with that.
Isn't the fact that it returns WPS or SES an implementation detail?
Is WPS vs. SES just a software choice, or a hardware one? If it's a hardware one, you'd expect to have other ways to discover whether SES or WPS was requested (because that's the one supported by the hardware). If it's a software choice, then you'd expect the button to one or the other based on the software stack.
Quoted 5 lines
Or are both possible at the same time, and there are devices with both buttons?
Seems that adding a note that other similar "pairing" methods for Wi-Fi could be triggered when the button is used, in
input.hwould be enough.
I think it's just a software thing (some EAP messages probably).
Thanks for your comments!
What about KEY_WWAN. Does it make sense to add it?
Signature · 5 lines
Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 19 lines · Rafał Miłecki
2013/11/28 Bastien Nocera <[email protected]>:
Quoted 18 lines · Rafał Miłecki
Quoted 5 lines
I'm just not sure about possible scenarios. I imagined end-user pressing SES button router and SES button on a device and complaining it's not working (because of SES being interpreted as WPS).
If you guys think we should just use WPS for the SES button, I'm OK with that.
Isn't the fact that it returns WPS or SES an implementation detail?
Is WPS vs. SES just a software choice, or a hardware one? If it's a hardware one, you'd expect to have other ways to discover whether SES or WPS was requested (because that's the one supported by the hardware). If it's a software choice, then you'd expect the button to one or the other based on the software stack.
Or are both possible at the same time, and there are devices with both buttons?
Quoted 8 lines
Quoted 2 lines
Seems that adding a note that other similar "pairing" methods for Wi-Fi could be triggered when the button is used, in
input.hwould be enough.I think it's just a software thing (some EAP messages probably).
Thanks for your comments!
What about
KEY_WWAN. Does it make sense to add it?
If there are "keys" with that sort of label, it would make sense to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html