Skip to contentSkip to conversation

qt: Disable QtScript on non-supported platforms

PATCH New Vicente Olivert Riera 3 participants 8 messages Nov 28, 2013 – Dec 26, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 qt: Disable QtScript on non-supported platforms

There is no support for certain platforms in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on those platforms as a quick fix for the 2013.11 release:

http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

---
 package/qt/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/qt/Config.in +1 -0
index 2651d55..dd2b6d9 100644
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y
 	help
 	  Build the Qt Script module.
Signature · 1 line
1.7.1
#1 lore raw

PATCH v3 2/2 grantlee: Disable on non-supported platforms

This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on certain platforms. To prevent this behaviour we use the same solution as we applied for BR2_PACKAGE_QT_SCRIPT

---
 package/grantlee/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/grantlee/Config.in +1 -0
index 84afad2..09ec70c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_GRANTLEE
 	bool "grantlee"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	select BR2_PACKAGE_QT_STL
 	select BR2_PACKAGE_QT_SCRIPT
 	select BR2_PACKAGE_QT_GUI_MODULE
Signature · 1 line
1.7.1
#2 lore raw

PATCH v3 2/2 grantlee: Disable on non-supported platforms

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on certain platforms. To prevent this behaviour we use the same solution as we applied for BR2_PACKAGE_QT_SCRIPT

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/2 qt5script: Disable on non-supported platforms

In reply to Vicente Olivert Riera

Is the same problem as Qt4 QtScript, it doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore.

This is a quick fix. A proposed fix to add support for MIPS64 has already been sent to Qt:

https://bugreports.qt-project.org/browse/QTBUG-35191

Fixes:

http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/

---
 package/qt5/qt5script/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/qt5/qt5script/Config.in +1 -0
index 3c5d60c..8f03e75 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT5SCRIPT
 	bool "qt5script"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	select BR2_PACKAGE_QT5BASE
 	help
 	  Qt is a cross-platform application and UI framework for
Signature · 1 line
1.7.1
#4 lore raw

PATCH 1/2 qt5script: Disable on non-supported platforms

Dear Vicente Olivert Riera,

Quoted 24 lines · Vicente Olivert Riera

Is the same problem as Qt4 QtScript, it doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore.

This is a quick fix. A proposed fix to add support for MIPS64 has already been sent to Qt:

   https://bugreports.qt-project.org/browse/QTBUG-35191

Fixes:

   http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/
---
 package/qt5/qt5script/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/package/qt5/qt5script/Config.in index 3c5d60c..8f03e75 100644

package/qt5/qt5script/Config.in line 3

Quoted 3 lines
package/qt5/qt5script/Config.in +1 -0
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT5SCRIPT
 	bool "qt5script"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT

No. Qt5 stuff should not use a symbol that is specific to Qt4, as the set of architectures supported by Qt4 may be different than the set of architectures supported by Qt5.

Also, your patch series looks weird: it starts with PATCHv3 1/2 to fix qt4, then PATCH v3 2/2 to fix grantle, and then in the same thread (so same patch series), it continues with PATCH 1/2 and PATCH 2/2 for qt5. Either make separate patch series, or better, just one patch series with all patches (so PATCHv3 1/4 to PATCHv3 4/4).

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#5 lore raw

PATCH 1/2 qt5script: Disable on non-supported platforms

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

Quoted 5 lines · Vicente Olivert Riera

Is the same problem as Qt4 QtScript, it doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore.

Quoted 8 lines

This is a quick fix. A proposed fix to add support for MIPS64 has already been sent to Qt:

   https://bugreports.qt-project.org/browse/QTBUG-35191

Fixes:

   http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/

What is the status of this patch, and the "[PATCH 2/2] qt5quick1:
Disable on non-supported platforms" patch that you sent?

Are they still needed? If so, then it should use a QT5 specific Kconfig symbol.

Let me know what to do with these patches, so that I can updated their patchwork status.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH 2/2 qt5quick1: Disable on non-supported platforms

In reply to Vicente Olivert Riera

This package selects BR2_PACKAGE_QT5SCRIPT which is not supported on certain platforms. To prevent this behaviour we use the same solution as we applied for BR2_PACKAGE_QT5SCRIPT

---
 package/qt5/qt5quick1/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/qt5/qt5quick1/Config.in +1 -0
index 9cb97a6..735f552 100644
@@ -12,6 +12,7 @@ config BR2_PACKAGE_QT5QUICK1
 	depends on BR2_PACKAGE_HAS_OPENGL_EGL
 	depends on BR2_PACKAGE_HAS_OPENGL_ES
 	depends on BR2_PACKAGE_QT5JSBACKEND_AVAILABLE
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
Signature · 1 line
1.7.1
#7 lore raw

PATCH v3 1/2 qt: Disable QtScript on non-supported platforms

In reply to Vicente Olivert Riera
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

There is no support for certain platforms in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on those platforms as a quick fix for the 2013.11 release:

   http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

Quoted 7 lines
   https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

   http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard