Skip to contentSkip to conversation

ASoC: wm_adsp: Stop region iteration when the desired region is found

PATCH Applied Charles Keepax 2 participants 3 messages Nov 28, 2013 – Nov 29, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wm_adsp: Stop region iteration when the desired region is found

When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.

---
 sound/soc/codecs/wm_adsp.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/wm_adsp.c +1 -0
index 46ec0e9..b42f9af 100644
@@ -1286,6 +1286,7 @@ static int wm_adsp_load_coeff(struct wm_adsp *dsp)
 					reg = wm_adsp_region_to_reg(mem,
 								    reg);
 					reg += offset;
+					break;
 				}
 			}
 
Signature · 1 line
1.7.2.5
maintainer Applied
#1 lore raw
Quoted 4 lines · Charles Keepax

When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.

Applied, thanks. I didn't look but does the same issue exist in the main firmware load, it's probably following the same pattern?

#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Charles Keepax

When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.

Applied, thanks. I didn't look but does the same issue exist in the main firmware load, it's probably following the same pattern?

I had a look, no similar issues in the main firmware load.

Thanks,
Charles