ASoC: wm_adsp: Stop region iteration when the desired region is found
Subsystems (3)
PATCH 1/1 ASoC: wm_adsp: Stop region iteration when the desired region is found
When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.
--- sound/soc/codecs/wm_adsp.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
sound/soc/codecs/wm_adsp.c +1 -0
@@ -1286,6 +1286,7 @@ static int wm_adsp_load_coeff(struct wm_adsp *dsp) reg =wm_adsp_region_to_reg (mem, reg); reg += offset; +break ; } }
Signature · 1 line
1.7.2.5
Quoted 4 lines · Charles Keepax
When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.
Applied, thanks. I didn't look but does the same issue exist in the main firmware load, it's probably following the same pattern?
Quoted 8 lines · Mark Brown
Quoted 4 lines · Charles Keepax
When locating the memory region relating to a coefficient block written through a bin file we keep processing the list of regions even after we have found the region we require. This patch adds a break, so we don't process redundant list items.
Applied, thanks. I didn't look but does the same issue exist in the main firmware load, it's probably following the same pattern?
I had a look, no similar issues in the main firmware load.
Thanks,
Charles