qdev: Validate hex properties
PATCH v4 1/1 qdev: Validate hex properties
strtoul(l) might overflow, in which case it'll return '-1' and set the appropriate error code. So update the calls to strtoul(l) when parsing hex properties to avoid silent overflows.
And we should be using an intermediate variable to avoid clobbering of the passed-in point on error.
Signed-off-by Hannes Reinecke <[email protected]>
--- hw/core/qdev-properties.c | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)
hw/core/qdev-properties.c +30 -6
@@ -191,6 +191,7 @@ PropertyInfo qdev_prop_uint8 = {static int parse_hex8 (DeviceState *dev,Property *prop,const char *str) { +unsigned long val;uint8_t *ptr =qdev_get_prop_ptr (dev, prop);char *end;
@@ -198,11 +199,18 @@ static int parse_hex8(DeviceState *dev, Property *prop, const char *str)return -EINVAL ; } - *ptr =strtoul (str, &end,16 ); + errno =0 ; + val =strtoul (str, &end,16 ); +if (errno) { +return -errno; + } +if (val >UINT8_MAX ) { +return -ERANGE ; + }if ((*end !='\0' ) || (end == str)) {return -EINVAL ; } - + *ptr = val;return 0 ; }
@@ -322,6 +330,7 @@ PropertyInfo qdev_prop_int32 = {static int parse_hex32 (DeviceState *dev,Property *prop,const char *str) { +unsigned long val;uint32_t *ptr =qdev_get_prop_ptr (dev, prop);char *end;
@@ -329,11 +338,18 @@ static int parse_hex32(DeviceState *dev, Property *prop, const char *str)return -EINVAL ; } - *ptr =strtoul (str, &end,16 ); + errno =0 ; + val =strtoul (str, &end,16 ); +if (errno) { +return -errno; + } +if (val >UINT32_MAX ) { +return -ERANGE ; + }if ((*end !='\0' ) || (end == str)) {return -EINVAL ; } - + *ptr = val;return 0 ; }
@@ -389,6 +405,7 @@ PropertyInfo qdev_prop_uint64 = {static int parse_hex64 (DeviceState *dev,Property *prop,const char *str) { +unsigned long long val;uint64_t *ptr =qdev_get_prop_ptr (dev, prop);char *end;
@@ -396,11 +413,18 @@ static int parse_hex64(DeviceState *dev, Property *prop, const char *str)return -EINVAL ; } - *ptr =strtoull (str, &end,16 ); + errno =0 ; + val =strtoull (str, &end,16 ); +if (errno) { +return -errno; + } +if (val >UINT64_MAX ) { +return -ERANGE ; + }if ((*end !='\0' ) || (end == str)) {return -EINVAL ; } - + *ptr = val;return 0 ; }
Signature · 1 line
1.8.1.4
Quoted 10 lines · Hannes Reinecke
strtoul(l) might overflow, in which case it'll return '-1' and set the appropriate error code. So update the calls to strtoul(l) when parsing hex properties to avoid silent overflows.
And we should be using an intermediate variable to avoid clobbering of the passed-in point on error.Signed-off-by Hannes Reinecke <[email protected]>--- hw/core/qdev-properties.c | 36 ++++++++++++++++++++++++++++++------ 1 file changed, 30 insertions(+), 6 deletions(-)
Reviewed-by Eric Blake <[email protected]>
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org