Skip to contentSkip to conversation

xen-netback: fix fragment detection in checksum setup

PATCH Superseded Paul Durrant 3 participants 7 messages Nov 29, 2013 – Dec 2, 2013

Subsystems (4)

v3 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 xen-netback: fix fragment detection in checksum setup

The code to detect fragments in checksum_setup() was missing for IPv4 and too eager for IPv6. (It transpires that Windows seems to send IPv6 packets with a fragment header even if they are not a fragment - i.e. offset is zero, and M bit is not set).

Cc Wei Liu <[email protected]>
Cc Ian Campbell <[email protected]>
Cc David Vrabel <[email protected]>

---
v3
- Use defined values for 'fragment offset' and 'more fragments'

v2
- Added comments noting what fragment/offset masks mean

 drivers/net/xen-netback/netback.c |   31 ++++++++++++++++++++++++++++---
 include/net/ipv6.h                |    3 ++-
 2 files changed, 30 insertions(+), 4 deletions(-)
drivers/net/xen-netback/netback.c +28 -3
index 64f0e0d..53419f6 100644
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;
+
 	off = iph->ihl * 4;
 
+	if (fragment) {
+		if (net_ratelimit())
+			netdev_err(vif->dev, "Packet is a fragment!\n");
+		goto out;
+	}
+
 	switch (iph->protocol) {
 	case IPPROTO_TCP:
 		if (!skb_partial_csum_set(skb, off,
@@ -1238,6 +1250,7 @@ static int checksum_setup_ipv6(struct xenvif *vif, struct sk_buff *skb,
 	bool fragment;
 	bool done;
 
+	fragment = false;
 	done = false;
 
 	off = sizeof(struct ipv6hdr);
@@ -1276,9 +1289,21 @@ static int checksum_setup_ipv6(struct xenvif *vif, struct sk_buff *skb,
 			off += (hp->hdrlen+2)<<2;
 			break;
 		}
-		case IPPROTO_FRAGMENT:
-			fragment = true;
-			/* fall through */
+		case IPPROTO_FRAGMENT: {
+			struct frag_hdr *hp = (void *)(skb->data + off);
+
+			header_size = skb->network_header +
+				off +
+				sizeof(struct frag_hdr);
+			maybe_pull_tail(skb, header_size);
+
+			if (hp->frag_off & htons(IP6_OFFSET | IP6_MF))
+				fragment = true;
+
+			nexthdr = hp->nexthdr;
+			off += sizeof(struct frag_hdr);
+			break;
+		}
 		default:
 			done = true;
 			break;
include/net/ipv6.h +2 -1
index eb198ac..488316e 100644
@@ -110,7 +110,8 @@ struct frag_hdr {
 	__be32	identification;
 };
 
-#define	IP6_MF	0x0001
+#define	IP6_MF		0x0001
+#define	IP6_OFFSET	0xFFF8
 
 #include <net/sock.h>
 
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Quoted 6 lines
drivers/net/xen-netback/netback.c +1 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 10 lines
drivers/net/xen-netback/netback.c +4 -0
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Secondly, do you really (even rate limited) want to span the system log just because some ipv4 fragmented frames end up here? That doesn't make any sense to me. Maybe bump a statistic or something like that, but a log message triggerable by a remote entity? No way.

maintainer
#2 lore raw
In reply to Paul Durrant

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Quoted 6 lines
drivers/net/xen-netback/netback.c +1 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb,
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 10 lines
drivers/net/xen-netback/netback.c +4 -0
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Secondly, do you really (even rate limited) want to span the system log just because some ipv4 fragmented frames end up here? That doesn't make any sense to me. Maybe bump a statistic or something like that, but a log message triggerable by a remote entity? No way.

#3 lore raw
Quoted 27 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 30 November 2013 21:14
To: Paul Durrant
Cc: [email protected]; [email protected]; Wei Liu; Ian Campbell; David Vrabel
Subject: Re: [PATCH net v3] xen-netback: fix fragment detection in checksum setup

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Review static int checksum_setup_ip(struct xenvif *vif,

Quoted 1 line
(quoted diff) +0 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif,

struct sk_buff *skb,

Quoted 13 lines
drivers/net/xen-netback/netback.c +3 -0
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
Quoted 8 lines

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 2 lines
drivers/net/xen-netback/netback.c +2 -0
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Ok. Clearly I'm misunderstanding what __pskb_pull_tail() does then. I was under the impression that it moved skb->tail on but left skb->data alone (which is what I want to do). I will have another look.

Quoted 5 lines

Secondly, do you really (even rate limited) want to span the system log just because some ipv4 fragmented frames end up here? That doesn't make any sense to me. Maybe bump a statistic or something like that, but a log message triggerable by a remote entity? No way.

Ok.

Paul

#4 lore raw
In reply to David Miller
Quoted 27 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 30 November 2013 21:14
To: Paul Durrant
Cc: [email protected]; [email protected]; Wei Liu; Ian Campbell; David Vrabel
Subject: Re: [PATCH net v3] xen-netback: fix fragment detection in checksum setup

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Review static int checksum_setup_ip(struct xenvif *vif,

Quoted 1 line
(quoted diff) +0 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif,

struct sk_buff *skb,

Quoted 13 lines
drivers/net/xen-netback/netback.c +3 -0
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
Quoted 8 lines

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 2 lines
drivers/net/xen-netback/netback.c +2 -0
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Ok. Clearly I'm misunderstanding what __pskb_pull_tail() does then. I was under the impression that it moved skb->tail on but left skb->data alone (which is what I want to do). I will have another look.

Quoted 5 lines

Secondly, do you really (even rate limited) want to span the system log just because some ipv4 fragmented frames end up here? That doesn't make any sense to me. Maybe bump a statistic or something like that, but a log message triggerable by a remote entity? No way.

Ok.

Paul

#5 lore raw
Quoted 32 lines · Paul Durrant
Quoted 32 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 30 November 2013 21:14
To: Paul Durrant
Cc: [email protected]; [email protected]; Wei Liu; Ian Campbell; David Vrabel
Subject: Re: [PATCH net v3] xen-netback: fix fragment detection in checksum setup

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Review static int checksum_setup_ip(struct xenvif *vif,

Quoted 1 line
(quoted diff) +0 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif,

struct sk_buff *skb,

Quoted 5 lines
drivers/net/xen-netback/netback.c +1 -0
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 10 lines
drivers/net/xen-netback/netback.c +4 -0
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

Quoted 7 lines
Quoted 3 lines

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Ok. Clearly I'm misunderstanding what __pskb_pull_tail() does then. I was under the impression that it moved skb->tail on but left skb->data alone (which is what I want to do). I will have another look.

[...]

A pull does not change the offset of skb->data but it may need to expand, i.e. reallocate, the skb head area. The kernel-doc states clearly that this can happen.

Ben.

Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
#6 lore raw
In reply to Paul Durrant
Quoted 32 lines · Paul Durrant
Quoted 32 lines

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: 30 November 2013 21:14
To: Paul Durrant
Cc: [email protected]; [email protected]; Wei Liu; Ian Campbell; David Vrabel
Subject: Re: [PATCH net v3] xen-netback: fix fragment detection in checksum setup

From: Paul Durrant <[email protected]>
Date: Fri, 29 Nov 2013 10:52:08 +0000

Review static int checksum_setup_ip(struct xenvif *vif,

Quoted 1 line
(quoted diff) +0 -0
@@ -1166,15 +1166,27 @@ static int checksum_setup_ip(struct xenvif *vif,

struct sk_buff *skb,

Quoted 5 lines
drivers/net/xen-netback/netback.c +1 -0
 	struct iphdr *iph = (void *)skb->data;
 	unsigned int header_size;
 	unsigned int off;
+	bool fragment;
 	int err = -EPROTO;

drivers/net/xen-netback/netback.c static int checksum_setup_ip(struct xenvif *vif, struct sk_buff *skb, · line 1180

Quoted 10 lines
drivers/net/xen-netback/netback.c +4 -0
 
+	fragment = false;
+
 	off = sizeof(struct iphdr);
 
 	header_size = skb->network_header + off + MAX_IPOPTLEN;
 	maybe_pull_tail(skb, header_size);
 
+	if (iph->frag_off & htons(IP_OFFSET | IP_MF))
+		fragment = true;

This function has a serious problem.

Quoted 7 lines
Quoted 3 lines

maybe_pull_tail() can change skb->data, therefore this "iph" pointer can become invalid, you're essentially dereferencing garbage if maybe_pull_tail() actually does any work.

Ok. Clearly I'm misunderstanding what __pskb_pull_tail() does then. I was under the impression that it moved skb->tail on but left skb->data alone (which is what I want to do). I will have another look.

[...]

A pull does not change the offset of skb->data but it may need to expand, i.e. reallocate, the skb head area. The kernel-doc states clearly that this can happen.

Ben.

Signature · 3 lines
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.