rtc: rtc-mxc: Remove unneeded label
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 rtc: rtc-mxc: Remove unneeded label
From: Fabio Estevam <[email protected]>
There is no need to jump to the 'exit_free_pdata' label when devm_clk_get() fails, as we can directly return the error and simplify the code a bit.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/rtc/rtc-mxc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/rtc/rtc-mxc.c +1 -4
@@ -391,8 +391,7 @@ static int mxc_rtc_probe(struct platform_device *pdev) pdata->clk =devm_clk_get (&pdev->dev,NULL );if (IS_ERR (pdata->clk)) {dev_err (&pdev->dev,"unable to get clock!\n" ); - ret =PTR_ERR (pdata->clk); - goto exit_free_pdata; +return PTR_ERR (pdata->clk); }clk_prepare_enable (pdata->clk);
@@ -447,8 +446,6 @@ static int mxc_rtc_probe(struct platform_device *pdev) exit_put_clk:clk_disable_unprepare (pdata->clk); -exit_free_pdata: -return ret; }
Signature · 1 line
1.8.1.2
Fabio Estevam
reviewerPATCH 2/2 rtc: rtc-mxc: Check the return value from clk_prepare_enable()
From: Fabio Estevam <[email protected]>
clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/rtc/rtc-mxc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/rtc/rtc-mxc.c +4 -1
@@ -394,7 +394,10 @@ static int mxc_rtc_probe(struct platform_device *pdev)return PTR_ERR (pdata->clk); } -clk_prepare_enable (pdata->clk); + ret =clk_prepare_enable (pdata->clk); +if (ret) +return ret; + rate =clk_get_rate (pdata->clk);if (rate ==32768 )
Signature · 1 line
1.8.1.2