Skip to contentSkip to conversation

ARM: mcpm: Make all mcpm functions notrace

PATCH Superseded Jon Medhurst (Tixy) 3 participants 4 messages Dec 2, 2013 – Dec 4, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: mcpm: Make all mcpm functions notrace

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

---
 arch/arm/common/Makefile        |    1 +
 arch/arm/mach-vexpress/Makefile |    3 +++
 2 files changed, 4 insertions(+)
arch/arm/common/Makefile +1 -0
index 4bdc416..70b1eff 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_SHARP_SCOOP)	+= scoop.o
 obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
 obj-$(CONFIG_ARM_TIMER_SP804)	+= timer-sp.o
 obj-$(CONFIG_MCPM)		+= mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
+CFLAGS_REMOVE_mcpm_entry.o	= -pg
 AFLAGS_mcpm_head.o		:= -march=armv7-a
 AFLAGS_vlock.o			:= -march=armv7-a
 obj-$(CONFIG_TI_PRIV_EDMA)	+= edma.o
arch/arm/mach-vexpress/Makefile +3 -0
index 0997e0b..fc649bc 100644
@@ -8,8 +8,11 @@ obj-y					:= v2m.o
 obj-$(CONFIG_ARCH_VEXPRESS_CA9X4)	+= ct-ca9x4.o
 obj-$(CONFIG_ARCH_VEXPRESS_DCSCB)	+= dcscb.o	dcscb_setup.o
 CFLAGS_dcscb.o				+= -march=armv7-a
+CFLAGS_REMOVE_dcscb.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_SPC)		+= spc.o
+CFLAGS_REMOVE_spc.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_TC2_PM)	+= tc2_pm.o
 CFLAGS_tc2_pm.o				+= -march=armv7-a
+CFLAGS_REMOVE_tc2_pm.o			= -pg
 obj-$(CONFIG_SMP)			+= platsmp.o
 obj-$(CONFIG_HOTPLUG_CPU)		+= hotplug.o
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: mcpm: Make all mcpm functions notrace

Vyacheslav, Tarek, can you add the corresponding change in your Exynos Dual Cluster support code please?

There's no need for it to be a separate patch, you can simply add the CFLAGS_REMOVE_ definitions alongside the other Makefile additions for edcs. If you want to be more fine-grained, you could mark individual functions notrace instead -- but that may just add effort and not be very useful.

Cheers
---Dave

Quoted 56 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

---
 arch/arm/common/Makefile        |    1 +
 arch/arm/mach-vexpress/Makefile |    3 +++
 2 files changed, 4 insertions(+)
arch/arm/common/Makefile +1 -0
index 4bdc416..70b1eff 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_SHARP_SCOOP)	+= scoop.o
 obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
 obj-$(CONFIG_ARM_TIMER_SP804)	+= timer-sp.o
 obj-$(CONFIG_MCPM)		+= mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
+CFLAGS_REMOVE_mcpm_entry.o	= -pg
 AFLAGS_mcpm_head.o		:= -march=armv7-a
 AFLAGS_vlock.o			:= -march=armv7-a
 obj-$(CONFIG_TI_PRIV_EDMA)	+= edma.o
arch/arm/mach-vexpress/Makefile +3 -0
index 0997e0b..fc649bc 100644
@@ -8,8 +8,11 @@ obj-y					:= v2m.o
 obj-$(CONFIG_ARCH_VEXPRESS_CA9X4)	+= ct-ca9x4.o
 obj-$(CONFIG_ARCH_VEXPRESS_DCSCB)	+= dcscb.o	dcscb_setup.o
 CFLAGS_dcscb.o				+= -march=armv7-a
+CFLAGS_REMOVE_dcscb.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_SPC)		+= spc.o
+CFLAGS_REMOVE_spc.o			= -pg
 obj-$(CONFIG_ARCH_VEXPRESS_TC2_PM)	+= tc2_pm.o
 CFLAGS_tc2_pm.o				+= -march=armv7-a
+CFLAGS_REMOVE_tc2_pm.o			= -pg
 obj-$(CONFIG_SMP)			+= platsmp.o
 obj-$(CONFIG_HOTPLUG_CPU)		+= hotplug.o
Signature · 1 line
1.7.10.4
#2 lore raw

PATCH 1/1 ARM: mcpm: Make all mcpm functions notrace

Hi, Dave!

Quoted 61 lines · Dave Martin

Vyacheslav, Tarek, can you add the corresponding change in your Exynos Dual Cluster support code please?

There's no need for it to be a separate patch, you can simply add the CFLAGS_REMOVE_ definitions alongside the other Makefile additions for edcs. If you want to be more fine-grained, you could mark individual functions notrace instead -- but that may just add effort and not be very useful.

Cheers
---Dave

Quoted 48 lines · Jon Medhurst (Tixy)

From: Dave Martin <[email protected]>

The functions in mcpm_entry.c are mostly intended for use during scary cache and coherency disabling sequences, or do other things which confuse trace ... like powering a CPU down and not returning. Similarly for the backend code.

For simplicity, this patch just makes whole files notrace. There should be more than enough traceable points on the paths to these functions, but we can be more fine-grained later if there is a need for it.

Also added spc.o to the list of files as it contains functions used by MCPM code which have comments comments like: "might be used in code paths where normal cacheable locks are not working"

---
  arch/arm/common/Makefile        |    1 +
  arch/arm/mach-vexpress/Makefile |    3 +++
  2 files changed, 4 insertions(+)
arch/arm/common/Makefile +1 -0
index 4bdc416..70b1eff 100644
@@ -13,6 +13,7 @@ obj-$(CONFIG_SHARP_SCOOP)	+= scoop.o
  obj-$(CONFIG_PCI_HOST_ITE8152)  += it8152.o
  obj-$(CONFIG_ARM_TIMER_SP804)	+= timer-sp.o
  obj-$(CONFIG_MCPM)		+= mcpm_head.o mcpm_entry.o mcpm_platsmp.o vlock.o
+CFLAGS_REMOVE_mcpm_entry.o	= -pg
  AFLAGS_mcpm_head.o		:= -march=armv7-a
  AFLAGS_vlock.o			:= -march=armv7-a
  obj-$(CONFIG_TI_PRIV_EDMA)	+= edma.o
arch/arm/mach-vexpress/Makefile +2 -0
index 0997e0b..fc649bc 100644
@@ -8,8 +8,11 @@ obj-y					:= v2m.o
  obj-$(CONFIG_ARCH_VEXPRESS_CA9X4)	+= ct-ca9x4.o
  obj-$(CONFIG_ARCH_VEXPRESS_DCSCB)	+= dcscb.o	dcscb_setup.o
  CFLAGS_dcscb.o				+= -march=armv7-a
+CFLAGS_REMOVE_dcscb.o			= -pg
  obj-$(CONFIG_ARCH_VEXPRESS_SPC)		+= spc.o
+CFLAGS_REMOVE_spc.o			= -pg
  obj-$(CONFIG_ARCH_VEXPRESS_TC2_PM)	+= tc2_pm.o
Quoted 8 lines
Quoted 8 lines
arch/arm/mach-vexpress/Makefile +1 -0
  CFLAGS_tc2_pm.o				+= -march=armv7-a
+CFLAGS_REMOVE_tc2_pm.o			= -pg
  obj-$(CONFIG_SMP)			+= platsmp.o
  obj-$(CONFIG_HOTPLUG_CPU)		+= hotplug.o
Signature · 1 line
1.7.10.4

Will be done in next version.

Best regards,
Tarek Dakhran.

#3 lore raw

PATCH 1/1 ARM: mcpm: Make all mcpm functions notrace

Quoted 12 lines · Tarek Dakhran

Hi, Dave!

Quoted 9 lines · Dave Martin

Vyacheslav, Tarek, can you add the corresponding change in your Exynos Dual Cluster support code please?

There's no need for it to be a separate patch, you can simply add the CFLAGS_REMOVE_ definitions alongside the other Makefile additions for edcs. If you want to be more fine-grained, you could mark individual functions notrace instead -- but that may just add effort and not be very useful.

[...]

Quoted 2 lines

Will be done in next version.

Thanks
---Dave