Skip to contentSkip to conversation

qt5script: Disable on MIPS64 n64 ABI

PATCH Superseded Vicente Olivert Riera 2 participants 3 messages Dec 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 qt5script: Disable on MIPS64 n64 ABI

There is no support for JavaScritCore on MIPS64 n64 ABI so as a quick fix we can disable the posibility of selecting this package. Meanwhile a proposed patch has already been sent to Qt:

https://bugreports.qt-project.org/browse/QTBUG-35191

Fixes:

http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/

---
 package/qt5/qt5script/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/qt5/qt5script/Config.in +1 -0
index 3c5d60c..4358f95 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_QT5SCRIPT
 	bool "qt5script"
+	depends on !BR2_MIPS_NABI64
 	select BR2_PACKAGE_QT5BASE
 	help
 	  Qt is a cross-platform application and UI framework for
Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 1/1 qt5script: Disable on MIPS64 n64 ABI

Dear Vicente Olivert Riera,

Quoted 6 lines · Vicente Olivert Riera

There is no support for JavaScritCore on MIPS64 n64 ABI so as a quick fix we can disable the posibility of selecting this package. Meanwhile a proposed patch has already been sent to Qt:

   https://bugreports.qt-project.org/browse/QTBUG-35191
Quoted 8 lines

Fixes:

   http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/
---
 package/qt5/qt5script/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Now that 2013.11 has been released, we don't need "quick fixes" anymore. What about integrating the upstream Qt5 fix instead?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 qt5script: Disable on MIPS64 n64 ABI

Quoted 18 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

Quoted 6 lines · Vicente Olivert Riera

There is no support for JavaScritCore on MIPS64 n64 ABI so as a quick fix we can disable the posibility of selecting this package. Meanwhile a proposed patch has already been sent to Qt:

    https://bugreports.qt-project.org/browse/QTBUG-35191
Quoted 8 lines

Fixes:

    http://autobuild.buildroot.net/results/231/231c112a3fc18e6cd7d6d10873e22144525c7280/
---
  package/qt5/qt5script/Config.in |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 7 lines

Now that 2013.11 has been released, we don't need "quick fixes" anymore. What about integrating the upstream Qt5 fix instead?

Thanks!

Thomas

Ok, the problem with qt5script on MIPS64 n64 is already fixed on Qt 5.2, and the Release Candidate 1 is already available so we will have Qt 5.2 final release in few weeks. This problem will be fixed with the next version bump.

Signature · 1 line
Vincent