Skip to contentSkip to conversation

gpu: host1x: Add MIPI pad calibration DT bindings

PATCH In review Thierry Reding 3 participants 6 messages Dec 2, 2013 – Dec 4, 2013 3 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: Add MIPI pad calibration DT bindings

Introduce device tree bindings for the MIPI pad calibration controller found on Tegra SoCs. The controller can be used to perform calibration of pads used for DSI and CSI peripherals.

---
 .../bindings/misc/nvidia,tegra114-mipi.txt         | 37 ++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +37 -0
new file mode 100644
index 000000000000..beb75ec7f6fc
@@ -0,0 +1,37 @@
+NVIDIA Tegra MIPI pad calibration controller
+
+Required properties:
+- compatible: "nvidia,tegra<chip>-mipi"
+- reg: Physical base address and length of the controller's registers.
+- clocks: The clock consumed by the controller.
+- #nvidia,mipi-calibrate-cells: Should be 1. The cell is a bitmask of the pads
+  that need to be calibrated for a given device.
+
+User nodes need to contain an nvidia,mipi-calibrate property that has a
+phandle to refer to the calibration controller node and a bitmask of the pads
+that need to be calibrated.
+
+Example:
+
+	mipi: mipi@700e3000 {
+		compatible = "nvidia,tegra114-mipi";
+		reg = <0x700e3000 0x100>;
+		clocks = <&tegra_car TEGRA114_CLK_MIPI_CAL>;
+		#nvidia,mipi-calibrate-cells = <1>;
+	};
+
+	...
+
+	host1x@50000000 {
+		...
+
+		dsi@54300000 {
+			...
+
+			nvidia,mipi-calibrate = <&mipi 0x060>;
+
+			...
+		};
+
+		...
+	};
Signature · 1 line
1.8.4.2

A message that is not in the archive (sent off-list or not yet received): 1385990934-20809-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#2 lore raw
Quoted 7 lines · Thierry Reding

Introduce device tree bindings for the MIPI pad calibration controller found on Tegra SoCs. The controller can be used to perform calibration of pads used for DSI and CSI peripherals.

---
.../bindings/misc/nvidia,tegra114-mipi.txt | 37 ++++++++++++++++++++++

Should this just be nvidia,tegra-mipi.txt (as you have it supported for tegra<chip>)?

Quoted 2 lines
1 file changed, 37 insertions(+)

create mode 100644 Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt

Is this really pad control or pin? I ask as its rare to see pad control.

Quoted 7 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +0 -0
new file mode 100644
index 000000000000..beb75ec7f6fc

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt line 8

Quoted 8 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +8 -0
@@ -0,0 +1,37 @@
+NVIDIA Tegra MIPI pad calibration controller
+
+Required properties:
+- compatible: "nvidia,tegra<chip>-mipi"
+- reg: Physical base address and length of the controller's registers.
+- clocks: The clock consumed by the controller.
+- #nvidia,mipi-calibrate-cells: Should be 1. The cell is a bitmask of the pads
+  that need to be calibrated for a given device.

Is there a case that this would not be set to 1? If so, why bother with the property right now? One would assume for a non-1 case a new compatible will be required anyways.

Quoted 36 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +29 -0
+
+User nodes need to contain an nvidia,mipi-calibrate property that has a
+phandle to refer to the calibration controller node and a bitmask of the pads
+that need to be calibrated.
+
+Example:
+
+	mipi: mipi@700e3000 {
+		compatible = "nvidia,tegra114-mipi";
+		reg = <0x700e3000 0x100>;
+		clocks = <&tegra_car TEGRA114_CLK_MIPI_CAL>;
+		#nvidia,mipi-calibrate-cells = <1>;
+	};
+
+	...
+
+	host1x@50000000 {
+		...
+
+		dsi@54300000 {
+			...
+
+			nvidia,mipi-calibrate = <&mipi 0x060>;
+
+			...
+		};
+
+		...
+	};
Signature · 6 lines
1.8.4.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

A message that is not in the archive (sent off-list or not yet received): 3F910C9B-7205-4FC3-A75E-269277ACB513-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org

#4 lore raw
Quoted 7 lines · Kumar Gala
Quoted 4 lines · Thierry Reding

Introduce device tree bindings for the MIPI pad calibration controller found on Tegra SoCs. The controller can be used to perform calibration of pads used for DSI and CSI peripherals.

Quoted 6 lines
Quoted 3 lines

---
.../bindings/misc/nvidia,tegra114-mipi.txt | 37 ++++++++++++++++++++++

Should this just be nvidia,tegra-mipi.txt (as you have it supported for tegra<chip>)?

Tegra114 is the first chip to support it. Subsequent chips should be backwards-compatible. But it's probably safer to change the compatible property documentation to only include nvidia,tegra114-mipi for now. Newer SoC generations can always be added when support for them is added.

Quoted 4 lines
Quoted 2 lines
1 file changed, 37 insertions(+)

create mode 100644 Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt

Is this really pad control or pin? I ask as its rare to see pad control.

It's not really control at all. Rather it is a hardware block that performs calibration to obtain the optimal parameters for a given set of pads.

Since you mention it, is there a better location for this file? I couldn't find anything that matched, so I just put it here. I suppose I could add it to Documentation/devicetree/bindings/gpu where the rest of the bindings reside for the Tegra GPU, but this block is also used by CSI, which is a capture interface and not really related to the GPU at all.

Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +4 -0
new file mode 100644
index 000000000000..beb75ec7f6fc
@@ -0,0 +1,37 @@
+NVIDIA Tegra MIPI pad calibration controller
+
+Required properties:
+- compatible: "nvidia,tegra<chip>-mipi"
Quoted 8 lines

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt line 8

Quoted 4 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +4 -0
+- reg: Physical base address and length of the controller's registers.
+- clocks: The clock consumed by the controller.
+- #nvidia,mipi-calibrate-cells: Should be 1. The cell is a bitmask of the pads
+  that need to be calibrated for a given device.

Is there a case that this would not be set to 1? If so, why bother with the property right now? One would assume for a non-1 case a new compatible will be required anyways.

There is no such case now, and I'm not aware of a future chip that has more than 32 pads and would therefore require this to be anything other than 1.

However having this property allows the DT to be parsed without specific knowledge about the hardware block. If this was implied by the value of the compatible property, a generic parser wouldn't know how to interpret the data.

A schema validator wouldn't be able to check that the content was correct either.

Thierry

#5 lore raw
In reply to a message not in the archive

On Mon, Dec 02, 2013 at 02:28:54PM +0100, Thierry Reding wrote:
[...]

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt line 31

Quoted 7 lines
Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt new file +7 -0
+	host1x@50000000 {
+		...
+
+		dsi@54300000 {
+			...
+
+			nvidia,mipi-calibrate = <&mipi 0x060>;

I just occurred to me that perhaps having a list of pad indices here would be easier to write and parse than a bitmask. So alternatively this could be:

			nvidia,mipi-calibrate = <&mipi 5>, <&mipi 6>;

Thierry

#6 lore raw
In reply to a message not in the archive

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt line 6

Quoted 10 lines · Thierry Reding

Introduce device tree bindings for the MIPI pad calibration controller found on Tegra SoCs. The controller can be used to perform calibration of pads used for DSI and CSI peripherals.

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt +4 -0
 
+Required properties:
+- compatible: "nvidia,tegra<chip>-mipi"
+- reg: Physical base address and length of the controller's registers.
+- clocks: The clock consumed by the controller.

I'd prefer all our new drivers just use clock-names from the start, so we never have to specify that certain clocks must be at a certain index in the clocks property. How about:

+ - clocks: Must contain an entry for each entry in clock-names.
+ See ../clocks/clock-bindings.txt for details.
+ - clock-names: Must include the following entries:
+ - mipi

(or "cal" or whatever makes sense there)

A message that is not in the archive (sent off-list or not yet received): [email protected]

#8 lore raw
Quoted 21 lines · Stephen Warren

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt line 6

Quoted 10 lines · Thierry Reding

Introduce device tree bindings for the MIPI pad calibration controller found on Tegra SoCs. The controller can be used to perform calibration of pads used for DSI and CSI peripherals.

Documentation/devicetree/bindings/misc/nvidia,tegra114-mipi.txt +4 -0
 
+Required properties:
+- compatible: "nvidia,tegra<chip>-mipi"
+- reg: Physical base address and length of the controller's registers.
+- clocks: The clock consumed by the controller.

I'd prefer all our new drivers just use clock-names from the start, so we never have to specify that certain clocks must be at a certain index in the clocks property. How about:

(quoted diff) +4 -0
+  - clocks: Must contain an entry for each entry in clock-names.
+    See ../clocks/clock-bindings.txt for details.
+  - clock-names: Must include the following entries:
+    - mipi
Quoted 1 line

(or "cal" or whatever makes sense there)

"mipi-cal" sounds like a good name. That's also what the clock is called in the TRM.

I'll repost with this fixed up and I'll move this file into the mipi subdirectory that I need for the MIPI DSI DT bindings anyway.

Thierry