Skip to contentSkip to conversation

phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030_USB

PATCH In review Kishon Vijay Abraham I 2 participants 3 messages Dec 3, 2013 – Jan 7, 2014 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 phy: kconfig: add depends on "USB_PHY" to OMAP_USB2 and TWL4030_USB

Fixes
warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT)
that shows up while disabling USB_SUPPORT from menuconfig.

---
Changes from v1:
* changed from *depends on USB_SUPPORT* to *depends on USB_PHY" and also changed the subject.

 drivers/phy/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/phy/Kconfig +2 -2
index a344f3d..330ef2d 100644
@@ -24,8 +24,8 @@ config PHY_EXYNOS_MIPI_VIDEO
 config OMAP_USB2
 	tristate "OMAP USB2 PHY Driver"
 	depends on ARCH_OMAP2PLUS
+	depends on USB_PHY
 	select GENERIC_PHY
-	select USB_PHY
 	select OMAP_CONTROL_USB
 	help
 	  Enable this to support the transceiver that is part of SOC. This
@@ -36,8 +36,8 @@ config OMAP_USB2
 config TWL4030_USB
 	tristate "TWL4030 USB Transceiver Driver"
 	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
+	depends on USB_PHY
 	select GENERIC_PHY
-	select USB_PHY
 	help
 	  Enable this to support the USB OTG transceiver on TWL4030
 	  family chips (including the TWL5030 and TPS659x0 devices).
Signature · 1 line
1.7.10.4
#1 lore raw

Hi,

Quoted 4 lines · Kishon Vijay Abraham I

Fixes
warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT)
that shows up while disabling USB_SUPPORT from menuconfig.

[...]

drivers/phy/Kconfig config OMAP_USB2 · line 43

Quoted 9 lines

config TWL4030_USB

drivers/phy/Kconfig +1 -1
 	tristate "TWL4030 USB Transceiver Driver"
 	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
+	depends on USB_PHY
 	select GENERIC_PHY
-	select USB_PHY
 	help
 	  Enable this to support the USB OTG transceiver on TWL4030
 	  family chips (including the TWL5030 and TPS659x0 devices).

This introduced a minor problem in 3.13-rc5: User is no longer able to select TWL4030_USB with menuconfig, since there is no menu entry for enabling USB_PHY. The only way to enable TWL4030_USB is to enable some other option first that happens to select USB_PHY...

A.

#2 lore raw
Quoted 8 lines · Aaro Koskinen

Hi,

Quoted 4 lines · Kishon Vijay Abraham I

Fixes
warning: (OMAP_USB2 && TWL4030_USB) selects USB_PHY which has unmet direct dependencies (USB_SUPPORT)
that shows up while disabling USB_SUPPORT from menuconfig.

[...]

Quoted 14 lines

drivers/phy/Kconfig config OMAP_USB2 · line 43

Quoted 9 lines

config TWL4030_USB

drivers/phy/Kconfig +1 -1
 	tristate "TWL4030 USB Transceiver Driver"
 	depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
+	depends on USB_PHY
 	select GENERIC_PHY
-	select USB_PHY
 	help
 	  Enable this to support the USB OTG transceiver on TWL4030
 	  family chips (including the TWL5030 and TPS659x0 devices).

This introduced a minor problem in 3.13-rc5: User is no longer able to select TWL4030_USB with menuconfig, since there is no menu entry for enabling USB_PHY. The only way to enable TWL4030_USB is to enable some other option first that happens to select USB_PHY...

huh.. I think we should go back to my v1 [1] or make USB_PHY selectable. I'm not sure if there is any other way to handle this.

Thanks
Kishon

[1] -> https://groups.google.com/forum/#!topic/linux.kernel/Omf83s4rkwY

Quoted 3 lines

A.