Skip to contentSkip to conversation

mx6sabresd: Allow probing HSYNC, VSYNC and DISP_CLK signals

PATCH New Fabio Estevam 2 participants 4 messages Dec 4, 2013 – Dec 17, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/2 mx6sabresd: Allow probing HSYNC, VSYNC and DISP_CLK signals

From: Fabio Estevam <[email protected]>

HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.

Configure them as active pins.

---
Changes since v2:
- Fix typo in HSYNC
Changes since v1:
- Add a comment in the code explaining that the purpose of configuring these pins are for debugging

 board/freescale/mx6sabresd/mx6sabresd.c | 9 +++++++++
 1 file changed, 9 insertions(+)
board/freescale/mx6sabresd/mx6sabresd.c +9 -0
index 851cbe9..1d5bba6 100644
@@ -135,6 +135,12 @@ static void setup_spi(void)
 	imx_iomux_v3_setup_multiple_pads(ecspi1_pads, ARRAY_SIZE(ecspi1_pads));
 }
 
+iomux_v3_cfg_t const di0_pads[] = {
+	MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK,	/* DISP0_CLK */
+	MX6_PAD_DI0_PIN2__IPU1_DI0_PIN02,		/* DISP0_HSYNC */
+	MX6_PAD_DI0_PIN3__IPU1_DI0_PIN03,		/* DISP0_VSYNC */
+};
+
 static void setup_iomux_uart(void)
 {
 	imx_iomux_v3_setup_multiple_pads(uart1_pads, ARRAY_SIZE(uart1_pads));
@@ -386,6 +392,9 @@ static void setup_display(void)
 	struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR;
 	int reg;
 
+	/* Setup HSYNC, VSYNC, DISP_CLK for debugging purposes */
+	imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads));
+
 	enable_ipu_clock();
 	imx_setup_hdmi();
 
Signature · 1 line
1.8.1.2
#1 lore raw

PATCH v3 2/2 mx6sabresd: Fix LVDS width and color format

From: Fabio Estevam <[email protected]>

mx6sabresd boards have a 18-bit LVDS data width and the correct color format is RGB666.

---
Changes since v2:
- None
Changes since v1:
- None

 board/freescale/mx6sabresd/mx6sabresd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
board/freescale/mx6sabresd/mx6sabresd.c +3 -3
index 1d5bba6..55e7961 100644
@@ -294,15 +294,15 @@ static void enable_lvds(struct display_info_t const *dev)
 	struct iomuxc *iomux = (struct iomuxc *)
 				IOMUXC_BASE_ADDR;
 	u32 reg = readl(&iomux->gpr[2]);
-	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_24BIT |
-	       IOMUXC_GPR2_DATA_WIDTH_CH1_24BIT;
+	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT |
+	       IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT;
 	writel(reg, &iomux->gpr[2]);
 }
 
 static struct display_info_t const displays[] = {{
 	.bus	= -1,
 	.addr	= 0,
-	.pixfmt	= IPU_PIX_FMT_LVDS666,
+	.pixfmt	= IPU_PIX_FMT_RGB666,
 	.detect	= NULL,
 	.enable	= enable_lvds,
 	.mode	= {
Signature · 1 line
1.8.1.2
#2 lore raw

PATCH v3 2/2 mx6sabresd: Fix LVDS width and color format

Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

mx6sabresd boards have a 18-bit LVDS data width and the correct color format is RGB666.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v3 1/2 mx6sabresd: Allow probing HSYNC, VSYNC and DISP_CLK signals

In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.

Configure them as active pins.

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================