pwm: sysfs: Convert to use ATTRIBUTE_GROUPS macro
PATCH 1/1 pwm: sysfs: Convert to use ATTRIBUTE_GROUPS macro
Signed-off-by Axel Lin <[email protected]>
--- drivers/pwm/sysfs.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/pwm/sysfs.c +2 -10
@@ -169,15 +169,7 @@ static struct attribute *pwm_attrs[] = { &dev_attr_polarity.attr, NULL }; - -static const struct attribute_group pwm_attr_group = { - .attrs = pwm_attrs, -}; - -static const struct attribute_group *pwm_attr_groups[] = { - &pwm_attr_group, -NULL , -}; +ATTRIBUTE_GROUPS (pwm);static void pwm_export_release (struct device *child) {
@@ -205,7 +197,7 @@ static int pwm_export_child(struct device *parent, struct pwm_device *pwm) export->child.release = pwm_export_release; export->child.parent = parent; export->child.devt =MKDEV (0 ,0 ); - export->child.groups = pwm_attr_groups; + export->child.groups = pwm_groups;dev_set_name (&export->child,"pwm%u" , pwm->hwpwm); ret =device_register (&export->child);
Signature · 1 line
1.8.1.2
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>--- drivers/pwm/sysfs.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
Looks good. Can you please add a commit message? If nothing else it could say what the advantages are of using the macro, even if that may be somewhat obvious.
Thierry