Skip to contentSkip to conversation

i2c: i2c-imx: Check the return value from clk_prepare_enable()

PATCH Applied Fabio Estevam 2 participants 2 messages Dec 4, 2013 – Dec 12, 2013 1 message not in the archive

Subsystems (3)
Arm i.MX and Layerscape I2C subsystem host drivers Freescale i.MX I2C driver
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 i2c: i2c-imx: Check the return value from clk_prepare_enable()

From: Fabio Estevam <[email protected]>

clk_prepare_enable() may fail, so let's check its return value and propagate it in the case of error.

Signed-off-by Fabio Estevam <[email protected]>
---
 drivers/i2c/busses/i2c-imx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/i2c/busses/i2c-imx.c +3 -1
index 1d7efa3..d0cfbb4 100644
@@ -312,7 +312,9 @@ static int i2c_imx_start(struct imx_i2c_struct *i2c_imx)
 
 	dev_dbg(&i2c_imx->adapter.dev, "<%s>\n", __func__);
 
-	clk_prepare_enable(i2c_imx->clk);
+	result = clk_prepare_enable(i2c_imx->clk);
+	if (result)
+		return result;
 	imx_i2c_write_reg(i2c_imx->ifdr, i2c_imx, IMX_I2C_IFDR);
 	/* Enable I2C controller */
 	imx_i2c_write_reg(i2c_imx->hwdata->i2sr_clr_opcode, i2c_imx, IMX_I2C_I2SR);
Signature · 1 line
1.8.1.2

A message that is not in the archive (sent off-list or not yet received): 1386195697-4417-1-git-send-email-festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org