serial: add missing depends on ARCH_ZYNQ
PATCH 1/1 serial: add missing depends on ARCH_ZYNQ
The cadence serial driver is some ARCH_ZYNQ specific driver. Add a depends on ARCH_ZYNQ for this driver.
--- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/serial/Kconfig +1 -0
@@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT config DRIVER_SERIAL_CADENCE bool "Cadence UART driver" + depends on ARCH_ZYNQ help Say Y here if you have a Cadence serial IP core.
Signature · 7 lines
1.8.4.2 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Hi!
Quoted 29 lines · Alexander Aring
The cadence serial driver is some
ARCH_ZYNQspecific driver. Add a depends onARCH_ZYNQfor this driver.Signed-off-by Alexander Aring <[email protected]>--- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/serial/Kconfig +1
-0@@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT config DRIVER_SERIAL_CADENCE bool "Cadence UART driver" + depends on ARCH_ZYNQ help Say Y here if you have a Cadence serial IP core.Signature · 7 lines
1.8.4.2 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Does is not compile with other archs?
This is intended to be a generic driver; Zynq just happens to be the only user. -> It should not depend on ARCH_ZYNQ.
Regards,
Steffen
Signature · 9 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Hi Steffen,
Quoted 27 lines · Steffen Trumtrar
Hi!
Quoted 24 lines · Alexander Aring
The cadence serial driver is some
ARCH_ZYNQspecific driver. Add a depends onARCH_ZYNQfor this driver.Signed-off-by Alexander Aring <[email protected]>--- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/serial/Kconfig +1
-0@@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT config DRIVER_SERIAL_CADENCE bool "Cadence UART driver" + depends on ARCH_ZYNQ help Say Y here if you have a Cadence serial IP core.Signature · 1 line
1.8.4.2
Quoted 9 lines
Quoted 5 lines
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/bareboxDoes is not compile with other archs?
This is intended to be a generic driver; Zynq just happens to be the only user. -> It should not depend onARCH_ZYNQ.
oh, I first figure out a depends on COMMON_CLK was missing and though that this driver is a platform specific driver.
When it's a generic driver we should add a "depends on COMMON_CLK" because there are some generic clock api calls.
- Alex
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 40 lines · Alexander Aring
Hi Steffen,
Quoted 27 lines · Steffen Trumtrar
Hi!
Quoted 24 lines · Alexander Aring
The cadence serial driver is some
ARCH_ZYNQspecific driver. Add a depends onARCH_ZYNQfor this driver.Signed-off-by Alexander Aring <[email protected]>--- drivers/serial/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/serial/Kconfig +1
-0@@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT config DRIVER_SERIAL_CADENCE bool "Cadence UART driver" + depends on ARCH_ZYNQ help Say Y here if you have a Cadence serial IP core.Signature · 1 line
1.8.4.2Quoted 9 lines
Quoted 5 lines
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/bareboxDoes is not compile with other archs?
This is intended to be a generic driver; Zynq just happens to be the only user. -> It should not depend onARCH_ZYNQ.
Quoted 4 lines
oh, I first figure out a depends on
COMMON_CLKwas missing and though that this driver is a platform specific driver.When it's a generic driver we should add a "depends on
COMMON_CLK"
or for this case a "select COMMON_CLK" would be better. :-)
- Alex
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Hi Steffen,
now I figoure out that this is a bigger problem.
There are architecture which not use the COMMON_CLK framework and has it own clock framework implementation (for me it was ARCH_AT91). Then the build failed.
So now we could make a depends on !ARCH_AT91 in COMMON_CLK and a depends on COMMON_CLK in DRIVER_SERIAL_CADENCE... but this is very ugly and maybe the ARCH_AT91 get a COMMON_CLK framework...
Sorry for the noise.
- Alex
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox