xen: remove duplicate #includes
PATCH 1/1 xen: remove duplicate #includes
---
Build-tested.
xen/arch/arm/time.c | 1 - xen/arch/x86/acpi/boot.c | 1 - xen/arch/x86/acpi/power.c | 1 - xen/arch/x86/hvm/intercept.c | 1 - xen/arch/x86/hvm/svm/svm.c | 1 - xen/arch/x86/setup.c | 1 - xen/arch/x86/time.c | 1 - xen/arch/x86/x86_64/acpi_mmcfg.c | 1 - xen/arch/x86/x86_64/traps.c | 1 - xen/common/device_tree.c | 1 - xen/common/gdbstub.c | 1 - xen/common/kexec.c | 1 - xen/common/schedule.c | 1 - xen/drivers/cpufreq/cpufreq_ondemand.c | 1 - xen/drivers/cpufreq/utility.c | 1 - xen/drivers/passthrough/vtd/iommu.c | 1 - xen/include/asm-x86/hvm/vpt.h | 1 - 17 files changed, 17 deletions(-)
xen/arch/arm/time.c +0 -1
@@ -27,7 +27,6 @@#include <xen/softirq.h> #include <xen/sched.h> #include <xen/time.h> -#include <xen/sched.h> #include <xen/event.h> #include <asm/system.h> #include <asm/time.h>
xen/arch/x86/acpi/boot.c +0 -1
@@ -34,7 +34,6 @@#include <asm/page.h> #include <asm/apic.h> #include <asm/io_apic.h> -#include <asm/apic.h> #include <asm/io.h> #include <asm/mpspec.h> #include <asm/processor.h>
xen/arch/x86/acpi/power.c +0 -1
@@ -20,7 +20,6 @@#include <asm/irq.h> #include <asm/init.h> #include <xen/spinlock.h> -#include <xen/sched.h> #include <xen/domain.h> #include <xen/console.h> #include <xen/iommu.h>
xen/arch/x86/hvm/intercept.c +0 -1
@@ -26,7 +26,6 @@#include <asm/hvm/support.h> #include <asm/hvm/domain.h> #include <xen/lib.h> -#include <xen/sched.h> #include <asm/current.h> #include <io_ports.h> #include <xen/event.h>
xen/arch/x86/hvm/svm/svm.c +0 -1
@@ -46,7 +46,6 @@#include <asm/hvm/hvm.h> #include <asm/hvm/support.h> #include <asm/hvm/io.h> -#include <asm/hvm/emulate.h> #include <asm/hvm/svm/asid.h> #include <asm/hvm/svm/svm.h> #include <asm/hvm/svm/vmcb.h>
xen/arch/x86/setup.c +0 -1
@@ -10,7 +10,6 @@#include <xen/acpi.h> #include <xen/efi.h> #include <xen/console.h> -#include <xen/serial.h> #include <xen/trace.h> #include <xen/multiboot.h> #include <xen/domain_page.h>
xen/arch/x86/time.c +0 -1
@@ -14,7 +14,6 @@#include <xen/event.h> #include <xen/sched.h> #include <xen/lib.h> -#include <xen/config.h> #include <xen/init.h> #include <xen/time.h> #include <xen/timer.h>
xen/arch/x86/x86_64/acpi_mmcfg.c +0 -1
@@ -35,7 +35,6 @@#include <asm/page.h> #include <asm/apic.h> #include <asm/io_apic.h> -#include <asm/apic.h> #include <asm/io.h> #include <asm/mpspec.h> #include <asm/processor.h>
xen/arch/x86/x86_64/traps.c +0 -1
@@ -9,7 +9,6 @@#include <xen/irq.h> #include <xen/symbols.h> #include <xen/console.h> -#include <xen/sched.h> #include <xen/shutdown.h> #include <xen/nmi.h> #include <xen/guest_access.h>
xen/common/device_tree.c +0 -1
@@ -22,7 +22,6 @@#include <xen/string.h> #include <xen/cpumask.h> #include <xen/ctype.h> -#include <xen/lib.h> #include <asm/early_printk.h> struct dt_early_info __initdata early_info;
xen/common/gdbstub.c +0 -1
@@ -45,7 +45,6 @@#include <xen/console.h> #include <xen/errno.h> #include <xen/delay.h> -#include <xen/init.h> #include <asm/byteorder.h> /* Printk isn't particularly safe just after we've trapped to the
xen/common/kexec.c +0 -1
@@ -24,7 +24,6 @@#include <xen/spinlock.h> #include <xen/version.h> #include <xen/console.h> -#include <xen/kexec.h> #include <xen/kimage.h> #include <public/elfnote.h> #include <xsm/xsm.h>
xen/common/schedule.c +0 -1
@@ -34,7 +34,6 @@#include <xen/multicall.h> #include <xen/cpu.h> #include <xen/preempt.h> -#include <xen/event.h> #include <public/sched.h> #include <xsm/xsm.h>
xen/drivers/cpufreq/cpufreq_ondemand.c +0 -1
@@ -15,7 +15,6 @@#include <xen/types.h> #include <xen/percpu.h> #include <xen/cpumask.h> -#include <xen/types.h> #include <xen/sched.h> #include <xen/timer.h> #include <acpi/cpufreq/cpufreq.h>
xen/drivers/cpufreq/utility.c +0 -1
@@ -24,7 +24,6 @@#include <xen/types.h> #include <xen/spinlock.h> #include <xen/percpu.h> -#include <xen/types.h> #include <xen/sched.h> #include <xen/timer.h> #include <xen/trace.h>
xen/drivers/passthrough/vtd/iommu.c +0 -1
@@ -31,7 +31,6 @@#include <xen/pci.h> #include <xen/pci_regs.h> #include <xen/keyhandler.h> -#include <xen/softirq.h> #include <asm/msi.h> #include <asm/irq.h> #include <asm/hvm/vmx/vmx.h>
xen/include/asm-x86/hvm/vpt.h +0 -1
@@ -25,7 +25,6 @@#include <xen/lib.h> #include <xen/time.h> #include <xen/errno.h> -#include <xen/time.h> #include <xen/timer.h> #include <xen/list.h> #include <asm/hvm/vpic.h>
Signature · 1 line
1.7.10.4
Quoted 1 line · Matthew Daley
Signed-off-by Matthew Daley <[email protected]>
Is this actually causing any problems at the moment?
Although it's pretty unlikely, there is a very small chance that this could cause a build breakage somewhere down the line; so if the "cost" of the redundant includes is just a few extra lines and a few extra file opens during compile, I'm inclined to say this should wait until 4.5.
-George
Quoted 6 lines · George Dunlap
Quoted 2 lines · Matthew Daley
Signed-off-by Matthew Daley <[email protected]>Is this actually causing any problems at the moment?
No, it's just cleanup.
Quoted 5 lines
Although it's pretty unlikely, there is a very small chance that this could cause a build breakage somewhere down the line; so if the "cost" of the redundant includes is just a few extra lines and a few extra file opens during compile, I'm inclined to say this should wait until 4.5.
I agree that it can wait until 4.5; I'll repost it then. Thanks!
- Matthew
Quoted 5 lines · Matthew Daley
Signed-off-by Matthew Daley <[email protected]>---
Build-tested.xen/arch/arm/time.c | 1 -
This bit:
xen/arch/arm/time.c line 32
Quoted 12 lines
xen/arch/arm/time.c +0
-1@@ -27,7 +27,6 @@#include <xen/softirq.h> #include <xen/sched.h> #include <xen/time.h> -#include <xen/sched.h> #include <xen/event.h> #include <asm/system.h> #include <asm/time.h>
Ian.