Skip to contentSkip to conversation

pinctrl: tegra: Add pincontrol driver for Tegra124 SoC

PATCH Applied Laxman Dewangan 7 participants 23 messages Dec 5, 2013 – Dec 12, 2013 5 messages not in the archive

Subsystems (5)

v1 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover pinctrl: tegra: Add pincontrol driver for Tegra124 SoC

Add pincontrol driver for NVIDIA's Tegra124 SoCs.
This series add pincontrol driver which contains the pinmux tables for tegra124, pincontrol dt binding doc, dtsi file change for adding pinmux node, selecting pincontrol config for Tegra124.

Ashwini Ghuge (1):
pinctrl: tegra: add pinmux controller driver for Tegra124

Laxman Dewangan (3):
pinctrl: tegra: Add devicetree binding document for Tegra124
ARM: tegra: add pinmux controller to tegra124.dtsi
ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC

 .../bindings/pinctrl/nvidia,tegra124-pinmux.txt    |  137 +
 arch/arm/boot/dts/tegra124.dtsi                    |    6 +
 arch/arm/mach-tegra/Kconfig                        |    1 +
 drivers/pinctrl/Kconfig                            |    4 +
 drivers/pinctrl/Makefile                           |    1 +
 drivers/pinctrl/pinctrl-tegra124.c                 | 3147 ++++++++++++++++++++
 6 files changed, 3296 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.txt
 create mode 100644 drivers/pinctrl/pinctrl-tegra124.c
#1 lore raw

PATCH 1/4 pinctrl: tegra: Add devicetree binding document for Tegra124

This device tree binding document describes the Tegra124 pincontrol DT bindings. This document lists all valid properties, names, mux options of Tegra124 pins.

---
 .../bindings/pinctrl/nvidia,tegra124-pinmux.txt    |  137 ++++++++++++++++++++
 1 files changed, 137 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.txt
Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-pinmux.txt new file +137 -0
new file mode 100644
index 0000000..016dad6
@@ -0,0 +1,137 @@
+NVIDIA Tegra124 pinmux controller
+
+The Tegra124 pinctrl binding is very similar to the Tegra20 and Tegra30
+pinctrl binding, as described in nvidia,tegra20-pinmux.txt and
+nvidia,tegra30-pinmux.txt. In fact, this document assumes that binding as
+a baseline, and only documents the differences between the two bindings.
+
+Required properties:
+- compatible: "nvidia,tegra124-pinmux"
+- reg: Should contain the register physical address and length for each of
+  the pad control and mux registers. The first bank of address must be the
+  driver strength pad control register address and second bank address must
+  be pinmux register address.
+
+Tegra124 adds the following optional properties for pin configuration subnodes:
+- nvidia,enable-input: Integer. Enable the pin's input path. 0: no, 1: yes.
+- nvidia,open-drain: Integer. Enable open drain mode. 0: no, 1: yes.
+- nvidia,lock: Integer. Lock the pin configuration against further changes
+    until reset. 0: no, 1: yes.
+- nvidia,io-reset: Integer. Reset the IO path. 0: no, 1: yes.
+- nvidia,rcv-sel: Integer. Select VIL/VIH receivers. 0: normal, 1: high.
+- nvidia,drive-type: Integer. Valid range 0...3.
+
+The macros for options are defined in the
+include/dt-binding/pinctrl/pinctrl-tegra.h.
+
+Please refer the Tegra TRM for complete details regarding which groups
+support which functionality.
+
+Valid values for pin and group names are:
+
+  per-pin mux groups:
+
+    These all support nvidia,function, nvidia,tristate, nvidia,pull,
+    nvidia,enable-input. Some support nvidia,lock nvidia,open-drain,
+    nvidia,io-reset and nvidia,rcv-sel.
+
+	ulpi_data0_po1, ulpi_data1_po2, ulpi_data2_po3, ulpi_data3_po4,
+	ulpi_data4_po5, ulpi_data5_po6, ulpi_data6_po7, ulpi_data7_po0,
+	ulpi_clk_py0, ulpi_dir_py1, ulpi_nxt_py2, ulpi_stp_py3, dap3_fs_pp0,
+	dap3_din_pp1, dap3_dout_pp2, dap3_sclk_pp3, pv0, pv1, sdmmc1_clk_pz0,
+	sdmmc1_cmd_pz1, sdmmc1_dat3_py4, sdmmc1_dat2_py5, sdmmc1_dat1_py6,
+	sdmmc1_dat0_py7, clk2_out_pw5, clk2_req_pcc5, hdmi_int_pn7, ddc_scl_pv4,
+	ddc_sda_pv5, uart2_rxd_pc3, uart2_txd_pc2, uart2_rts_n_pj6,
+	uart2_cts_n_pj5, uart3_txd_pw6, uart3_rxd_pw7, uart3_cts_n_pa1,
+	uart3_rts_n_pc0, pu0, pu1, pu2, pu3, pu4, pu5, pu6, gen1_i2c_scl_pc4,
+	gen1_i2c_sda_pc5, dap4_fs_pp4, dap4_din_pp5, dap4_dout_pp6,
+	dap4_sclk_pp7, clk3_out_pee0, clk3_req_pee1, pc7, pi5, pi7, pk0, pk1,
+	pj0, pj2, pk3, pk4, pk2, pi3, pi6, pg0, pg1, pg2, pg3, pg4, pg5, pg6,
+	pg7, ph0, ph1, ph2, ph3, ph4, ph5, ph6, ph7, pj7, pb0, pb1, pk7, pi0,
+	pi1, pi2, pi4, gen2_i2c_scl_pt5, gen2_i2c_sda_pt6, sdmmc4_clk_pcc4,
+	sdmmc4_cmd_pt7, sdmmc4_dat0_paa0, sdmmc4_dat1_paa1, sdmmc4_dat2_paa2,
+	sdmmc4_dat3_paa3, sdmmc4_dat4_paa4, sdmmc4_dat5_paa5, sdmmc4_dat6_paa6,
+	sdmmc4_dat7_paa7, cam_mclk_pcc0, pcc1, pbb0, cam_i2c_scl_pbb1,
+	cam_i2c_sda_pbb2, pbb3, pbb4, pbb5, pbb6, pbb7, pcc2, jtag_rtck,
+	pwr_i2c_scl_pz6, pwr_i2c_sda_pz7, kb_row0_pr0, kb_row1_pr1, kb_row2_pr2,
+	kb_row3_pr3, kb_row4_pr4, kb_row5_pr5, kb_row6_pr6, kb_row7_pr7,
+	kb_row8_ps0, kb_row9_ps1, kb_row10_ps2, kb_row11_ps3, kb_row12_ps4,
+	kb_row13_ps5, kb_row14_ps6, kb_row15_ps7, kb_col0_pq0, kb_col1_pq1,
+	kb_col2_pq2, kb_col3_pq3, kb_col4_pq4, kb_col5_pq5, kb_col6_pq6,
+	kb_col7_pq7, clk_32k_out_pa0, core_pwr_req, cpu_pwr_req, pwr_int_n,
+	clk_32k_in, owr, dap1_fs_pn0, dap1_din_pn1, dap1_dout_pn2,
+	dap1_sclk_pn3, dap_mclk1_req_pee2, dap_mclk1_pw4, spdif_in_pk6,
+	spdif_out_pk5, dap2_fs_pa2, dap2_din_pa4, dap2_dout_pa5, dap2_sclk_pa3,
+	dvfs_pwm_px0, gpio_x1_aud_px1, gpio_x3_aud_px3, dvfs_clk_px2,
+	gpio_x4_aud_px4, gpio_x5_aud_px5, gpio_x6_aud_px6, gpio_x7_aud_px7,
+	sdmmc3_clk_pa6, sdmmc3_cmd_pa7, sdmmc3_dat0_pb7, sdmmc3_dat1_pb6,
+	sdmmc3_dat2_pb5, sdmmc3_dat3_pb4, pex_l0_rst_n_pdd1,
+	pex_l0_clkreq_n_pdd2, pex_wake_n_pdd3, pex_l1_rst_n_pdd5,
+	pex_l1_clkreq_n_pdd6, hdmi_cec_pee3, sdmmc1_wp_n_pv3,
+	sdmmc3_cd_n_pv2, gpio_w2_aud_pw2, gpio_w3_aud_pw3, usb_vbus_en0_pn4,
+	usb_vbus_en1_pn5, sdmmc3_clk_lb_out_pee4, sdmmc3_clk_lb_in_pee5,
+	gmi_clk_lb, reset_out_n, kb_row16_pt0, kb_row17_pt1, usb_vbus_en2_pff1,
+	pff2, dp_hpd_pff0,
+
+  drive groups:
+
+    These all support nvidia,pull-down-strength, nvidia,pull-up-strength,
+    nvidia,slew-rate-rising, nvidia,slew-rate-falling. Most but not all
+    support nvidia,high-speed-mode, nvidia,schmitt, nvidia,low-power-mode
+    and nvidia,drive-type.
+
+    ao1, ao2, at1, at2, at3, at4, at5, cdev1, cdev2, dap1, dap2, dap3, dap4,
+    dbg, sdio3, spi, uaa, uab, uart2, uart3, sdio1, ddc, gma, gme, gmf, gmg,
+    gmh, owr, uda, gpv, dev3, cec, usb_vbus_en, ao3, ao0, hv0, sdio4, ao4.
+
+Valid values for nvidia,functions are:
+
+  blink, cec, cldvfs, clk12, cpu, dap, dap1, dap2, dev3, displaya,
+  displaya_alt, displayb, dtv, extperiph1, extperiph2, extperiph3,
+  gmi, gmi_alt, hda, hsi, i2c1, i2c2, i2c3, i2c4, i2cpwr, i2s0,
+  i2s1, i2s2, i2s3, i2s4, irda, kbc, owr, pmi, pwm0, pwm1, pwm2, pwm3,
+  pwron, reset_out_n, rsvd1, rsvd2, rsvd3, rsvd4, sdmmc1, sdmmc2, sdmmc3,
+  sdmmc4, soc, spdif, spi1, spi2, spi3, spi4, spi5, spi6, trace, uarta,
+  uartb, uartc, uartd, ulpi, usb, vgp1, vgp2, vgp3, vgp4, vgp5, vgp6,
+  vi, vi_alt1, vi_alt3, vimclk2, vimclk2_alt, sata, ccla, pe0, pe, pe1,
+  dp, rtck, sys, clk tmds.
+
+Example:
+
+	pinmux: pinmux {
+		compatible = "nvidia,tegra124-pinmux";
+		reg = <0x70000868 0x164		/* Pad control registers */
+		       0x70003000 0x434>;	/* PinMux registers */
+	};
+
+Example pinmux entries:
+
+	pinctrl {
+		sdmmc4_default: pinmux {
+			sdmmc4_clk_pcc4 {
+				nvidia,pins = "sdmmc4_clk_pcc4",
+				nvidia,function = "sdmmc4";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+			};
+
+			sdmmc4_dat0_paa0 {
+				nvidia,pins = "sdmmc4_dat0_paa0",
+						"sdmmc4_dat1_paa1",
+						"sdmmc4_dat2_paa2",
+						"sdmmc4_dat3_paa3",
+						"sdmmc4_dat4_paa4",
+						"sdmmc4_dat5_paa5",
+						"sdmmc4_dat6_paa6",
+						"sdmmc4_dat7_paa7";
+				nvidia,function = "sdmmc4";
+				nvidia,pull = <TEGRA_PIN_PULL_UP>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+			};
+		};
+	};
+
+	sdhci at 78000400 {
+		pinctrl-names = "default";
+		pinctrl-0 = <&sdmmc4_default>;
+	};
Signature · 1 line
1.7.1.1
#2 lore raw

Re: [PATCH 1/4] pinctrl: tegra: Add devicetree binding document for Tegra124

Quoted 3 lines · Laxman Dewangan

This device tree binding document describes the Tegra124 pincontrol DT bindings. This document lists all valid properties, names, mux options of Tegra124 pins.

Is this a repost of what Ashwini sent a few weeks back, or V2? If V2, it'd be useful to know what changed...

#3 lore raw

Re: [PATCH 1/4] pinctrl: tegra: Add devicetree binding document for Tegra124

Quoted 6 lines · Stephen Warren
Quoted 3 lines · Laxman Dewangan

This device tree binding document describes the Tegra124 pincontrol DT bindings. This document lists all valid properties, names, mux options of Tegra124 pins.

Is this a repost of what Ashwini sent a few weeks back, or V2? If V2, it'd be useful to know what changed...

I am not aware that Ashwini already sent back. I did not get chance to talk to her on this. I was thinking that it is still in internal review.

Anyhow, I compare the downstream to your linux-next-common and found some diff. Something fixed in your tree which need downstream and something fixed in downstream which need to upstream. :)

One diff is
Mux enums are:

TEGRA_MUX_SATA,
TEGRA_MUX_CCLA,
TEGRA_MUX_PE0,
TEGRA_MUX_PE,
TEGRA_MUX_PE1,
TEGRA_MUX_DP,
TEGRA_MUX_RTCK,
TEGRA_MUX_SYS,
TEGRA_MUX_CLK,
TEGRA_MUX_TMDS,
};

Functions definitions are:

FUNCTION(sata),
FUNCTION(ccla),
FUNCTION(rtck),
FUNCTION(pe0),
FUNCTION(pe),
FUNCTION(pe1),
FUNCTION(dp),

I think I will post the patch to fix this issue.

#4 lore raw

PATCH 2/4 ARM: tegra: add pinmux controller to tegra124.dtsi

In reply to Laxman Dewangan

The tegra124 pinmux controller is identical to tegra114 with removing some of existing pins from T114 and adding new pins.

---
 arch/arm/boot/dts/tegra124.dtsi |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
arch/arm/boot/dts/tegra124.dtsi +6 -0
index b741300..39bfcce 100644
@@ -47,6 +47,12 @@
 		interrupt-controller;
 	};
 
+	pinmux: pinmux {
+		compatible = "nvidia,tegra124-pinmux";
+		reg = <0x70000868 0x164		/* Pad control registers */
+		       0x70003000 0x434>;	/* PinMux registers */
+	};
+
 	/*
 	 * There are two serial driver i.e. 8250 based simple serial
 	 * driver and APB DMA based serial driver for higher baudrate
Signature · 1 line
1.7.1.1
#5 lore raw

Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi

Quoted 2 lines · Laxman Dewangan

The tegra124 pinmux controller is identical to tegra114 with removing some of existing pins from T114 and adding new pins.

I already sent this patch.

arch/arm/boot/dts/tegra124.dtsi line 50

Quoted 3 lines
arch/arm/boot/dts/tegra124.dtsi +1 -0
 
+	pinmux: pinmux {

Note that the rules for DT node naming have changed recently. Node name must include a unit address if the node includes a reg property, and not include a unit address otherwise. So, that should be:

+ pinmux: pinmux at 70000868 {

The patch I sent already does that.

#6 lore raw

Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi

Quoted 5 lines · Stephen Warren
Quoted 2 lines · Laxman Dewangan

The tegra124 pinmux controller is identical to tegra114 with removing some of existing pins from T114 and adding new pins.

I already sent this patch.

Oh, I do notice one difference between the two patches:

Mine:

Review

Quoted 2 lines
(quoted diff) +2 -0
+		reg = <0x70000868 0x148>,	/* Pad control registers */
+		      <0x70003000 0x40c>;	/* Mux registers */

Yours:

arch/arm/boot/dts/tegra124.dtsi line 53

Quoted 2 lines
arch/arm/boot/dts/tegra124.dtsi +2 -0
+		reg = <0x70000868 0x164		/* Pad control registers */
+		       0x70003000 0x434>;	/* PinMux registers */

Are the increase register lengths in your patch correct? If so, I guess I'll drop my patch and replace it with yours if you fix up the unit address.

#7 lore raw

Re: [PATCH 2/4] ARM: tegra: add pinmux controller to tegra124.dtsi

Quoted 9 lines · Stephen Warren
Quoted 4 lines · Stephen Warren
Quoted 2 lines · Laxman Dewangan

The tegra124 pinmux controller is identical to tegra114 with removing some of existing pins from T114 and adding new pins.

I already sent this patch.

Oh, I do notice one difference between the two patches:

Mine:

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+		reg = <0x70000868 0x148>,	/* Pad control registers */
+		      <0x70003000 0x40c>;	/* Mux registers */

Yours:

arch/arm/boot/dts/tegra124.dtsi line 53

Quoted 2 lines
arch/arm/boot/dts/tegra124.dtsi +2 -0
+		reg = <0x70000868 0x164		/* Pad control registers */
+		       0x70003000 0x434>;	/* PinMux registers */

Are the increase register lengths in your patch correct? If so, I guess I'll drop my patch and replace it with yours if you fix up the unit address.

Yes, the last entry of the bank 0 and 1 are:
DRV_PINGROUP(ao4, 0x9c8, 2, 3, 4, 12, 7, 20, 7, 28, 2, 30,
2, Y),
and
PINGROUP(dp_hpd_pff0, DP, RSVD2, RSVD3,
RSVD4, DP, 0x3430, N, N, N),

#8 lore raw

PATCH 3/4 ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC

In reply to Laxman Dewangan

The pincontrol driver for Tegra124 is build through config PINCTRL_TEGRA124. Select this config option whenever Tegra124 SoC is enabled.

---
 arch/arm/mach-tegra/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-tegra/Kconfig +1 -0
index 09e740f..807e7bc 100644
@@ -63,6 +63,7 @@ config ARCH_TEGRA_124_SOC
 	bool "Enable support for Tegra124 family"
 	select ARM_L1_CACHE_SHIFT_6
 	select HAVE_ARM_ARCH_TIMER
+	select PINCTRL_TEGRA124
 	help
 	  Support for NVIDIA Tegra T124 processor family, based on the
 	  ARM CortexA15MP CPU
Signature · 1 line
1.7.1.1
#9 lore raw

Re: [PATCH 3/4] ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC

Quoted 3 lines · Laxman Dewangan

The pincontrol driver for Tegra124 is build through config PINCTRL_TEGRA124. Select this config option whenever Tegra124 SoC is enabled.

I already sent this patch too.

#10 lore raw

Re: [PATCH 3/4] ARM: tegra: select PINCTRL_TEGRA124 for Tegra124 SoC

In reply to Laxman Dewangan
Quoted 3 lines · Laxman Dewangan

The pincontrol driver for Tegra124 is build through config PINCTRL_TEGRA124. Select this config option whenever Tegra124 SoC is enabled.

Applied to Tegra's for-3.14/soc branch.

(I thought I had sent this before myself, but I'd only written the patch locally, and had not actually sent it out, hence I took your identical patch.)

#11 lore raw

PATCH 4/4 pinctrl: tegra: add pinmux controller driver for Tegra124

In reply to Laxman Dewangan

From: Ashwini Ghuge <[email protected]>

This adds a driver for the Tegra124 pinmux, and required parameterization data for Tegra124.

The driver uses the common Tegra pincontrol driver utility functions to implement the majority of the driver.

This driver is not compatible with the earlier NVIDIA's SoCs, hence add new compatibile as "nvidia,tegra124-pinmux".

Originally written by Ashwini Gguhe.
ldewangan:
- cleanup the patches,
- Fix address issue.

---
 drivers/pinctrl/Kconfig            |    4 +
 drivers/pinctrl/Makefile           |    1 +
 drivers/pinctrl/pinctrl-tegra124.c | 3147 ++++++++++++++++++++++++++++++++++++
 3 files changed, 3152 insertions(+), 0 deletions(-)
 create mode 100644 drivers/pinctrl/pinctrl-tegra124.c
drivers/pinctrl/Kconfig +4 -0
index 5e4418f..fe50557 100644
@@ -269,6 +269,10 @@ config PINCTRL_TEGRA114
 	bool
 	select PINCTRL_TEGRA
 
+config PINCTRL_TEGRA124
+	bool
+	select PINCTRL_TEGRA
+
 config PINCTRL_TZ1090
 	bool "Toumaz Xenif TZ1090 pin control driver"
 	depends on SOC_TZ1090
drivers/pinctrl/Makefile +1 -0
index dcb01a4..d7ae9b1 100644
@@ -49,6 +49,7 @@ obj-$(CONFIG_PINCTRL_TEGRA)	+= pinctrl-tegra.o
 obj-$(CONFIG_PINCTRL_TEGRA20)	+= pinctrl-tegra20.o
 obj-$(CONFIG_PINCTRL_TEGRA30)	+= pinctrl-tegra30.o
 obj-$(CONFIG_PINCTRL_TEGRA114)	+= pinctrl-tegra114.o
+obj-$(CONFIG_PINCTRL_TEGRA124)	+= pinctrl-tegra124.o
 obj-$(CONFIG_PINCTRL_TZ1090)	+= pinctrl-tz1090.o
 obj-$(CONFIG_PINCTRL_TZ1090_PDC)	+= pinctrl-tz1090-pdc.o
 obj-$(CONFIG_PINCTRL_U300)	+= pinctrl-u300.o
drivers/pinctrl/pinctrl-tegra124.c new file +3147 -0

2,983 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
1.7.1.1

Part of the diff is not shown here. View the raw message.

Acked-by on v1 4/4
#12 lore raw

Re: [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124

Quoted 8 lines · Laxman Dewangan

From: Ashwini Ghuge <[email protected]>

This adds a driver for the Tegra124 pinmux, and required parameterization data for Tegra124.

The driver uses the common Tegra pincontrol driver utility functions to implement the majority of the driver.

Quoted 7 lines

This driver is not compatible with the earlier NVIDIA's SoCs, hence add new compatibile as "nvidia,tegra124-pinmux".

Originally written by Ashwini Gguhe.
ldewangan:
- cleanup the patches,
- Fix address issue.

IIRC, Thierry mentioned he had some fixes in his local branch for this driver. Thierry, can you please confirm/deny this?

I made the following comment on the version Ashwini posted, which hasn't been addressed yet:

A day or two ago during upstream review:

Quoted 10 lines
Quoted 1 line

+static const struct tegra_function tegra124_functions[] = {

...

drivers/pinctrl/pinctrl-tegra124.c line 2728

Quoted 5 lines
drivers/pinctrl/pinctrl-tegra124.c new file +5 -0
+	FUNCTION(i2c1),
+	FUNCTION(i2c2),
+	FUNCTION(i2c3),
+	FUNCTION(i2c4),
+	FUNCTION(i2cpwr),

Is that complete? Tegra124 apparently has 6 I2C controllers. Are the pins for the new sixth controller (0x7000d100) not affected by the pinmux?

That said, if we find things are missing, I suppose we can add them later without breaking existing ABI. Breakage would only happen if we had to change/remove something.

Quoted 4 lines · During downstream review quite a while ago I also
Quoted 4 lines
Quoted 1 line

+static const struct pinctrl_pin_desc tegra124_pins[] = {

There are two spaces before "tegra124_pins[]".

Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
drivers/pinctrl/pinctrl-tegra124.c new file +4 -0
+static const char * const gmi_groups[] = {
+	"uart2_cts_n_pj5",
+	"uart2_rts_n_pj6",
+	"uart3_txd_pw6",
Quoted 8 lines

drivers/pinctrl/pinctrl-tegra124.c line 1705

Quoted 5 lines
drivers/pinctrl/pinctrl-tegra124.c new file +5 -0
+	"uart3_rxd_pw7",
+	"uart3_cts_n_pa1",
+	"uart3_rts_n_pc0",
+
+	"pu0",

It'd be best not to have blank lines in the middle of arrays. The same comment exists elsewhere in the file, so make sure you search the whole file.

Nits:

- There are some cases of multiple blank lines back-to-back.
- There's a blank line at the end of the file.

Aside from those minor issues, patches 1/4 and 4/4,

(BTW, those 2 patches would go through the pinctrl tree, and patches 2/4 and 3/4 would go through the Tegra tree. You generally shouldn't posted patches that will be applied to different trees in the same series, since there aren't dependencies).

#13 lore raw

Re: [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124

Quoted 16 lines · Stephen Warren
Quoted 8 lines · Laxman Dewangan

From: Ashwini Ghuge <[email protected]>

This adds a driver for the Tegra124 pinmux, and required parameterization data for Tegra124.

The driver uses the common Tegra pincontrol driver utility functions to implement the majority of the driver.

Quoted 7 lines

This driver is not compatible with the earlier NVIDIA's SoCs, hence add new compatibile as "nvidia,tegra124-pinmux".

Originally written by Ashwini Gguhe.
ldewangan:
- cleanup the patches,
- Fix address issue.

Quoted 7 lines

IIRC, Thierry mentioned he had some fixes in his local branch for this driver. Thierry, can you please confirm/deny this?

I made the following comment on the version Ashwini posted, which hasn't been addressed yet:

A day or two ago during upstream review:

Yes, we have some missing entry and I responded into other mail thread. I will post the diff here to complete.

Quoted 9 lines
Quoted 9 lines
Quoted 1 line

+static const struct tegra_function tegra124_functions[] = {

...

drivers/pinctrl/pinctrl-tegra124.c line 2728

Quoted 5 lines
drivers/pinctrl/pinctrl-tegra124.c new file +5 -0
+	FUNCTION(i2c1),
+	FUNCTION(i2c2),
+	FUNCTION(i2c3),
+	FUNCTION(i2c4),
+	FUNCTION(i2cpwr),

Is that complete? Tegra124 apparently has 6 I2C controllers. Are the pins for the new sixth controller (0x7000d100) not affected by the pinmux?

Quoted 5 lines

That said, if we find things are missing, I suppose we can add them later without breaking existing ABI. Breakage would only happen if we had to change/remove something.

During downstream review quite a while ago I also said:

I2C6 pinmux is not in this controller, it is dpaux controller and we have not supported this. This require little bit different handling. I have already downstream bug for support this. Will add you in loop so that single fix can work for mainline and downstream.

Other than I2C6, some other mux are missing.

Quoted 19 lines
Quoted 14 lines
Quoted 14 lines
Quoted 1 line

+static const struct pinctrl_pin_desc tegra124_pins[] = {

There are two spaces before "tegra124_pins[]".

drivers/pinctrl/pinctrl-tegra124.c line 1705

Quoted 9 lines
drivers/pinctrl/pinctrl-tegra124.c new file +9 -0
+static const char * const gmi_groups[] = {
+	"uart2_cts_n_pj5",
+	"uart2_rts_n_pj6",
+	"uart3_txd_pw6",
+	"uart3_rxd_pw7",
+	"uart3_cts_n_pa1",
+	"uart3_rts_n_pc0",
+
+	"pu0",

It'd be best not to have blank lines in the middle of arrays. The same comment exists elsewhere in the file, so make sure you search the whole file.

Nits:

- There are some cases of multiple blank lines back-to-back.
- There's a blank line at the end of the file.

Quoted 7 lines

Aside from those minor issues, patches 1/4 and 4/4,

(BTW, those 2 patches would go through the pinctrl tree, and patches 2/4 and 3/4 would go through the Tegra tree. You generally shouldn't posted patches that will be applied to different trees in the same series, since there aren't dependencies).

Fine.
Should I sent the diff or full change? I think full change as this need to go on pincontrol subsystem, not in Tegra.

Thanks,
Laxman

#14 lore raw

Re: [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124

Quoted 17 lines · Laxman Dewangan
Quoted 16 lines · Stephen Warren
Quoted 15 lines · Laxman Dewangan

From: Ashwini Ghuge <[email protected]>

This adds a driver for the Tegra124 pinmux, and required parameterization data for Tegra124.

The driver uses the common Tegra pincontrol driver utility functions to implement the majority of the driver.

This driver is not compatible with the earlier NVIDIA's SoCs, hence add new compatibile as "nvidia,tegra124-pinmux".

Originally written by Ashwini Gguhe.
ldewangan:
- cleanup the patches,
- Fix address issue.

...

Quoted 8 lines
Quoted 4 lines

(BTW, those 2 patches would go through the pinctrl tree, and patches 2/4 and 3/4 would go through the Tegra tree. You generally shouldn't posted patches that will be applied to different trees in the same series, since there aren't dependencies).

Fine.
Should I sent the diff or full change? I think full change as this need to go on pincontrol subsystem, not in Tegra.

Please send complete patches for the new driver. The patch I have in my local tree isn't going anywhere; I just have the early version that Ashwini posted applied locally for testing. A final complete patch should be sent to the pinctrl maintainer in the normal way.

#15 lore raw

Re: [PATCH 4/4] pinctrl: tegra: add pinmux controller driver for Tegra124

In reply to Stephen Warren
Quoted 12 lines · Stephen Warren
Quoted 11 lines · Laxman Dewangan

From: Ashwini Ghuge <[email protected]>

This adds a driver for the Tegra124 pinmux, and required parameterization data for Tegra124.

The driver uses the common Tegra pincontrol driver utility functions to implement the majority of the driver.

This driver is not compatible with the earlier NVIDIA's SoCs, hence add new compatibile as "nvidia,tegra124-pinmux".

Quoted 7 lines
Quoted 4 lines

Originally written by Ashwini Gguhe.
ldewangan:
- cleanup the patches,
- Fix address issue.

IIRC, Thierry mentioned he had some fixes in his local branch for this driver. Thierry, can you please confirm/deny this?

I'll try to get this version tested today and report back if any changes are still required.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/6fec3a21/attachment.sig>

A message that is not in the archive (sent off-list or not yet received): [email protected]

#17 lore raw

PATCH 1/2 pinctrl: tegra: Various Tegra124 fixes

Remove various gratuitous blank lines and other minor whitespace and style cleanups. Add some missing commas within group arrays to prevent the compiler from concatenating the strings. Remove unneeded TEGRA_MUX_SAFE entry from enumeration and drop gratuitous _dt suffix from tegra_mux enumeration type name. Drop an unwarranted FIXME comment and rename gmi_ad8_ph0 pin to ph0 since that's how it's referenced in the DS06472001 datasheet.

---
 drivers/pinctrl/pinctrl-tegra124.c | 27 ++++++++-------------------
 1 file changed, 8 insertions(+), 19 deletions(-)
drivers/pinctrl/pinctrl-tegra124.c +8 -19
index 592fd6f079b6..632e076115d5 100644
@@ -211,7 +211,6 @@
 #define TEGRA_PIN_USB_VBUS_EN2_PFF1		_GPIO(249)
 #define TEGRA_PIN_PFF2				_GPIO(250)
 
-
 /* All non-GPIO pins follow */
 #define NUM_GPIOS	(TEGRA_PIN_PFF2 + 1)
 #define _PIN(offset)	(NUM_GPIOS + (offset))
@@ -1183,8 +1182,6 @@ static const unsigned jtag_rtck_pins[] = {
 	TEGRA_PIN_JTAG_RTCK,
 };
 
-
-/*FIXME */
 static const unsigned drive_ao1_pins[] = {
 	TEGRA_PIN_KB_ROW0_PR0,
 	TEGRA_PIN_KB_ROW1_PR1,
@@ -1242,7 +1239,7 @@ static const unsigned drive_at2_pins[] = {
 	TEGRA_PIN_PG6,
 	TEGRA_PIN_PG7,
 	TEGRA_PIN_PI0,
-	TEGRA_PIN_PI0,
+	TEGRA_PIN_PI1,
 	TEGRA_PIN_PI3,
 	TEGRA_PIN_PI4,
 	TEGRA_PIN_PI7,
@@ -1497,8 +1494,7 @@ static const unsigned drive_ao4_pins[] = {
 	TEGRA_PIN_JTAG_RTCK,
 };
 
-enum tegra_mux_dt {
-	TEGRA_MUX_SAFE,
+enum tegra_mux {
 	TEGRA_MUX_BLINK,
 	TEGRA_MUX_CEC,
 	TEGRA_MUX_CLDVFS,
@@ -1771,7 +1767,6 @@ static const char * const gmi_groups[] = {
 	"sdmmc4_clk_pcc4",
 	"sdmmc4_cmd_pt7",
 	"gmi_clk_lb",
-	"gpio_x6_aud_px6",
 
 	"dap1_fs_pn0",
 	"dap1_din_pn1",
@@ -1888,7 +1883,7 @@ static const char * const irda_groups[] = {
 	"uart2_rxd_pc3",
 	"uart2_txd_pc2",
 	"kb_row11_ps3",
-	"kb_row12_ps4"
+	"kb_row12_ps4",
 };
 
 static const char * const kbc_groups[] = {
@@ -1936,7 +1931,7 @@ static const char * const pwm0_groups[] = {
 	"sdmmc1_dat2_py5",
 	"uart3_rts_n_pc0",
 	"pu3",
-	"gmi_ad8_ph0",
+	"ph0",
 	"sdmmc3_dat3_pb4",
 };
 
@@ -2001,8 +1996,6 @@ static const char * const rsvd1_groups[] = {
 	"reset_out_n",
 };
 
-
-
 static const char * const rsvd2_groups[] = {
 	"pv0",
 	"pv1",
@@ -2194,7 +2187,7 @@ static const char * const rsvd4_groups[] = {
 	"dap3_dout_pp2",
 	"pv0",
 	"pv1",
-	"sdmmc1_clk_pz0"
+	"sdmmc1_clk_pz0",
 
 	"clk2_out_pw5",
 	"clk2_req_pcc5",
@@ -2305,7 +2298,7 @@ static const char * const rsvd4_groups[] = {
 	"usb_vbus_en1_pn5",
 	"sdmmc3_clk_lb_out_pee4",
 	"sdmmc3_clk_lb_in_pee5",
-	"gmi_clk_lb"
+	"gmi_clk_lb",
 
 	"dp_hpd_pff0",
 	"usb_vbus_en2_pff1",
@@ -2313,7 +2306,6 @@ static const char * const rsvd4_groups[] = {
 };
 
 static const char * const sdmmc1_groups[] = {
-
 	"sdmmc1_clk_pz0",
 	"sdmmc1_cmd_pz1",
 	"sdmmc1_dat3_py4",
@@ -2700,7 +2692,7 @@ static const char * const tmds_groups[] = {
 		.ngroups = ARRAY_SIZE(fname##_groups),	\
 	}
 
-static const struct tegra_function  tegra124_functions[] = {
+static const struct tegra_function tegra124_functions[] = {
 	FUNCTION(blink),
 	FUNCTION(cec),
 	FUNCTION(cldvfs),
@@ -3105,7 +3097,6 @@ static const struct tegra_pingroup tegra124_groups[] = {
 	DRV_PINGROUP(hv0,   0x9b4,  2,  3,  4,  12,  5,  -1,  -1,  28,  2,  -1,  -1,  N),
 	DRV_PINGROUP(sdio4, 0x9c4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
 	DRV_PINGROUP(ao4,   0x9c8,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-
 };
 
 static const struct tegra_pinctrl_soc_data tegra124_pinctrl = {
@@ -3127,6 +3118,7 @@ static struct of_device_id tegra124_pinctrl_of_match[] = {
 	{ .compatible = "nvidia,tegra124-pinmux", },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, tegra124_pinctrl_of_match);
 
 static struct platform_driver tegra124_pinctrl_driver = {
 	.driver = {
@@ -3137,11 +3129,8 @@ static struct platform_driver tegra124_pinctrl_driver = {
 	.probe = tegra124_pinctrl_probe,
 	.remove = tegra_pinctrl_remove,
 };
-
 module_platform_driver(tegra124_pinctrl_driver);
 
 MODULE_AUTHOR("Ashwini Ghuge <[email protected]>");
 MODULE_DESCRIPTION("NVIDIA Tegra124 pinctrl driver");
 MODULE_LICENSE("GPL v2");
-MODULE_DEVICE_TABLE(of, tegra124_pinctrl_of_match);
-
Signature · 1 line
1.8.4.2

A message that is not in the archive (sent off-list or not yet received): 1386330839-30559-1-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#19 lore raw

PATCH 2/2 pinctrl: tegra: Whitespace fixes for Tegra124

This removes some inconsistencies in the formatting of tables and macros and makes the code match that of the Tegra114 driver more closely.

---
 drivers/pinctrl/pinctrl-tegra124.c | 604 ++++++++++++++++++-------------------
 1 file changed, 302 insertions(+), 302 deletions(-)
drivers/pinctrl/pinctrl-tegra124.c +302 -302
index 632e076115d5..ee35d8895b0d 100644
@@ -2782,321 +2782,321 @@ static const struct tegra_function tegra124_functions[] = {
 #define DRV_PINGROUP_REG_A	0x868	/* bank 0 */
 #define PINGROUP_REG_A		0x3000	/* bank 1 */
 
-#define PINGROUP_REG_Y(r) ((r) - PINGROUP_REG_A)
-#define PINGROUP_REG_N(r) -1
+#define PINGROUP_REG_Y(r)	((r) - PINGROUP_REG_A)
+#define PINGROUP_REG_N(r)	-1
 
 #define PINGROUP(pg_name, f0, f1, f2, f3, f_safe, r, od, ior, rcv_sel)	\
-	{							\
-		.name = #pg_name,				\
-		.pins = pg_name##_pins,				\
-		.npins = ARRAY_SIZE(pg_name##_pins),		\
-		.funcs = {					\
-			TEGRA_MUX_ ## f0,			\
-			TEGRA_MUX_ ## f1,			\
-			TEGRA_MUX_ ## f2,			\
-			TEGRA_MUX_ ## f3,			\
-		},						\
-		.func_safe = TEGRA_MUX_ ## f_safe,		\
-		.mux_reg = PINGROUP_REG_Y(r),			\
-		.mux_bank = 1,					\
-		.mux_bit = 0,					\
-		.pupd_reg = PINGROUP_REG_Y(r),			\
-		.pupd_bank = 1,					\
-		.pupd_bit = 2,					\
-		.tri_reg = PINGROUP_REG_Y(r),			\
-		.tri_bank = 1,					\
-		.tri_bit = 4,					\
-		.einput_reg = PINGROUP_REG_Y(r),		\
-		.einput_bank = 1,				\
-		.einput_bit = 5,				\
-		.odrain_reg = PINGROUP_REG_##od(r),		\
-		.odrain_bank = 1,				\
-		.odrain_bit = 6,				\
-		.lock_reg = PINGROUP_REG_Y(r),			\
-		.lock_bank = 1,					\
-		.lock_bit = 7,					\
-		.ioreset_reg = PINGROUP_REG_##ior(r),		\
-		.ioreset_bank = 1,				\
-		.ioreset_bit = 8,				\
-		.rcv_sel_reg = PINGROUP_REG_##rcv_sel(r),	\
-		.rcv_sel_bank = 1,				\
-		.rcv_sel_bit = 9,				\
-		.drv_reg = -1,					\
-		.drvtype_reg = -1,				\
+	{								\
+		.name = #pg_name,					\
+		.pins = pg_name##_pins,					\
+		.npins = ARRAY_SIZE(pg_name##_pins),			\
+		.funcs = {						\
+			TEGRA_MUX_ ## f0,				\
+			TEGRA_MUX_ ## f1,				\
+			TEGRA_MUX_ ## f2,				\
+			TEGRA_MUX_ ## f3,				\
+		},							\
+		.func_safe = TEGRA_MUX_ ## f_safe,			\
+		.mux_reg = PINGROUP_REG_Y(r),				\
+		.mux_bank = 1,						\
+		.mux_bit = 0,						\
+		.pupd_reg = PINGROUP_REG_Y(r),				\
+		.pupd_bank = 1,						\
+		.pupd_bit = 2,						\
+		.tri_reg = PINGROUP_REG_Y(r),				\
+		.tri_bank = 1,						\
+		.tri_bit = 4,						\
+		.einput_reg = PINGROUP_REG_Y(r),			\
+		.einput_bank = 1,					\
+		.einput_bit = 5,					\
+		.odrain_reg = PINGROUP_REG_##od(r),			\
+		.odrain_bank = 1,					\
+		.odrain_bit = 6,					\
+		.lock_reg = PINGROUP_REG_Y(r),				\
+		.lock_bank = 1,						\
+		.lock_bit = 7,						\
+		.ioreset_reg = PINGROUP_REG_##ior(r),			\
+		.ioreset_bank = 1,					\
+		.ioreset_bit = 8,					\
+		.rcv_sel_reg = PINGROUP_REG_##rcv_sel(r),		\
+		.rcv_sel_bank = 1,					\
+		.rcv_sel_bit = 9,					\
+		.drv_reg = -1,						\
+		.drvtype_reg = -1,					\
 	}
 
 #define DRV_PINGROUP_DVRTYPE_Y(r) ((r) - DRV_PINGROUP_REG_A)
 #define DRV_PINGROUP_DVRTYPE_N(r) -1
 
-#define DRV_PINGROUP(pg_name, r, hsm_b, schmitt_b, lpmd_b,	\
-		     drvdn_b, drvdn_w, drvup_b, drvup_w,	\
-		     slwr_b, slwr_w, slwf_b, slwf_w,		\
-		     drvtype)					\
-	{							\
-		.name = "drive_" #pg_name,			\
-		.pins = drive_##pg_name##_pins,			\
-		.npins = ARRAY_SIZE(drive_##pg_name##_pins),	\
-		.mux_reg = -1,					\
-		.pupd_reg = -1,					\
-		.tri_reg = -1,					\
-		.einput_reg = -1,				\
-		.odrain_reg = -1,				\
-		.lock_reg = -1,					\
-		.ioreset_reg = -1,				\
-		.rcv_sel_reg = -1,				\
-		.drv_reg = DRV_PINGROUP_DVRTYPE_Y(r),		\
-		.drv_bank = 0,					\
-		.hsm_bit = hsm_b,				\
-		.schmitt_bit = schmitt_b,			\
-		.lpmd_bit = lpmd_b,				\
-		.drvdn_bit = drvdn_b,				\
-		.drvdn_width = drvdn_w,				\
-		.drvup_bit = drvup_b,				\
-		.drvup_width = drvup_w,				\
-		.slwr_bit = slwr_b,				\
-		.slwr_width = slwr_w,				\
-		.slwf_bit = slwf_b,				\
-		.slwf_width = slwf_w,				\
+#define DRV_PINGROUP(pg_name, r, hsm_b, schmitt_b, lpmd_b,		\
+		     drvdn_b, drvdn_w, drvup_b, drvup_w,		\
+		     slwr_b, slwr_w, slwf_b, slwf_w,			\
+		     drvtype)						\
+	{								\
+		.name = "drive_" #pg_name,				\
+		.pins = drive_##pg_name##_pins,				\
+		.npins = ARRAY_SIZE(drive_##pg_name##_pins),		\
+		.mux_reg = -1,						\
+		.pupd_reg = -1,						\
+		.tri_reg = -1,						\
+		.einput_reg = -1,					\
+		.odrain_reg = -1,					\
+		.lock_reg = -1,						\
+		.ioreset_reg = -1,					\
+		.rcv_sel_reg = -1,					\
+		.drv_reg = DRV_PINGROUP_DVRTYPE_Y(r),			\
+		.drv_bank = 0,						\
+		.hsm_bit = hsm_b,					\
+		.schmitt_bit = schmitt_b,				\
+		.lpmd_bit = lpmd_b,					\
+		.drvdn_bit = drvdn_b,					\
+		.drvdn_width = drvdn_w,					\
+		.drvup_bit = drvup_b,					\
+		.drvup_width = drvup_w,					\
+		.slwr_bit = slwr_b,					\
+		.slwr_width = slwr_w,					\
+		.slwf_bit = slwf_b,					\
+		.slwf_width = slwf_w,					\
 		.drvtype_reg = DRV_PINGROUP_DVRTYPE_##drvtype(r),	\
-		.drvtype_bank = 0,				\
-		.drvtype_bit = 6,				\
+		.drvtype_bank = 0,					\
+		.drvtype_bit = 6,					\
 	}
 
 static const struct tegra_pingroup tegra124_groups[] = {
-	/*       pg_name,                f0,         f1,         f2,           f3,          safe,     r,      od, ior, rcv_sel */
-	PINGROUP(ulpi_data0_po1,	SPI3,		HSI,		UARTA,		ULPI,		SPI3,		0x3000,  N,  N,  N),
-	PINGROUP(ulpi_data1_po2,	SPI3,		HSI,		UARTA,		ULPI,		SPI3,		0x3004,  N,  N,  N),
-	PINGROUP(ulpi_data2_po3,	SPI3,		HSI,		UARTA,		ULPI,		SPI3,		0x3008,  N,  N,  N),
-	PINGROUP(ulpi_data3_po4,	SPI3,		HSI,		UARTA,		ULPI,		SPI3,		0x300c,  N,  N,  N),
-	PINGROUP(ulpi_data4_po5,	SPI2,		HSI,		UARTA,		ULPI,		SPI2,		0x3010,  N,  N,  N),
-	PINGROUP(ulpi_data5_po6,	SPI2,		HSI,		UARTA,		ULPI,		SPI2,		0x3014,  N,  N,  N),
-	PINGROUP(ulpi_data6_po7,	SPI2,		HSI,		UARTA,		ULPI,		SPI2,		0x3018,  N,  N,  N),
-	PINGROUP(ulpi_data7_po0,	SPI2,		HSI,		UARTA,		ULPI,		SPI2,		0x301c,  N,  N,  N),
-	PINGROUP(ulpi_clk_py0,		SPI1,		SPI5,		UARTD,		ULPI,		SPI1,		0x3020,  N,  N,  N),
-	PINGROUP(ulpi_dir_py1,		SPI1,		SPI5,		UARTD,		ULPI,		SPI1,		0x3024,  N,  N,  N),
-	PINGROUP(ulpi_nxt_py2,		SPI1,		SPI5,		UARTD,		ULPI,		SPI1,		0x3028,  N,  N,  N),
-	PINGROUP(ulpi_stp_py3,		SPI1,		SPI5,		UARTD,		ULPI,		SPI1,		0x302c,  N,  N,  N),
-	PINGROUP(dap3_fs_pp0,		I2S2,		SPI5,		DISPLAYA,	DISPLAYB,	I2S2,		0x3030,  N,  N,  N),
-	PINGROUP(dap3_din_pp1,		I2S2,		SPI5,		DISPLAYA,	DISPLAYB,	I2S2,		0x3034,  N,  N,  N),
-	PINGROUP(dap3_dout_pp2,		I2S2,		SPI5,		DISPLAYA,	RSVD4,		I2S2,		0x3038,  N,  N,  N),
-	PINGROUP(dap3_sclk_pp3,		I2S2,		SPI5,		RSVD3,		DISPLAYB,	I2S2,		0x303c,  N,  N,  N),
-	PINGROUP(pv0,			RSVD1,		RSVD2,		RSVD3,		RSVD4,		RSVD1,		0x3040,  N,  N,  N),
-	PINGROUP(pv1,			RSVD1,		RSVD2,		RSVD3,		RSVD4,		RSVD1,		0x3044,  N,  N,  N),
-	PINGROUP(sdmmc1_clk_pz0,	SDMMC1,		CLK12,		RSVD3,		RSVD4,		RSVD3,		0x3048,  N,  N,  N),
-	PINGROUP(sdmmc1_cmd_pz1,	SDMMC1,		SPDIF,		SPI4,		UARTA,		SDMMC1,		0x304c,  N,  N,  N),
-	PINGROUP(sdmmc1_dat3_py4,	SDMMC1,		SPDIF,		SPI4,		UARTA,		SDMMC1,		0x3050,  N,  N,  N),
-	PINGROUP(sdmmc1_dat2_py5,	SDMMC1,		PWM0,		SPI4,		UARTA,		SDMMC1,		0x3054,  N,  N,  N),
-	PINGROUP(sdmmc1_dat1_py6,	SDMMC1,		PWM1,		SPI4,		UARTA,		SDMMC1,		0x3058,  N,  N,  N),
-	PINGROUP(sdmmc1_dat0_py7,	SDMMC1,		RSVD2,		SPI4,		UARTA,		SDMMC1,		0x305c,  N,  N,  N),
-	PINGROUP(clk2_out_pw5,		EXTPERIPH2,	RSVD2,		RSVD3,		RSVD4,		EXTPERIPH2,	0x3068,  N,  N,  N),
-	PINGROUP(clk2_req_pcc5,		DAP,		RSVD2,		RSVD3,		RSVD4,		DAP,		0x306c,  N,  N,  N),
-	PINGROUP(hdmi_int_pn7,		RSVD1,		RSVD2,		RSVD3,		RSVD4,		RSVD1,		0x3110,  N,  N,  Y),
-	PINGROUP(ddc_scl_pv4,		I2C4,		RSVD2,		RSVD3,		RSVD4,		I2C4,		0x3114,  N,  N,  Y),
-	PINGROUP(ddc_sda_pv5,		I2C4,		RSVD2,		RSVD3,		RSVD4,		I2C4,		0x3118,  N,  N,  Y),
-	PINGROUP(uart2_rxd_pc3,		IRDA,		SPDIF,		UARTA,		SPI4,		IRDA,		0x3164,  N,  N,  N),
-	PINGROUP(uart2_txd_pc2,		IRDA,		SPDIF,		UARTA,		SPI4,		IRDA,		0x3168,  N,  N,  N),
-	PINGROUP(uart2_rts_n_pj6,	UARTA,		UARTB,		GMI,		SPI4,		UARTA,		0x316c,  N,  N,  N),
-	PINGROUP(uart2_cts_n_pj5,	UARTA,		UARTB,		GMI,		SPI4,		UARTA,		0x3170,  N,  N,  N),
-	PINGROUP(uart3_txd_pw6,		UARTC,		RSVD2,		GMI,		SPI4,		UARTC,		0x3174,  N,  N,  N),
-	PINGROUP(uart3_rxd_pw7,		UARTC,		RSVD2,		GMI,		SPI4,		UARTC,		0x3178,  N,  N,  N),
-	PINGROUP(uart3_cts_n_pa1,	UARTC,		SDMMC1,		DTV,		GMI,		UARTC,		0x317c,  N,  N,  N),
-	PINGROUP(uart3_rts_n_pc0,	UARTC,		PWM0,		DTV,		GMI,		UARTC,		0x3180,  N,  N,  N),
-	PINGROUP(pu0,			OWR,		UARTA,		GMI,		RSVD4,		RSVD4,		0x3184,  N,  N,  N),
-	PINGROUP(pu1,			RSVD1,		UARTA,		GMI,		RSVD4,		RSVD4,		0x3188,  N,  N,  N),
-	PINGROUP(pu2,			RSVD1,		UARTA,		GMI,		RSVD4,		RSVD4,		0x318c,  N,  N,  N),
-	PINGROUP(pu3,			PWM0,		UARTA,		GMI,		DISPLAYB,	PWM0,		0x3190,  N,  N,  N),
-	PINGROUP(pu4,			PWM1,		UARTA,		GMI,		DISPLAYB,	PWM1,		0x3194,  N,  N,  N),
-	PINGROUP(pu5,			PWM2,		UARTA,		GMI,		DISPLAYB,	PWM2,		0x3198,  N,  N,  N),
-	PINGROUP(pu6,			PWM3,		UARTA,		RSVD3,		GMI,		RSVD3,		0x319c,  N,  N,  N),
-	PINGROUP(gen1_i2c_scl_pc4,	I2C1,		RSVD2,		RSVD3,		RSVD4,		I2C1,		0x31a0,  Y,  N,  N),
-	PINGROUP(gen1_i2c_sda_pc5,	I2C1,		RSVD2,		RSVD3,		RSVD4,		I2C1,		0x31a4,  Y,  N,  N),
-	PINGROUP(dap4_fs_pp4,		I2S3,		GMI,		DTV,		RSVD4,		I2S3,		0x31a8,  N,  N,  N),
-	PINGROUP(dap4_din_pp5,		I2S3,		GMI,		RSVD3,		RSVD4,		I2S3,		0x31ac,  N,  N,  N),
-	PINGROUP(dap4_dout_pp6,		I2S3,		GMI,		DTV,		RSVD4,		I2S3,		0x31b0,  N,  N,  N),
-	PINGROUP(dap4_sclk_pp7,		I2S3,		GMI,		RSVD3,		RSVD4,		I2S3,		0x31b4,  N,  N,  N),
-	PINGROUP(clk3_out_pee0,		EXTPERIPH3,	RSVD2,		RSVD3,		RSVD4,		RSVD3,		0x31b8,  N,  N,  N),
-	PINGROUP(clk3_req_pee1,		DEV3,		RSVD2,		RSVD3,		RSVD4,		RSVD4,		0x31bc,  N,  N,  N),
-	PINGROUP(pc7,			RSVD1,		RSVD2,		GMI,		GMI_ALT,	RSVD1,		0x31c0,  N,  N,  N),
-	PINGROUP(pi5,			SDMMC2,		RSVD2,		GMI,		RSVD4,		GMI,		0x31c4,  N,  N,  N),
-	PINGROUP(pi7,			RSVD1,		TRACE,		GMI,		DTV,		RSVD1,		0x31c8,  N,  N,  N),
-	PINGROUP(pk0,			RSVD1,		SDMMC3,		GMI,		SOC,		RSVD1,		0x31cc,  N,  N,  N),
-	PINGROUP(pk1,			SDMMC2,		TRACE,		GMI,		RSVD4,		GMI,		0x31d0,  N,  N,  N),
-	PINGROUP(pj0,			RSVD1,		RSVD2,		GMI,		USB,		RSVD1,		0x31d4,  N,  N,  N),
-	PINGROUP(pj2,			RSVD1,		RSVD2,		GMI,		SOC,		RSVD1,		0x31d8,  N,  N,  N),
-	PINGROUP(pk3,			SDMMC2,		TRACE,		GMI,		CCLA,		GMI,		0x31dc,  N,  N,  N),
-	PINGROUP(pk4,			SDMMC2,		RSVD2,		GMI,		GMI_ALT,	GMI,		0x31e0,  N,  N,  N),
-	PINGROUP(pk2,			RSVD1,		RSVD2,		GMI,		RSVD4,		RSVD4,		0x31e4,  N,  N,  N),
-	PINGROUP(pi3,			RSVD1,		RSVD2,		GMI,		SPI4,		RSVD1,		0x31e8,  N,  N,  N),
-	PINGROUP(pi6,			RSVD1,		RSVD2,		GMI,		SDMMC2,		RSVD1,		0x31ec,  N,  N,  N),
-	PINGROUP(pg0,			RSVD1,		RSVD2,		GMI,		RSVD4,		RSVD4,		0x31f0,  N,  N,  N),
-	PINGROUP(pg1,			RSVD1,		RSVD2,		GMI,		RSVD4,		RSVD4,		0x31f4,  N,  N,  N),
-	PINGROUP(pg2,			RSVD1,		TRACE,		GMI,		RSVD4,		RSVD4,		0x31f8,  N,  N,  N),
-	PINGROUP(pg3,			RSVD1,		TRACE,		GMI,		RSVD4,		RSVD4,		0x31fc,  N,  N,  N),
-	PINGROUP(pg4,			RSVD1,		TMDS,		GMI,		SPI4,		RSVD1,		0x3200,  N,  N,  N),
-	PINGROUP(pg5,			RSVD1,		RSVD2,		GMI,		SPI4,		RSVD1,		0x3204,  N,  N,  N),
-	PINGROUP(pg6,			RSVD1,		RSVD2,		GMI,		SPI4,		RSVD1,		0x3208,  N,  N,  N),
-	PINGROUP(pg7,			RSVD1,		RSVD2,		GMI,		SPI4,		RSVD1,		0x320c,  N,  N,  N),
-	PINGROUP(ph0,			PWM0,		TRACE,		GMI,		DTV,		GMI,		0x3210,  N,  N,  N),
-	PINGROUP(ph1,			PWM1,		TMDS,		GMI,		DISPLAYA,	GMI,		0x3214,  N,  N,  N),
-	PINGROUP(ph2,			PWM2,		TMDS,		GMI,		CLDVFS,		GMI,		0x3218,  N,  N,  N),
-	PINGROUP(ph3,			PWM3,		SPI4,		GMI,		CLDVFS,		GMI,		0x321c,  N,  N,  N),
-	PINGROUP(ph4,			SDMMC2,		RSVD2,		GMI,		RSVD4,		GMI,		0x3220,  N,  N,  N),
-	PINGROUP(ph5,			SDMMC2,		RSVD2,		GMI,		RSVD4,		GMI,		0x3224,  N,  N,  N),
-	PINGROUP(ph6,			SDMMC2,		TRACE,		GMI,		DTV,		GMI,		0x3228,  N,  N,  N),
-	PINGROUP(ph7,			SDMMC2,		TRACE,		GMI,		DTV,		GMI,		0x322c,  N,  N,  N),
-	PINGROUP(pj7,			UARTD,		RSVD2,		GMI,		GMI_ALT,	RSVD2,		0x3230,  N,  N,  N),
-	PINGROUP(pb0,			UARTD,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x3234,  N,  N,  N),
-	PINGROUP(pb1,			UARTD,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x3238,  N,  N,  N),
-	PINGROUP(pk7,			UARTD,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x323c,  N,  N,  N),
-	PINGROUP(pi0,			RSVD1,		RSVD2,		GMI,		RSVD4,		RSVD4,		0x3240,  N,  N,  N),
-	PINGROUP(pi1,			RSVD1,		RSVD2,		GMI,		RSVD4,		RSVD1,		0x3244,  N,  N,  N),
-	PINGROUP(pi2,			SDMMC2,		TRACE,		GMI,		RSVD4,		GMI,		0x3248,  N,  N,  N),
-	PINGROUP(pi4,			SPI4,		TRACE,		GMI,		DISPLAYA,	GMI,		0x324c,  N,  N,  N),
-	PINGROUP(gen2_i2c_scl_pt5,	I2C2,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x3250,  Y,  N,  N),
-	PINGROUP(gen2_i2c_sda_pt6,	I2C2,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x3254,  Y,  N,  N),
-	PINGROUP(sdmmc4_clk_pcc4,	SDMMC4,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x3258,  N,  Y,  N),
-	PINGROUP(sdmmc4_cmd_pt7,	SDMMC4,		RSVD2,		GMI,		RSVD4,		RSVD2,		0x325c,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat0_paa0,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x3260,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat1_paa1,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x3264,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat2_paa2,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x3268,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat3_paa3,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x326c,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat4_paa4,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x3270,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat5_paa5,	SDMMC4,		SPI3,		RSVD3,		RSVD4,		SDMMC4,		0x3274,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat6_paa6,	SDMMC4,		SPI3,		GMI,		RSVD4,		SDMMC4,		0x3278,  N,  Y,  N),
-	PINGROUP(sdmmc4_dat7_paa7,	SDMMC4,		RSVD1,		GMI,		RSVD4,		SDMMC4,		0x327c,  N,  Y,  N),
-	PINGROUP(cam_mclk_pcc0,		VI,		VI_ALT1,	VI_ALT3,	SDMMC2,		VI,		0x3284,  N,  N,  N),
-	PINGROUP(pcc1,			I2S4,		RSVD1,		RSVD3,		SDMMC2,		I2S4,		0x3288,  N,  N,  N),
-	PINGROUP(pbb0,			VGP6,		VIMCLK2,	SDMMC2,		VIMCLK2_ALT,	VGP6,		0x328c,  N,  N,  N),
-	PINGROUP(cam_i2c_scl_pbb1,	VGP1,		I2C3,		RSVD3,		SDMMC2,		VGP1,		0x3290,  Y,  N,  N),
-	PINGROUP(cam_i2c_sda_pbb2,	VGP2,		I2C3,		RSVD3,		SDMMC2,		VGP2,		0x3294,  Y,  N,  N),
-	PINGROUP(pbb3,			VGP3,		DISPLAYA,	DISPLAYB,	SDMMC2,		VGP3,		0x3298,  N,  N,  N),
-	PINGROUP(pbb4,			VGP4,		DISPLAYA,	DISPLAYB,	SDMMC2,		VGP4,		0x329c,  N,  N,  N),
-	PINGROUP(pbb5,			VGP5,		DISPLAYA,	RSVD3,		SDMMC2,		VGP5,		0x32a0,  N,  N,  N),
-	PINGROUP(pbb6,			I2S4,		RSVD2,		DISPLAYB,	SDMMC2,		I2S4,		0x32a4,  N,  N,  N),
-	PINGROUP(pbb7,			I2S4,		RSVD2,		RSVD3,		SDMMC2,		I2S4,		0x32a8,  N,  N,  N),
-	PINGROUP(pcc2,			I2S4,		RSVD2,		SDMMC3,		SDMMC2,		I2S4,		0x32ac,  N,  N,  N),
-	PINGROUP(jtag_rtck,		RTCK,		RSVD2,		RSVD3,		RSVD4,		RTCK,		0x32b0,  N,  N,  N),
-	PINGROUP(pwr_i2c_scl_pz6,	I2CPWR,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x32b4,  Y,  N,  N),
-	PINGROUP(pwr_i2c_sda_pz7,	I2CPWR,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x32b8,  Y,  N,  N),
-	PINGROUP(kb_row0_pr0,		KBC,		RSVD2,		RSVD3,		RSVD4,		RSVD4,		0x32bc,  N,  N,  N),
-	PINGROUP(kb_row1_pr1,		KBC,		RSVD2,		RSVD3,		RSVD4,		RSVD4,		0x32c0,  N,  N,  N),
-	PINGROUP(kb_row2_pr2,		KBC,		RSVD2,		RSVD3,		RSVD4,		RSVD4,		0x32c4,  N,  N,  N),
-	PINGROUP(kb_row3_pr3,		KBC,		DISPLAYA,	SYS,		DISPLAYB,	KBC,		0x32c8,  N,  N,  N),
-	PINGROUP(kb_row4_pr4,		KBC,		DISPLAYA,	RSVD3,		DISPLAYB,	RSVD3,		0x32cc,  N,  N,  N),
-	PINGROUP(kb_row5_pr5,		KBC,		DISPLAYA,	RSVD3,		DISPLAYB,	RSVD3,		0x32d0,  N,  N,  N),
-	PINGROUP(kb_row6_pr6,		KBC,		DISPLAYA,	DISPLAYA_ALT,	DISPLAYB,	KBC,		0x32d4,  N,  N,  N),
-	PINGROUP(kb_row7_pr7,		KBC,		RSVD2,		CLDVFS,		UARTA,		RSVD2,		0x32d8,  N,  N,  N),
-	PINGROUP(kb_row8_ps0,		KBC,		RSVD2,		CLDVFS,		UARTA,		RSVD2,		0x32dc,  N,  N,  N),
-	PINGROUP(kb_row9_ps1,		KBC,		RSVD2,		RSVD3,		UARTA,		KBC,		0x32e0,  N,  N,  N),
-	PINGROUP(kb_row10_ps2,		KBC,		RSVD2,		RSVD3,		UARTA,		KBC,		0x32e4,  N,  N,  N),
-	PINGROUP(kb_row11_ps3,		KBC,		RSVD2,		RSVD3,		IRDA,		RSVD3,		0x32e8,  N,  N,  N),
-	PINGROUP(kb_row12_ps4,		KBC,		RSVD2,		RSVD3,		IRDA,		RSVD3,		0x32ec,  N,  N,  N),
-	PINGROUP(kb_row13_ps5,		KBC,		RSVD2,		SPI2,		RSVD4,		RSVD4,		0x32f0,  N,  N,  N),
-	PINGROUP(kb_row14_ps6,		KBC,		RSVD2,		SPI2,		RSVD4,		RSVD4,		0x32f4,  N,  N,  N),
-	PINGROUP(kb_row15_ps7,		KBC,		SOC,		RSVD3,		RSVD4,		KBC,		0x32f8,  N,  N,  N),
-	PINGROUP(kb_col0_pq0,		KBC,		RSVD2,		SPI2,		RSVD4,		RSVD4,		0x32fc,  N,  N,  N),
-	PINGROUP(kb_col1_pq1,		KBC,		RSVD2,		SPI2,		RSVD4,		RSVD4,		0x3300,  N,  N,  N),
-	PINGROUP(kb_col2_pq2,		KBC,		RSVD2,		SPI2,		RSVD4,		RSVD4,		0x3304,  N,  N,  N),
-	PINGROUP(kb_col3_pq3,		KBC,		DISPLAYA,	PWM2,		UARTA,		KBC,		0x3308,  N,  N,  N),
-	PINGROUP(kb_col4_pq4,		KBC,		OWR,		SDMMC3,		UARTA,		KBC,		0x330c,  N,  N,  N),
-	PINGROUP(kb_col5_pq5,		KBC,		RSVD2,		SDMMC3,		RSVD4,		RSVD4,		0x3310,  N,  N,  N),
-	PINGROUP(kb_col6_pq6,		KBC,		RSVD2,		SPI2,		UARTD,		RSVD2,		0x3314,  N,  N,  N),
-	PINGROUP(kb_col7_pq7,		KBC,		RSVD2,		SPI2,		UARTD,		RSVD2,		0x3318,  N,  N,  N),
-	PINGROUP(clk_32k_out_pa0,	BLINK,		SOC,		RSVD3,		RSVD4,		RSVD3,		0x331c,  N,  N,  N),
-	PINGROUP(core_pwr_req,		PWRON,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x3324,  N,  N,  N),
-	PINGROUP(cpu_pwr_req,		CPU,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x3328,  N,  N,  N),
-	PINGROUP(pwr_int_n,		PMI,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x332c,  N,  N,  N),
-	PINGROUP(clk_32k_in,		CLK,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x3330,  N,  N,  N),
-	PINGROUP(owr,			OWR,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x3334,  N,  N,  Y),
-	PINGROUP(dap1_fs_pn0,		I2S0,		HDA,		GMI,		RSVD4,		RSVD4,		0x3338,  N,  N,  N),
-	PINGROUP(dap1_din_pn1,		I2S0,		HDA,		GMI,		RSVD4,		RSVD4,		0x333c,  N,  N,  N),
-	PINGROUP(dap1_dout_pn2,		I2S0,		HDA,		GMI,		SATA,		I2S0,		0x3340,  N,  N,  N),
-	PINGROUP(dap1_sclk_pn3,		I2S0,		HDA,		GMI,		RSVD4,		I2S0,		0x3344,  N,  N,  N),
-	PINGROUP(dap_mclk1_req_pee2,	DAP,		DAP1,		SATA,		RSVD4,		DAP,		0x3348,  N,  N,  N),
-	PINGROUP(dap_mclk1_pw4,		EXTPERIPH1,	DAP2,		RSVD3,		RSVD4,		RSVD3,		0x334c,  N,  N,  N),
-	PINGROUP(spdif_in_pk6,		SPDIF,		RSVD2,		RSVD3,		I2C3,		RSVD3,		0x3350,  N,  N,  N),
-	PINGROUP(spdif_out_pk5,		SPDIF,		RSVD2,		RSVD3,		I2C3,		RSVD3,		0x3354,  N,  N,  N),
-	PINGROUP(dap2_fs_pa2,		I2S1,		HDA,		GMI,		RSVD4,		I2S1,		0x3358,  N,  N,  N),
-	PINGROUP(dap2_din_pa4,		I2S1,		HDA,		GMI,		RSVD4,		I2S1,		0x335c,  N,  N,  N),
-	PINGROUP(dap2_dout_pa5,		I2S1,		HDA,		GMI,		RSVD4,		I2S1,		0x3360,  N,  N,  N),
-	PINGROUP(dap2_sclk_pa3,		I2S1,		HDA,		GMI,		RSVD4,		I2S1,		0x3364,  N,  N,  N),
-	PINGROUP(dvfs_pwm_px0,		SPI6,		CLDVFS,		GMI,		RSVD4,		SPI6,		0x3368,  N,  N,  N),
-	PINGROUP(gpio_x1_aud_px1,	SPI6,		RSVD2,		GMI,		RSVD4,		SPI6,		0x336c,  N,  N,  N),
-	PINGROUP(gpio_x3_aud_px3,	SPI6,		SPI1,		GMI,		RSVD4,		SPI6,		0x3370,  N,  N,  N),
-	PINGROUP(dvfs_clk_px2,		SPI6,		CLDVFS,		GMI,		RSVD4,		SPI6,		0x3374,  N,  N,  N),
-	PINGROUP(gpio_x4_aud_px4,	GMI,		SPI1,		SPI2,		DAP2,		SPI1,		0x3378,  N,  N,  N),
-	PINGROUP(gpio_x5_aud_px5,	GMI,		SPI1,		SPI2,		RSVD4,		SPI1,		0x337c,  N,  N,  N),
-	PINGROUP(gpio_x6_aud_px6,	SPI6,		SPI1,		SPI2,		GMI,		SPI1,		0x3380,  N,  N,  N),
-	PINGROUP(gpio_x7_aud_px7,	RSVD1,		SPI1,		SPI2,		RSVD4,		SPI1,		0x3384,  N,  N,  N),
-	PINGROUP(sdmmc3_clk_pa6,	SDMMC3,		RSVD2,		RSVD3,		SPI3,		SDMMC3,		0x3390,  N,  N,  N),
-	PINGROUP(sdmmc3_cmd_pa7,	SDMMC3,		PWM3,		UARTA,		SPI3,		SDMMC3,		0x3394,  N,  N,  N),
-	PINGROUP(sdmmc3_dat0_pb7,	SDMMC3,		RSVD2,		RSVD3,		SPI3,		SDMMC3,		0x3398,  N,  N,  N),
-	PINGROUP(sdmmc3_dat1_pb6,	SDMMC3,		PWM2,		UARTA,		SPI3,		SDMMC3,		0x339c,  N,  N,  N),
-	PINGROUP(sdmmc3_dat2_pb5,	SDMMC3,		PWM1,		DISPLAYA,	SPI3,		SDMMC3,		0x33a0,  N,  N,  N),
-	PINGROUP(sdmmc3_dat3_pb4,	SDMMC3,		PWM0,		DISPLAYB,	SPI3,		SDMMC3,		0x33a4,  N,  N,  N),
-	PINGROUP(pex_l0_rst_n_pdd1,	PE0,		RSVD2,		RSVD3,		RSVD4,		PE0,		0x33bc,  N,  N,  N),
-	PINGROUP(pex_l0_clkreq_n_pdd2,	PE0,		RSVD2,		RSVD3,		RSVD4,		PE0,		0x33c0,  N,  N,  N),
-	PINGROUP(pex_wake_n_pdd3,	PE,		RSVD2,		RSVD3,		RSVD4,		PE,		0x33c4,  N,  N,  N),
-	PINGROUP(pex_l1_rst_n_pdd5,	PE1,		RSVD2,		RSVD3,		RSVD4,		PE1,		0x33cc,  N,  N,  N),
-	PINGROUP(pex_l1_clkreq_n_pdd6,	PE1,		RSVD2,		RSVD3,		RSVD4,		PE1,		0x33d0,  N,  N,  N),
-	PINGROUP(hdmi_cec_pee3,		CEC,		RSVD2,		RSVD3,		RSVD4,		CEC,		0x33e0,  Y,  N,  N),
-	PINGROUP(sdmmc1_wp_n_pv3,	SDMMC1,		CLK12,		SPI4,		UARTA,		SDMMC1,		0x33e4,  N,  N,  N),
-	PINGROUP(sdmmc3_cd_n_pv2,	SDMMC3,		OWR,		RSVD3,		RSVD4,		SDMMC3,		0x33e8,  N,  N,  N),
-	PINGROUP(gpio_w2_aud_pw2,	SPI6,		RSVD2,		SPI2,		I2C1,		RSVD2,		0x33ec,  N,  N,  N),
-	PINGROUP(gpio_w3_aud_pw3,	SPI6,		SPI1,		SPI2,		I2C1,		SPI1,		0x33f0,  N,  N,  N),
-	PINGROUP(usb_vbus_en0_pn4,	USB,		RSVD2,		RSVD3,		RSVD4,		USB,		0x33f4,  Y,  N,  N),
-	PINGROUP(usb_vbus_en1_pn5,	USB,		RSVD2,		RSVD3,		RSVD4,		USB,		0x33f8,  Y,  N,  N),
-	PINGROUP(sdmmc3_clk_lb_out_pee4,	SDMMC3,	RSVD2,		RSVD3,		RSVD4,		SDMMC3,		0x33fc,  N,  N,  N),
-	PINGROUP(sdmmc3_clk_lb_in_pee5,	SDMMC3,		RSVD2,		RSVD3,		RSVD4,		SDMMC3,		0x3400,  N,  N,  N),
-	PINGROUP(gmi_clk_lb,		SDMMC2,		RSVD2,		GMI,		RSVD4,		SDMMC2,		0x3404,  N,  N,  N),
-	PINGROUP(reset_out_n,		RSVD1,		RSVD2,		RSVD3,		RESET_OUT_N,	RSVD1,		0x3408,  N,  N,  N),
-	PINGROUP(kb_row16_pt0,		KBC,		RSVD2,		RSVD3,		UARTC,		KBC,		0x340c,  N,  N,  N),
-	PINGROUP(kb_row17_pt1,		KBC,		RSVD2,		RSVD3,		UARTC,		KBC,		0x3410,  N,  N,  N),
-	PINGROUP(usb_vbus_en2_pff1,	USB,		RSVD2,		RSVD3,		RSVD4,		USB,		0x3414,  Y,  N,  N),
-	PINGROUP(pff2,			SATA,		RSVD2,		RSVD3,		RSVD4,		RSVD2,		0x3418,  Y,  N,  N),
-	PINGROUP(dp_hpd_pff0,		DP,		RSVD2,		RSVD3,		RSVD4,		DP,		0x3430,  N,  N,  N),
+	/*       pg_name,                f0,         f1,         f2,           f3,          safe,       r,      od, ior, rcv_sel */
+	PINGROUP(ulpi_data0_po1,         SPI3,       HSI,        UARTA,        ULPI,        SPI3,       0x3000,  N,  N,  N),
+	PINGROUP(ulpi_data1_po2,         SPI3,       HSI,        UARTA,        ULPI,        SPI3,       0x3004,  N,  N,  N),
+	PINGROUP(ulpi_data2_po3,         SPI3,       HSI,        UARTA,        ULPI,        SPI3,       0x3008,  N,  N,  N),
+	PINGROUP(ulpi_data3_po4,         SPI3,       HSI,        UARTA,        ULPI,        SPI3,       0x300c,  N,  N,  N),
+	PINGROUP(ulpi_data4_po5,         SPI2,       HSI,        UARTA,        ULPI,        SPI2,       0x3010,  N,  N,  N),
+	PINGROUP(ulpi_data5_po6,         SPI2,       HSI,        UARTA,        ULPI,        SPI2,       0x3014,  N,  N,  N),
+	PINGROUP(ulpi_data6_po7,         SPI2,       HSI,        UARTA,        ULPI,        SPI2,       0x3018,  N,  N,  N),
+	PINGROUP(ulpi_data7_po0,         SPI2,       HSI,        UARTA,        ULPI,        SPI2,       0x301c,  N,  N,  N),
+	PINGROUP(ulpi_clk_py0,           SPI1,       SPI5,       UARTD,        ULPI,        SPI1,       0x3020,  N,  N,  N),
+	PINGROUP(ulpi_dir_py1,           SPI1,       SPI5,       UARTD,        ULPI,        SPI1,       0x3024,  N,  N,  N),
+	PINGROUP(ulpi_nxt_py2,           SPI1,       SPI5,       UARTD,        ULPI,        SPI1,       0x3028,  N,  N,  N),
+	PINGROUP(ulpi_stp_py3,           SPI1,       SPI5,       UARTD,        ULPI,        SPI1,       0x302c,  N,  N,  N),
+	PINGROUP(dap3_fs_pp0,            I2S2,       SPI5,       DISPLAYA,     DISPLAYB,    I2S2,       0x3030,  N,  N,  N),
+	PINGROUP(dap3_din_pp1,           I2S2,       SPI5,       DISPLAYA,     DISPLAYB,    I2S2,       0x3034,  N,  N,  N),
+	PINGROUP(dap3_dout_pp2,          I2S2,       SPI5,       DISPLAYA,     RSVD4,       I2S2,       0x3038,  N,  N,  N),
+	PINGROUP(dap3_sclk_pp3,          I2S2,       SPI5,       RSVD3,        DISPLAYB,    I2S2,       0x303c,  N,  N,  N),
+	PINGROUP(pv0,                    RSVD1,      RSVD2,      RSVD3,        RSVD4,       RSVD1,      0x3040,  N,  N,  N),
+	PINGROUP(pv1,                    RSVD1,      RSVD2,      RSVD3,        RSVD4,       RSVD1,      0x3044,  N,  N,  N),
+	PINGROUP(sdmmc1_clk_pz0,         SDMMC1,     CLK12,      RSVD3,        RSVD4,       RSVD3,      0x3048,  N,  N,  N),
+	PINGROUP(sdmmc1_cmd_pz1,         SDMMC1,     SPDIF,      SPI4,         UARTA,       SDMMC1,     0x304c,  N,  N,  N),
+	PINGROUP(sdmmc1_dat3_py4,        SDMMC1,     SPDIF,      SPI4,         UARTA,       SDMMC1,     0x3050,  N,  N,  N),
+	PINGROUP(sdmmc1_dat2_py5,        SDMMC1,     PWM0,       SPI4,         UARTA,       SDMMC1,     0x3054,  N,  N,  N),
+	PINGROUP(sdmmc1_dat1_py6,        SDMMC1,     PWM1,       SPI4,         UARTA,       SDMMC1,     0x3058,  N,  N,  N),
+	PINGROUP(sdmmc1_dat0_py7,        SDMMC1,     RSVD2,      SPI4,         UARTA,       SDMMC1,     0x305c,  N,  N,  N),
+	PINGROUP(clk2_out_pw5,           EXTPERIPH2, RSVD2,      RSVD3,        RSVD4,       EXTPERIPH2, 0x3068,  N,  N,  N),
+	PINGROUP(clk2_req_pcc5,          DAP,        RSVD2,      RSVD3,        RSVD4,       DAP,        0x306c,  N,  N,  N),
+	PINGROUP(hdmi_int_pn7,           RSVD1,      RSVD2,      RSVD3,        RSVD4,       RSVD1,      0x3110,  N,  N,  Y),
+	PINGROUP(ddc_scl_pv4,            I2C4,       RSVD2,      RSVD3,        RSVD4,       I2C4,       0x3114,  N,  N,  Y),
+	PINGROUP(ddc_sda_pv5,            I2C4,       RSVD2,      RSVD3,        RSVD4,       I2C4,       0x3118,  N,  N,  Y),
+	PINGROUP(uart2_rxd_pc3,          IRDA,       SPDIF,      UARTA,        SPI4,        IRDA,       0x3164,  N,  N,  N),
+	PINGROUP(uart2_txd_pc2,          IRDA,       SPDIF,      UARTA,        SPI4,        IRDA,       0x3168,  N,  N,  N),
+	PINGROUP(uart2_rts_n_pj6,        UARTA,      UARTB,      GMI,          SPI4,        UARTA,      0x316c,  N,  N,  N),
+	PINGROUP(uart2_cts_n_pj5,        UARTA,      UARTB,      GMI,          SPI4,        UARTA,      0x3170,  N,  N,  N),
+	PINGROUP(uart3_txd_pw6,          UARTC,      RSVD2,      GMI,          SPI4,        UARTC,      0x3174,  N,  N,  N),
+	PINGROUP(uart3_rxd_pw7,          UARTC,      RSVD2,      GMI,          SPI4,        UARTC,      0x3178,  N,  N,  N),
+	PINGROUP(uart3_cts_n_pa1,        UARTC,      SDMMC1,     DTV,          GMI,         UARTC,      0x317c,  N,  N,  N),
+	PINGROUP(uart3_rts_n_pc0,        UARTC,      PWM0,       DTV,          GMI,         UARTC,      0x3180,  N,  N,  N),
+	PINGROUP(pu0,                    OWR,        UARTA,      GMI,          RSVD4,       RSVD4,      0x3184,  N,  N,  N),
+	PINGROUP(pu1,                    RSVD1,      UARTA,      GMI,          RSVD4,       RSVD4,      0x3188,  N,  N,  N),
+	PINGROUP(pu2,                    RSVD1,      UARTA,      GMI,          RSVD4,       RSVD4,      0x318c,  N,  N,  N),
+	PINGROUP(pu3,                    PWM0,       UARTA,      GMI,          DISPLAYB,    PWM0,       0x3190,  N,  N,  N),
+	PINGROUP(pu4,                    PWM1,       UARTA,      GMI,          DISPLAYB,    PWM1,       0x3194,  N,  N,  N),
+	PINGROUP(pu5,                    PWM2,       UARTA,      GMI,          DISPLAYB,    PWM2,       0x3198,  N,  N,  N),
+	PINGROUP(pu6,                    PWM3,       UARTA,      RSVD3,        GMI,         RSVD3,      0x319c,  N,  N,  N),
+	PINGROUP(gen1_i2c_scl_pc4,       I2C1,       RSVD2,      RSVD3,        RSVD4,       I2C1,       0x31a0,  Y,  N,  N),
+	PINGROUP(gen1_i2c_sda_pc5,       I2C1,       RSVD2,      RSVD3,        RSVD4,       I2C1,       0x31a4,  Y,  N,  N),
+	PINGROUP(dap4_fs_pp4,            I2S3,       GMI,        DTV,          RSVD4,       I2S3,       0x31a8,  N,  N,  N),
+	PINGROUP(dap4_din_pp5,           I2S3,       GMI,        RSVD3,        RSVD4,       I2S3,       0x31ac,  N,  N,  N),
+	PINGROUP(dap4_dout_pp6,          I2S3,       GMI,        DTV,          RSVD4,       I2S3,       0x31b0,  N,  N,  N),
+	PINGROUP(dap4_sclk_pp7,          I2S3,       GMI,        RSVD3,        RSVD4,       I2S3,       0x31b4,  N,  N,  N),
+	PINGROUP(clk3_out_pee0,          EXTPERIPH3, RSVD2,      RSVD3,        RSVD4,       RSVD3,      0x31b8,  N,  N,  N),
+	PINGROUP(clk3_req_pee1,          DEV3,       RSVD2,      RSVD3,        RSVD4,       RSVD4,      0x31bc,  N,  N,  N),
+	PINGROUP(pc7,                    RSVD1,      RSVD2,      GMI,          GMI_ALT,     RSVD1,      0x31c0,  N,  N,  N),
+	PINGROUP(pi5,                    SDMMC2,     RSVD2,      GMI,          RSVD4,       GMI,        0x31c4,  N,  N,  N),
+	PINGROUP(pi7,                    RSVD1,      TRACE,      GMI,          DTV,         RSVD1,      0x31c8,  N,  N,  N),
+	PINGROUP(pk0,                    RSVD1,      SDMMC3,     GMI,          SOC,         RSVD1,      0x31cc,  N,  N,  N),
+	PINGROUP(pk1,                    SDMMC2,     TRACE,      GMI,          RSVD4,       GMI,        0x31d0,  N,  N,  N),
+	PINGROUP(pj0,                    RSVD1,      RSVD2,      GMI,          USB,         RSVD1,      0x31d4,  N,  N,  N),
+	PINGROUP(pj2,                    RSVD1,      RSVD2,      GMI,          SOC,         RSVD1,      0x31d8,  N,  N,  N),
+	PINGROUP(pk3,                    SDMMC2,     TRACE,      GMI,          CCLA,        GMI,        0x31dc,  N,  N,  N),
+	PINGROUP(pk4,                    SDMMC2,     RSVD2,      GMI,          GMI_ALT,     GMI,        0x31e0,  N,  N,  N),
+	PINGROUP(pk2,                    RSVD1,      RSVD2,      GMI,          RSVD4,       RSVD4,      0x31e4,  N,  N,  N),
+	PINGROUP(pi3,                    RSVD1,      RSVD2,      GMI,          SPI4,        RSVD1,      0x31e8,  N,  N,  N),
+	PINGROUP(pi6,                    RSVD1,      RSVD2,      GMI,          SDMMC2,      RSVD1,      0x31ec,  N,  N,  N),
+	PINGROUP(pg0,                    RSVD1,      RSVD2,      GMI,          RSVD4,       RSVD4,      0x31f0,  N,  N,  N),
+	PINGROUP(pg1,                    RSVD1,      RSVD2,      GMI,          RSVD4,       RSVD4,      0x31f4,  N,  N,  N),
+	PINGROUP(pg2,                    RSVD1,      TRACE,      GMI,          RSVD4,       RSVD4,      0x31f8,  N,  N,  N),
+	PINGROUP(pg3,                    RSVD1,      TRACE,      GMI,          RSVD4,       RSVD4,      0x31fc,  N,  N,  N),
+	PINGROUP(pg4,                    RSVD1,      TMDS,       GMI,          SPI4,        RSVD1,      0x3200,  N,  N,  N),
+	PINGROUP(pg5,                    RSVD1,      RSVD2,      GMI,          SPI4,        RSVD1,      0x3204,  N,  N,  N),
+	PINGROUP(pg6,                    RSVD1,      RSVD2,      GMI,          SPI4,        RSVD1,      0x3208,  N,  N,  N),
+	PINGROUP(pg7,                    RSVD1,      RSVD2,      GMI,          SPI4,        RSVD1,      0x320c,  N,  N,  N),
+	PINGROUP(ph0,                    PWM0,       TRACE,      GMI,          DTV,         GMI,        0x3210,  N,  N,  N),
+	PINGROUP(ph1,                    PWM1,       TMDS,       GMI,          DISPLAYA,    GMI,        0x3214,  N,  N,  N),
+	PINGROUP(ph2,                    PWM2,       TMDS,       GMI,          CLDVFS,      GMI,        0x3218,  N,  N,  N),
+	PINGROUP(ph3,                    PWM3,       SPI4,       GMI,          CLDVFS,      GMI,        0x321c,  N,  N,  N),
+	PINGROUP(ph4,                    SDMMC2,     RSVD2,      GMI,          RSVD4,       GMI,        0x3220,  N,  N,  N),
+	PINGROUP(ph5,                    SDMMC2,     RSVD2,      GMI,          RSVD4,       GMI,        0x3224,  N,  N,  N),
+	PINGROUP(ph6,                    SDMMC2,     TRACE,      GMI,          DTV,         GMI,        0x3228,  N,  N,  N),
+	PINGROUP(ph7,                    SDMMC2,     TRACE,      GMI,          DTV,         GMI,        0x322c,  N,  N,  N),
+	PINGROUP(pj7,                    UARTD,      RSVD2,      GMI,          GMI_ALT,     RSVD2,      0x3230,  N,  N,  N),
+	PINGROUP(pb0,                    UARTD,      RSVD2,      GMI,          RSVD4,       RSVD2,      0x3234,  N,  N,  N),
+	PINGROUP(pb1,                    UARTD,      RSVD2,      GMI,          RSVD4,       RSVD2,      0x3238,  N,  N,  N),
+	PINGROUP(pk7,                    UARTD,      RSVD2,      GMI,          RSVD4,       RSVD2,      0x323c,  N,  N,  N),
+	PINGROUP(pi0,                    RSVD1,      RSVD2,      GMI,          RSVD4,       RSVD4,      0x3240,  N,  N,  N),
+	PINGROUP(pi1,                    RSVD1,      RSVD2,      GMI,          RSVD4,       RSVD1,      0x3244,  N,  N,  N),
+	PINGROUP(pi2,                    SDMMC2,     TRACE,      GMI,          RSVD4,       GMI,        0x3248,  N,  N,  N),
+	PINGROUP(pi4,                    SPI4,       TRACE,      GMI,          DISPLAYA,    GMI,        0x324c,  N,  N,  N),
+	PINGROUP(gen2_i2c_scl_pt5,       I2C2,       RSVD2,      GMI,          RSVD4,       RSVD2,      0x3250,  Y,  N,  N),
+	PINGROUP(gen2_i2c_sda_pt6,       I2C2,       RSVD2,      GMI,          RSVD4,       RSVD2,      0x3254,  Y,  N,  N),
+	PINGROUP(sdmmc4_clk_pcc4,        SDMMC4,     RSVD2,      GMI,          RSVD4,       RSVD2,      0x3258,  N,  Y,  N),
+	PINGROUP(sdmmc4_cmd_pt7,         SDMMC4,     RSVD2,      GMI,          RSVD4,       RSVD2,      0x325c,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat0_paa0,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x3260,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat1_paa1,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x3264,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat2_paa2,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x3268,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat3_paa3,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x326c,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat4_paa4,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x3270,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat5_paa5,       SDMMC4,     SPI3,       RSVD3,        RSVD4,       SDMMC4,     0x3274,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat6_paa6,       SDMMC4,     SPI3,       GMI,          RSVD4,       SDMMC4,     0x3278,  N,  Y,  N),
+	PINGROUP(sdmmc4_dat7_paa7,       SDMMC4,     RSVD1,      GMI,          RSVD4,       SDMMC4,     0x327c,  N,  Y,  N),
+	PINGROUP(cam_mclk_pcc0,          VI,         VI_ALT1,    VI_ALT3,      SDMMC2,      VI,         0x3284,  N,  N,  N),
+	PINGROUP(pcc1,                   I2S4,       RSVD1,      RSVD3,        SDMMC2,      I2S4,       0x3288,  N,  N,  N),
+	PINGROUP(pbb0,                   VGP6,       VIMCLK2,    SDMMC2,       VIMCLK2_ALT, VGP6,       0x328c,  N,  N,  N),
+	PINGROUP(cam_i2c_scl_pbb1,       VGP1,       I2C3,       RSVD3,        SDMMC2,      VGP1,       0x3290,  Y,  N,  N),
+	PINGROUP(cam_i2c_sda_pbb2,       VGP2,       I2C3,       RSVD3,        SDMMC2,      VGP2,       0x3294,  Y,  N,  N),
+	PINGROUP(pbb3,                   VGP3,       DISPLAYA,   DISPLAYB,     SDMMC2,      VGP3,       0x3298,  N,  N,  N),
+	PINGROUP(pbb4,                   VGP4,       DISPLAYA,   DISPLAYB,     SDMMC2,      VGP4,       0x329c,  N,  N,  N),
+	PINGROUP(pbb5,                   VGP5,       DISPLAYA,   RSVD3,        SDMMC2,      VGP5,       0x32a0,  N,  N,  N),
+	PINGROUP(pbb6,                   I2S4,       RSVD2,      DISPLAYB,     SDMMC2,      I2S4,       0x32a4,  N,  N,  N),
+	PINGROUP(pbb7,                   I2S4,       RSVD2,      RSVD3,        SDMMC2,      I2S4,       0x32a8,  N,  N,  N),
+	PINGROUP(pcc2,                   I2S4,       RSVD2,      SDMMC3,       SDMMC2,      I2S4,       0x32ac,  N,  N,  N),
+	PINGROUP(jtag_rtck,              RTCK,       RSVD2,      RSVD3,        RSVD4,       RTCK,       0x32b0,  N,  N,  N),
+	PINGROUP(pwr_i2c_scl_pz6,        I2CPWR,     RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x32b4,  Y,  N,  N),
+	PINGROUP(pwr_i2c_sda_pz7,        I2CPWR,     RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x32b8,  Y,  N,  N),
+	PINGROUP(kb_row0_pr0,            KBC,        RSVD2,      RSVD3,        RSVD4,       RSVD4,      0x32bc,  N,  N,  N),
+	PINGROUP(kb_row1_pr1,            KBC,        RSVD2,      RSVD3,        RSVD4,       RSVD4,      0x32c0,  N,  N,  N),
+	PINGROUP(kb_row2_pr2,            KBC,        RSVD2,      RSVD3,        RSVD4,       RSVD4,      0x32c4,  N,  N,  N),
+	PINGROUP(kb_row3_pr3,            KBC,        DISPLAYA,   SYS,          DISPLAYB,    KBC,        0x32c8,  N,  N,  N),
+	PINGROUP(kb_row4_pr4,            KBC,        DISPLAYA,   RSVD3,        DISPLAYB,    RSVD3,      0x32cc,  N,  N,  N),
+	PINGROUP(kb_row5_pr5,            KBC,        DISPLAYA,   RSVD3,        DISPLAYB,    RSVD3,      0x32d0,  N,  N,  N),
+	PINGROUP(kb_row6_pr6,            KBC,        DISPLAYA,   DISPLAYA_ALT, DISPLAYB,    KBC,        0x32d4,  N,  N,  N),
+	PINGROUP(kb_row7_pr7,            KBC,        RSVD2,      CLDVFS,       UARTA,       RSVD2,      0x32d8,  N,  N,  N),
+	PINGROUP(kb_row8_ps0,            KBC,        RSVD2,      CLDVFS,       UARTA,       RSVD2,      0x32dc,  N,  N,  N),
+	PINGROUP(kb_row9_ps1,            KBC,        RSVD2,      RSVD3,        UARTA,       KBC,        0x32e0,  N,  N,  N),
+	PINGROUP(kb_row10_ps2,           KBC,        RSVD2,      RSVD3,        UARTA,       KBC,        0x32e4,  N,  N,  N),
+	PINGROUP(kb_row11_ps3,           KBC,        RSVD2,      RSVD3,        IRDA,        RSVD3,      0x32e8,  N,  N,  N),
+	PINGROUP(kb_row12_ps4,           KBC,        RSVD2,      RSVD3,        IRDA,        RSVD3,      0x32ec,  N,  N,  N),
+	PINGROUP(kb_row13_ps5,           KBC,        RSVD2,      SPI2,         RSVD4,       RSVD4,      0x32f0,  N,  N,  N),
+	PINGROUP(kb_row14_ps6,           KBC,        RSVD2,      SPI2,         RSVD4,       RSVD4,      0x32f4,  N,  N,  N),
+	PINGROUP(kb_row15_ps7,           KBC,        SOC,        RSVD3,        RSVD4,       KBC,        0x32f8,  N,  N,  N),
+	PINGROUP(kb_col0_pq0,            KBC,        RSVD2,      SPI2,         RSVD4,       RSVD4,      0x32fc,  N,  N,  N),
+	PINGROUP(kb_col1_pq1,            KBC,        RSVD2,      SPI2,         RSVD4,       RSVD4,      0x3300,  N,  N,  N),
+	PINGROUP(kb_col2_pq2,            KBC,        RSVD2,      SPI2,         RSVD4,       RSVD4,      0x3304,  N,  N,  N),
+	PINGROUP(kb_col3_pq3,            KBC,        DISPLAYA,   PWM2,         UARTA,       KBC,        0x3308,  N,  N,  N),
+	PINGROUP(kb_col4_pq4,            KBC,        OWR,        SDMMC3,       UARTA,       KBC,        0x330c,  N,  N,  N),
+	PINGROUP(kb_col5_pq5,            KBC,        RSVD2,      SDMMC3,       RSVD4,       RSVD4,      0x3310,  N,  N,  N),
+	PINGROUP(kb_col6_pq6,            KBC,        RSVD2,      SPI2,         UARTD,       RSVD2,      0x3314,  N,  N,  N),
+	PINGROUP(kb_col7_pq7,            KBC,        RSVD2,      SPI2,         UARTD,       RSVD2,      0x3318,  N,  N,  N),
+	PINGROUP(clk_32k_out_pa0,        BLINK,      SOC,        RSVD3,        RSVD4,       RSVD3,      0x331c,  N,  N,  N),
+	PINGROUP(core_pwr_req,           PWRON,      RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x3324,  N,  N,  N),
+	PINGROUP(cpu_pwr_req,            CPU,        RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x3328,  N,  N,  N),
+	PINGROUP(pwr_int_n,              PMI,        RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x332c,  N,  N,  N),
+	PINGROUP(clk_32k_in,             CLK,        RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x3330,  N,  N,  N),
+	PINGROUP(owr,                    OWR,        RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x3334,  N,  N,  Y),
+	PINGROUP(dap1_fs_pn0,            I2S0,       HDA,        GMI,          RSVD4,       RSVD4,      0x3338,  N,  N,  N),
+	PINGROUP(dap1_din_pn1,           I2S0,       HDA,        GMI,          RSVD4,       RSVD4,      0x333c,  N,  N,  N),
+	PINGROUP(dap1_dout_pn2,          I2S0,       HDA,        GMI,          SATA,        I2S0,       0x3340,  N,  N,  N),
+	PINGROUP(dap1_sclk_pn3,          I2S0,       HDA,        GMI,          RSVD4,       I2S0,       0x3344,  N,  N,  N),
+	PINGROUP(dap_mclk1_req_pee2,     DAP,        DAP1,       SATA,         RSVD4,       DAP,        0x3348,  N,  N,  N),
+	PINGROUP(dap_mclk1_pw4,          EXTPERIPH1, DAP2,       RSVD3,        RSVD4,       RSVD3,      0x334c,  N,  N,  N),
+	PINGROUP(spdif_in_pk6,           SPDIF,      RSVD2,      RSVD3,        I2C3,        RSVD3,      0x3350,  N,  N,  N),
+	PINGROUP(spdif_out_pk5,          SPDIF,      RSVD2,      RSVD3,        I2C3,        RSVD3,      0x3354,  N,  N,  N),
+	PINGROUP(dap2_fs_pa2,            I2S1,       HDA,        GMI,          RSVD4,       I2S1,       0x3358,  N,  N,  N),
+	PINGROUP(dap2_din_pa4,           I2S1,       HDA,        GMI,          RSVD4,       I2S1,       0x335c,  N,  N,  N),
+	PINGROUP(dap2_dout_pa5,          I2S1,       HDA,        GMI,          RSVD4,       I2S1,       0x3360,  N,  N,  N),
+	PINGROUP(dap2_sclk_pa3,          I2S1,       HDA,        GMI,          RSVD4,       I2S1,       0x3364,  N,  N,  N),
+	PINGROUP(dvfs_pwm_px0,           SPI6,       CLDVFS,     GMI,          RSVD4,       SPI6,       0x3368,  N,  N,  N),
+	PINGROUP(gpio_x1_aud_px1,        SPI6,       RSVD2,      GMI,          RSVD4,       SPI6,       0x336c,  N,  N,  N),
+	PINGROUP(gpio_x3_aud_px3,        SPI6,       SPI1,       GMI,          RSVD4,       SPI6,       0x3370,  N,  N,  N),
+	PINGROUP(dvfs_clk_px2,           SPI6,       CLDVFS,     GMI,          RSVD4,       SPI6,       0x3374,  N,  N,  N),
+	PINGROUP(gpio_x4_aud_px4,        GMI,        SPI1,       SPI2,         DAP2,        SPI1,       0x3378,  N,  N,  N),
+	PINGROUP(gpio_x5_aud_px5,        GMI,        SPI1,       SPI2,         RSVD4,       SPI1,       0x337c,  N,  N,  N),
+	PINGROUP(gpio_x6_aud_px6,        SPI6,       SPI1,       SPI2,         GMI,         SPI1,       0x3380,  N,  N,  N),
+	PINGROUP(gpio_x7_aud_px7,        RSVD1,      SPI1,       SPI2,         RSVD4,       SPI1,       0x3384,  N,  N,  N),
+	PINGROUP(sdmmc3_clk_pa6,         SDMMC3,     RSVD2,      RSVD3,        SPI3,        SDMMC3,     0x3390,  N,  N,  N),
+	PINGROUP(sdmmc3_cmd_pa7,         SDMMC3,     PWM3,       UARTA,        SPI3,        SDMMC3,     0x3394,  N,  N,  N),
+	PINGROUP(sdmmc3_dat0_pb7,        SDMMC3,     RSVD2,      RSVD3,        SPI3,        SDMMC3,     0x3398,  N,  N,  N),
+	PINGROUP(sdmmc3_dat1_pb6,        SDMMC3,     PWM2,       UARTA,        SPI3,        SDMMC3,     0x339c,  N,  N,  N),
+	PINGROUP(sdmmc3_dat2_pb5,        SDMMC3,     PWM1,       DISPLAYA,     SPI3,        SDMMC3,     0x33a0,  N,  N,  N),
+	PINGROUP(sdmmc3_dat3_pb4,        SDMMC3,     PWM0,       DISPLAYB,     SPI3,        SDMMC3,     0x33a4,  N,  N,  N),
+	PINGROUP(pex_l0_rst_n_pdd1,      PE0,        RSVD2,      RSVD3,        RSVD4,       PE0,        0x33bc,  N,  N,  N),
+	PINGROUP(pex_l0_clkreq_n_pdd2,   PE0,        RSVD2,      RSVD3,        RSVD4,       PE0,        0x33c0,  N,  N,  N),
+	PINGROUP(pex_wake_n_pdd3,        PE,         RSVD2,      RSVD3,        RSVD4,       PE,         0x33c4,  N,  N,  N),
+	PINGROUP(pex_l1_rst_n_pdd5,      PE1,        RSVD2,      RSVD3,        RSVD4,       PE1,        0x33cc,  N,  N,  N),
+	PINGROUP(pex_l1_clkreq_n_pdd6,   PE1,        RSVD2,      RSVD3,        RSVD4,       PE1,        0x33d0,  N,  N,  N),
+	PINGROUP(hdmi_cec_pee3,          CEC,        RSVD2,      RSVD3,        RSVD4,       CEC,        0x33e0,  Y,  N,  N),
+	PINGROUP(sdmmc1_wp_n_pv3,        SDMMC1,     CLK12,      SPI4,         UARTA,       SDMMC1,     0x33e4,  N,  N,  N),
+	PINGROUP(sdmmc3_cd_n_pv2,        SDMMC3,     OWR,        RSVD3,        RSVD4,       SDMMC3,     0x33e8,  N,  N,  N),
+	PINGROUP(gpio_w2_aud_pw2,        SPI6,       RSVD2,      SPI2,         I2C1,        RSVD2,      0x33ec,  N,  N,  N),
+	PINGROUP(gpio_w3_aud_pw3,        SPI6,       SPI1,       SPI2,         I2C1,        SPI1,       0x33f0,  N,  N,  N),
+	PINGROUP(usb_vbus_en0_pn4,       USB,        RSVD2,      RSVD3,        RSVD4,       USB,        0x33f4,  Y,  N,  N),
+	PINGROUP(usb_vbus_en1_pn5,       USB,        RSVD2,      RSVD3,        RSVD4,       USB,        0x33f8,  Y,  N,  N),
+	PINGROUP(sdmmc3_clk_lb_out_pee4, SDMMC3,     RSVD2,      RSVD3,        RSVD4,       SDMMC3,     0x33fc,  N,  N,  N),
+	PINGROUP(sdmmc3_clk_lb_in_pee5,  SDMMC3,     RSVD2,      RSVD3,        RSVD4,       SDMMC3,     0x3400,  N,  N,  N),
+	PINGROUP(gmi_clk_lb,             SDMMC2,     RSVD2,      GMI,          RSVD4,       SDMMC2,     0x3404,  N,  N,  N),
+	PINGROUP(reset_out_n,            RSVD1,      RSVD2,      RSVD3,        RESET_OUT_N, RSVD1,      0x3408,  N,  N,  N),
+	PINGROUP(kb_row16_pt0,           KBC,        RSVD2,      RSVD3,        UARTC,       KBC,        0x340c,  N,  N,  N),
+	PINGROUP(kb_row17_pt1,           KBC,        RSVD2,      RSVD3,        UARTC,       KBC,        0x3410,  N,  N,  N),
+	PINGROUP(usb_vbus_en2_pff1,      USB,        RSVD2,      RSVD3,        RSVD4,       USB,        0x3414,  Y,  N,  N),
+	PINGROUP(pff2,                   SATA,       RSVD2,      RSVD3,        RSVD4,       RSVD2,      0x3418,  Y,  N,  N),
+	PINGROUP(dp_hpd_pff0,            DP,         RSVD2,      RSVD3,        RSVD4,       DP,         0x3430,  N,  N,  N),
 
 	/* pg_name, r, hsm_b, schmitt_b, lpmd_b, drvdn_b, drvdn_w, drvup_b, drvup_w, slwr_b, slwr_w, slwf_b, slwf_w, drvtype */
-	DRV_PINGROUP(ao1,   0x868,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(ao2,   0x86c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(at1,   0x870,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(at2,   0x874,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(at3,   0x878,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(at4,   0x87c,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(at5,   0x880,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(cdev1, 0x884,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(cdev2, 0x888,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dap1,  0x890,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dap2,  0x894,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dap3,  0x898,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dap4,  0x89c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dbg,   0x8a0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(sdio3, 0x8b0,  2,  3, -1,  12,  7,  20,  7,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(spi,   0x8b4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(uaa,   0x8b8,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(uab,   0x8bc,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(uart2, 0x8c0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(uart3, 0x8c4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(sdio1, 0x8ec,  2,  3, -1,  12,  7,  20,  7,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(ddc,   0x8fc,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(gma,   0x900,  2,  3,  4,  14,  5,  20,  5,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(gme,   0x910,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(gmf,   0x914,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(gmg,   0x918,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(gmh,   0x91c,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(owr,   0x920,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(uda,   0x924,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(gpv,   0x928,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(dev3,  0x92c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(cec,   0x938,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(at6,   0x994,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
-	DRV_PINGROUP(dap5,  0x998,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(usb_vbus_en,  0x99c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(ao3,   0x9a8,  2,  3,  4,  12,  5,  -1,  -1,  28,  2,  -1,  -1,  N),
-	DRV_PINGROUP(ao0,   0x9b0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(hv0,   0x9b4,  2,  3,  4,  12,  5,  -1,  -1,  28,  2,  -1,  -1,  N),
-	DRV_PINGROUP(sdio4, 0x9c4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
-	DRV_PINGROUP(ao4,   0x9c8,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(ao1,         0x868,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(ao2,         0x86c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(at1,         0x870,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(at2,         0x874,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(at3,         0x878,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(at4,         0x87c,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(at5,         0x880,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(cdev1,       0x884,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(cdev2,       0x888,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dap1,        0x890,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dap2,        0x894,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dap3,        0x898,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dap4,        0x89c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dbg,         0x8a0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(sdio3,       0x8b0,  2,  3, -1,  12,  7,  20,  7,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(spi,         0x8b4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(uaa,         0x8b8,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(uab,         0x8bc,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(uart2,       0x8c0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(uart3,       0x8c4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(sdio1,       0x8ec,  2,  3, -1,  12,  7,  20,  7,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(ddc,         0x8fc,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(gma,         0x900,  2,  3,  4,  14,  5,  20,  5,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(gme,         0x910,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(gmf,         0x914,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(gmg,         0x918,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(gmh,         0x91c,  2,  3,  4,  14,  5,  19,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(owr,         0x920,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(uda,         0x924,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(gpv,         0x928,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(dev3,        0x92c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(cec,         0x938,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(at6,         0x994,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
+	DRV_PINGROUP(dap5,        0x998,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(usb_vbus_en, 0x99c,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(ao3,         0x9a8,  2,  3,  4,  12,  5,  -1, -1,  28,  2,  -1, -1,  N),
+	DRV_PINGROUP(ao0,         0x9b0,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(hv0,         0x9b4,  2,  3,  4,  12,  5,  -1, -1,  28,  2,  -1, -1,  N),
+	DRV_PINGROUP(sdio4,       0x9c4,  2,  3,  4,  12,  5,  20,  5,  28,  2,  30,  2,  N),
+	DRV_PINGROUP(ao4,         0x9c8,  2,  3,  4,  12,  7,  20,  7,  28,  2,  30,  2,  Y),
 };
 
 static const struct tegra_pinctrl_soc_data tegra124_pinctrl = {
Signature · 1 line
1.8.4.2

A message that is not in the archive (sent off-list or not yet received): 1386330839-30559-2-git-send-email-treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org

#21 lore raw

Re: [PATCH 2/2] pinctrl: tegra: Whitespace fixes for Tegra124

Quoted 4 lines · Thierry Reding

This removes some inconsistencies in the formatting of tables and macros and makes the code match that of the Tegra114 driver more closely.

I'd like Stephen to review this and supply his ACK if he thinks it's worthwhile to do these whitespace fixes.

Yours,
Linus Walleij

A message that is not in the archive (sent off-list or not yet received): CACRpkdYKqDgRkuQ4j6AeD+YWkh8r1hPCgjy1k90vQ2w+4vPxxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#23 lore raw

Re: [PATCH 2/2] pinctrl: tegra: Whitespace fixes for Tegra124

Quoted 11 lines · Linus Walleij
Quoted 4 lines · Thierry Reding

This removes some inconsistencies in the formatting of tables and macros and makes the code match that of the Tegra114 driver more closely.

I'd like Stephen to review this and supply his ACK if he thinks it's worthwhile to do these whitespace fixes.

I have sent the V3 patches to roll all these changes in single patch main change + these 2 changes. Stephen has ACKed and Tested the V3. So it is ready for your review :-).

Thanks,
Laxman

#24 lore raw

Re: [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes

In reply to a message not in the archive
Quoted 7 lines · Thierry Reding

Remove various gratuitous blank lines and other minor whitespace and style cleanups. Add some missing commas within group arrays to prevent the compiler from concatenating the strings. Remove unneeded TEGRA_MUX_SAFE entry from enumeration and drop gratuitous _dt suffix from tegra_mux enumeration type name. Drop an unwarranted FIXME comment and rename gmi_ad8_ph0 pin to ph0 since that's how it's referenced in the DS06472001 datasheet.

Thierry, I assume this patch is against the version I have in my local development branch?

I'm expecting Laxman to roll this into the patches he posts, and send a new complete version to LinusW, so there's no upstream action required for this patch series at present, just an action for Laxman.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#26 lore raw

Re: [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes

Quoted 11 lines · Stephen Warren
Quoted 7 lines · Thierry Reding

Remove various gratuitous blank lines and other minor whitespace and style cleanups. Add some missing commas within group arrays to prevent the compiler from concatenating the strings. Remove unneeded TEGRA_MUX_SAFE entry from enumeration and drop gratuitous _dt suffix from tegra_mux enumeration type name. Drop an unwarranted FIXME comment and rename gmi_ad8_ph0 pin to ph0 since that's how it's referenced in the DS06472001 datasheet.

Thierry, I assume this patch is against the version I have in my local development branch?

No, those changes were rebased on top of the patches that Laxman sent yesterday.

Quoted 3 lines

I'm expecting Laxman to roll this into the patches he posts, and send a new complete version to LinusW, so there's no upstream action required for this patch series at present, just an action for Laxman.

Yes, those were meant for Laxman to squash into his patch and resent. I should have said so.

Thierry

#27 lore raw

Re: [PATCH 1/2] pinctrl: tegra: Various Tegra124 fixes

In reply to a message not in the archive
Quoted 9 lines · Thierry Reding

Remove various gratuitous blank lines and other minor whitespace and style cleanups. Add some missing commas within group arrays to prevent the compiler from concatenating the strings. Remove unneeded TEGRA_MUX_SAFE entry from enumeration and drop gratuitous _dt suffix from tegra_mux enumeration type name. Drop an unwarranted FIXME comment and rename gmi_ad8_ph0 pin to ph0 since that's how it's referenced in the DS06472001 datasheet.

Holding this patch off expecting it to be squashed into the driver submission as stated in follow-up mails.

Yours,
Linus Walleij