Skip to contentSkip to conversation

uwb: Use dev_is_pci() to check whether it is pci device

PATCH In review Yijing Wang 1 participant 1 message Dec 5, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 uwb: Use dev_is_pci() to check whether it is pci device

Use PCI standard marco dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device.

---
 drivers/uwb/umc-bus.c   |    2 +-
 include/linux/uwb/umc.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/uwb/umc-bus.c +1 -1
index e3ed6ff..88a290f 100644
@@ -85,7 +85,7 @@ int umc_match_pci_id(struct umc_driver *umc_drv, struct umc_dev *umc)
 	const struct pci_device_id *id_table = umc_drv->match_data;
 	struct pci_dev *pci;
 
-	if (umc->dev.parent->bus != &pci_bus_type)
+	if (!dev_is_pci(umc->dev.parent))
 		return 0;
 
 	pci = to_pci_dev(umc->dev.parent);
include/linux/uwb/umc.h +1 -1
index 891d1d5..ba82f03 100644
@@ -143,7 +143,7 @@ int umc_match_pci_id(struct umc_driver *umc_drv, struct umc_dev *umc);
 static inline struct pci_dev *umc_parent_pci_dev(struct umc_dev *umc_dev)
 {
 	struct pci_dev *pci_dev = NULL;
-	if (umc_dev->dev.parent->bus == &pci_bus_type)
+	if (dev_is_pci(umc_dev->dev.parent))
 		pci_dev = to_pci_dev(umc_dev->dev.parent);
 	return pci_dev;
 }
Signature · 1 line
1.7.1