ARM: dts: mxs: Add 18bit pin config for lcdif.
Subsystems (5)
PATCH 1/3 ARM: dts: mxs: Add 18bit pin config for lcdif.
--- arch/arm/boot/dts/imx28.dtsi | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
arch/arm/boot/dts/imx28.dtsi +27 -0
@@ -668,6 +668,33 @@ fsl,pull-up = <MXS_PULL_DISABLE>; }; + lcdif_18bit_pins_a: lcdif-18bit at 0 { + reg = <0>; + fsl,pinmux-ids = < + MX28_PAD_LCD_D00__LCD_D0 + MX28_PAD_LCD_D01__LCD_D1 + MX28_PAD_LCD_D02__LCD_D2 + MX28_PAD_LCD_D03__LCD_D3 + MX28_PAD_LCD_D04__LCD_D4 + MX28_PAD_LCD_D05__LCD_D5 + MX28_PAD_LCD_D06__LCD_D6 + MX28_PAD_LCD_D07__LCD_D7 + MX28_PAD_LCD_D08__LCD_D8 + MX28_PAD_LCD_D09__LCD_D9 + MX28_PAD_LCD_D10__LCD_D10 + MX28_PAD_LCD_D11__LCD_D11 + MX28_PAD_LCD_D12__LCD_D12 + MX28_PAD_LCD_D13__LCD_D13 + MX28_PAD_LCD_D14__LCD_D14 + MX28_PAD_LCD_D15__LCD_D15 + MX28_PAD_LCD_D16__LCD_D16 + MX28_PAD_LCD_D17__LCD_D17 + >; + fsl,drive-strength = <MXS_DRIVE_4mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + lcdif_16bit_pins_a: lcdif-16bit at 0 { reg = <0>; fsl,pinmux-ids = <
Signature · 1 line
1.7.9.5
PATCH 2/3 ARM: dts: mxs: Add a new pin config for the usb0 ID.
--- arch/arm/boot/dts/imx28.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)
arch/arm/boot/dts/imx28.dtsi +11 -0
@@ -822,6 +822,17 @@ fsl,voltage = <MXS_VOLTAGE_HIGH>; fsl,pull-up = <MXS_PULL_ENABLE>; }; + + usb0_id_pins_b: usb0id1 at 0 { + reg = <0>; + fsl,pinmux-ids = < + MX28_PAD_PWM2__USB0_ID + >; + fsl,drive-strength = <MXS_DRIVE_12mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_ENABLE>; + }; + }; digctl: digctl at 8001c000 {
Signature · 1 line
1.7.9.5
PATCH 3/3 Add support for the eukrea-cpuimx28.
In reply to Denis CarikliFrom: Eric B?nard <[email protected]>
The following devices/functionalities were tested:
* Main UART.
* Ethernet0.
* Ethernet1.
* SD.
* USB host.
* USB otg.
* Display(and its backlight).
* Touchscreen.
* Audio.
* nand.
* i2c and the pcf8563 device.
* The gpio buttons.
* The gpio leds.
* Watchdog
--- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts | 71 ++++++ arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts | 50 ++++ arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi | 326 ++++++++++++++++++++++++++ arch/arm/mach-mxs/mach-mxs.c | 8 + 5 files changed, 457 insertions(+) create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi
arch/arm/boot/dts/Makefile +2 -0
@@ -178,6 +178,8 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \ imx28-cfa10057.dtb \ imx28-cfa10058.dtb \ imx28-duckbill.dtb \ + imx28-eukrea-mbmx283lc.dtb \ + imx28-eukrea-mbmx287lc.dtb \ imx28-evk.dtb \ imx28-m28cu3.dtb \ imx28-m28evk.dtb \
arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts new file +71 -0
71 lines not on this page · raw message
arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts new file +50 -0
50 lines not on this page · raw message
arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi new file +326 -0
326 lines not on this page · raw message
arch/arm/mach-mxs/mach-mxs.c +8 -0
@@ -448,6 +448,12 @@ static int __init mxs_restart_init(void)return 0 ; } +static void __init eukrea_mbmx283lc_init (void ) +{ +enable_clk_enet_out (); +mxs_saif_clkmux_select (MXS_DIGCTL_SAIF_CLKMUX_EXTMSTR0 ); +} +static void __init mxs_machine_init (void ) {struct device_node *root;
@@ -486,6 +492,8 @@ static void __init mxs_machine_init(void)apx4devkit_init (); else if (of_machine_is_compatible("crystalfontz,cfa10036")) crystalfontz_init(); + else if (of_machine_is_compatible("eukrea,mbmx283lc")) + eukrea_mbmx283lc_init(); else if (of_machine_is_compatible("i2se,duckbill")) duckbill_init(); else if (of_machine_is_compatible("msr,m28cu3"))
Signature · 1 line
1.7.9.5
PATCH 3/3 Add support for the eukrea-cpuimx28.
Quoted 1 line · Denis Carikli
From: Eric B?nard <[email protected]>
Please have a proper prefix for patch subject.
Quoted 37 lines
The following devices/functionalities were tested:
* Main UART.
* Ethernet0.
* Ethernet1.
* SD.
* USB host.
* USB otg.
* Display(and its backlight).
* Touchscreen.
* Audio.
* nand.
* i2c and the pcf8563 device.
* The gpio buttons.
* The gpio leds.
* WatchdogCc Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Stephen Warren <[email protected]>Cc Ian Campbell <[email protected]>Cc devicetree at vger.kernel.orgCc linux-arm-kernel at lists.infradead.orgCc Shawn Guo <[email protected]>Signed-off-by Eric B?nard <[email protected]>Signed-off-by Denis Carikli <[email protected]>--- arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts | 71 ++++++ arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts | 50 ++++ arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi | 326 ++++++++++++++++++++++++++ arch/arm/mach-mxs/mach-mxs.c | 8 + 5 files changed, 457 insertions(+) create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx283lc.dts create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx287lc.dts create mode 100644 arch/arm/boot/dts/imx28-eukrea-mbmx28lc.dtsi
<snip>
arch/arm/mach-mxs/mach-mxs.c static int __init mxs_restart_init(void) · line 453
Quoted 11 lines
arch/arm/mach-mxs/mach-mxs.c +3
-0@@ -448,6 +448,12 @@ static int __init mxs_restart_init(void)return 0 ; } +static void __init eukrea_mbmx283lc_init (void ) +{ +enable_clk_enet_out ();
This shouldn't be needed since commit daa7d39 (net: freescale: fec: add support for optional enet_out clk) and commit (f231a9f ARM: dts: mxs:
add enet_out clock to devicetree)
Shawn
Quoted 18 lines
arch/arm/mach-mxs/mach-mxs.c +5
-0+mxs_saif_clkmux_select (MXS_DIGCTL_SAIF_CLKMUX_EXTMSTR0 ); +} +static void __init mxs_machine_init (void ) {struct device_node *root;@@ -486,6 +492,8 @@ static void __init mxs_machine_init(void)apx4devkit_init (); else if (of_machine_is_compatible("crystalfontz,cfa10036")) crystalfontz_init(); + else if (of_machine_is_compatible("eukrea,mbmx283lc")) + eukrea_mbmx283lc_init(); else if (of_machine_is_compatible("i2se,duckbill")) duckbill_init(); else if (of_machine_is_compatible("msr,m28cu3"))Signature · 1 line
1.7.9.5
PATCH 3/3 Add support for the eukrea-cpuimx28.
Quoted 8 lines · Shawn Guo
Quoted 8 lines
arch/arm/mach-mxs/mach-mxs.c +0
-0@@ -448,6 +448,12 @@ static int __init mxs_restart_init(void)return 0 ; }
Quoted 7 lines
arch/arm/mach-mxs/mach-mxs.c static int __init mxs_restart_init(void) · line 453
Quoted 3 lines
arch/arm/mach-mxs/mach-mxs.c +3
-0+static void __init eukrea_mbmx283lc_init (void ) +{ +enable_clk_enet_out ();This shouldn't be needed since commit daa7d39 (net: freescale: fec: add support for optional
enet_outclk) and commit (f231a9f ARM: dts: mxs:
addenet_outclock to devicetree)
I just fixed it up and apply the patch. Please test it and report back if it does not work for you.
Shawn
PATCH 1/3 ARM: dts: mxs: Add 18bit pin config for lcdif.
In reply to Denis CarikliQuoted 10 lines · Denis Carikli
Cc Rob Herring <[email protected]>Cc Pawel Moll <[email protected]>Cc Mark Rutland <[email protected]>Cc Stephen Warren <[email protected]>Cc Ian Campbell <[email protected]>Cc devicetree at vger.kernel.orgCc linux-arm-kernel at lists.infradead.orgCc Shawn Guo <[email protected]>Cc Eric B?nard <[email protected]>Signed-off-by Denis Carikli <[email protected]>
Applied #1 and #2.
Shawn
Quoted 45 lines
--- arch/arm/boot/dts/imx28.dtsi | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)arch/arm/boot/dts/imx28.dtsi +27
-0@@ -668,6 +668,33 @@ fsl,pull-up = <MXS_PULL_DISABLE>; }; + lcdif_18bit_pins_a: lcdif-18bit at 0 { + reg = <0>; + fsl,pinmux-ids = < + MX28_PAD_LCD_D00__LCD_D0 + MX28_PAD_LCD_D01__LCD_D1 + MX28_PAD_LCD_D02__LCD_D2 + MX28_PAD_LCD_D03__LCD_D3 + MX28_PAD_LCD_D04__LCD_D4 + MX28_PAD_LCD_D05__LCD_D5 + MX28_PAD_LCD_D06__LCD_D6 + MX28_PAD_LCD_D07__LCD_D7 + MX28_PAD_LCD_D08__LCD_D8 + MX28_PAD_LCD_D09__LCD_D9 + MX28_PAD_LCD_D10__LCD_D10 + MX28_PAD_LCD_D11__LCD_D11 + MX28_PAD_LCD_D12__LCD_D12 + MX28_PAD_LCD_D13__LCD_D13 + MX28_PAD_LCD_D14__LCD_D14 + MX28_PAD_LCD_D15__LCD_D15 + MX28_PAD_LCD_D16__LCD_D16 + MX28_PAD_LCD_D17__LCD_D17 + >; + fsl,drive-strength = <MXS_DRIVE_4mA>; + fsl,voltage = <MXS_VOLTAGE_HIGH>; + fsl,pull-up = <MXS_PULL_DISABLE>; + }; + lcdif_16bit_pins_a: lcdif-16bit at 0 { reg = <0>; fsl,pinmux-ids = <Signature · 1 line
1.7.9.5