fetch2/git: Add sanity check to ensure we really did fetch the correct revisions
PATCH 1/1 fetch2/git: Add sanity check to ensure we really did fetch the correct revisions
The fetcher made the rather bold assumption that if it fetched from the upstream, the revisions were present and correct. These checks are fast and ensure that really is the case. The avoids accidental network accessed and missing branch configuration problems.
Signed-off-by Richard Purdie <[email protected]>
---
bitbake/lib/bb/fetch2/git.py +3 -0
@@ -213,6 +213,9 @@ class Git(FetchMethod): runfetchcmd("%s prune-packed" % ud.basecmd, d) runfetchcmd("%s pack-redundant --all | xargs -r rm" % ud.basecmd, d) ud.repochanged = True + for name in ud.names: + if not self._contains_ref(ud.revisions[name], ud.branches[name], d): + raise bb.fetch2.FetchError("Unable to find revision %s in branch %s even from upstream" % (ud.revisions[name], ud.branches[name])) def build_mirror_data(self, ud, d): # Generate a mirror tarball if needed