usb: fix controller-PHY binding for OMAP3 platform
Subsystems (6)
v2 cover usb: fix controller-PHY binding for OMAP3 platform
After the platform devices are created using PLATFORM_DEVID_AUTO, the device names given in usb_bind_phy (in board file) does not match with the actual device name causing the USB PHY library not to return the PHY reference when the MUSB controller request for the PHY in the non-dt boot case.
So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c.
Changes from v1:
* refreshed to the latested mainline kernel
* added musb_put_id from omap2430 remove.
Kishon Vijay Abraham I (2):
usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
arm: omap: remove *.auto* from device names given in usb_bind_phy
arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- drivers/usb/musb/musb_core.c | 31 +++++++++++++++++++++++++++- drivers/usb/musb/musb_core.h | 2 ++ drivers/usb/musb/omap2430.c | 19 +++++++++++++++-- 15 files changed, 61 insertions(+), 15 deletions(-)
Signature · 1 line
1.7.10.4
PATCH v2 1/2 usb: musb: omap: remove using PLATFORM_DEVID_AUTO in omap2430.c
After the platform devices are created using PLATFORM_DEVID_AUTO, the device names given in usb_bind_phy (in board file) does not match with the actual device name causing the USB PHY library not to return the PHY reference when the MUSB controller request for the PHY in the non-dt boot case.
So removed creating platform devices using PLATFORM_DEVID_AUTO in omap2430.c. This is also needed for the Generic PHY Framework.
--- drivers/usb/musb/musb_core.c | 31 ++++++++++++++++++++++++++++++- drivers/usb/musb/musb_core.h | 2 ++ drivers/usb/musb/omap2430.c | 19 +++++++++++++++++-- 3 files changed, 49 insertions(+), 3 deletions(-)
drivers/usb/musb/musb_core.c +30 -1
@@ -94,6 +94,7 @@#include <linux/sched.h> #include <linux/slab.h> #include <linux/init.h> +#include <linux/idr.h> #include <linux/list.h> #include <linux/kobject.h> #include <linux/prefetch.h>
@@ -120,7 +121,7 @@ MODULE_DESCRIPTION(DRIVER_INFO);MODULE_AUTHOR (DRIVER_AUTHOR );MODULE_LICENSE ("GPL" );MODULE_ALIAS ("platform:" MUSB_DRIVER_NAME ); - +static DEFINE_IDA (musb_ida);/*-------------------------------------------------------------------------*/
@@ -131,6 +132,34 @@ static inline struct musb *dev_to_musb(struct device *dev)/*-------------------------------------------------------------------------*/ +int musb_get_id (struct device *dev,gfp_t gfp_mask) +{ +int ret; +int id; + + ret =ida_pre_get (&musb_ida, gfp_mask); +if (!ret) { +dev_err (dev,"failed to reserve resource for id\n" ); +return -ENOMEM ; + } + + ret =ida_get_new (&musb_ida, &id); +if (ret <0 ) { +dev_err (dev,"failed to allocate a new id\n" ); +return ret; + } + +return id; +} +EXPORT_SYMBOL_GPL (musb_get_id); + +void musb_put_id (struct device *dev,int id) +{ +dev_dbg (dev,"removing id %d\n" , id); +ida_remove (&musb_ida, id); +} +EXPORT_SYMBOL_GPL (musb_put_id); +#ifndef CONFIG_BLACKFIN static int musb_ulpi_read (struct usb_phy *phy,u32 offset) {
drivers/usb/musb/musb_core.h +2 -0
@@ -506,6 +506,8 @@ extern const char musb_driver_name[];extern void musb_stop (struct musb *musb);extern void musb_start (struct musb *musb); +int musb_get_id (struct device *dev,gfp_t gfp_mask); +void musb_put_id (struct device *dev,int id);extern void musb_write_fifo (struct musb_hw_ep *ep,u16 len,const u8 *src);extern void musb_read_fifo (struct musb_hw_ep *ep,u16 len,u8 *dst);
drivers/usb/musb/omap2430.c +17 -2
@@ -45,6 +45,7 @@struct omap2430_glue {struct device *dev; +int id;struct platform_device *musb;enum omap_musb_vbus_id_status status;struct work_struct omap_musb_mailbox_work;
@@ -508,6 +509,7 @@ static int omap2430_probe(struct platform_device *pdev)struct device_node *np = pdev->dev.of_node;struct musb_hdrc_config *config;int ret = -ENOMEM ; +int musbid; glue =devm_kzalloc (&pdev->dev,sizeof (*glue),GFP_KERNEL );if (!glue) {
@@ -515,10 +517,18 @@ static int omap2430_probe(struct platform_device *pdev) goto err0; } - musb =platform_device_alloc ("musb-hdrc" ,PLATFORM_DEVID_AUTO ); +/* get the musb id */ + musbid =musb_get_id (&pdev->dev,GFP_KERNEL ); +if (musbid <0 ) { +dev_err (&pdev->dev,"failed to allocate musb id\n" ); + ret = -ENOMEM ; + goto err0; + } + + musb =platform_device_alloc ("musb-hdrc" , musbid);if (!musb) {dev_err (&pdev->dev,"failed to allocate musb device\n" ); - goto err0; + goto err1; } musb->dev.parent = &pdev->dev;
@@ -528,6 +538,7 @@ static int omap2430_probe(struct platform_device *pdev) glue->dev = &pdev->dev; glue->musb = musb; glue->status =OMAP_MUSB_UNKNOWN ; + glue->id = musbid; glue->control_otghs =ERR_PTR (-ENODEV );if (np) {
@@ -633,6 +644,9 @@ static int omap2430_probe(struct platform_device *pdev) err2:platform_device_put (musb); +err1: +musb_put_id (&pdev->dev, musbid); + err0:return ret; }
@@ -643,6 +657,7 @@ static int omap2430_remove(struct platform_device *pdev)cancel_work_sync (&glue->omap_musb_mailbox_work);platform_device_unregister (glue->musb); +musb_put_id (&pdev->dev, glue->id);return 0 ; }
Signature · 1 line
1.7.10.4
PATCH v2 2/2 arm: omap: remove *.auto* from device names given in usb_bind_phy
In reply to Kishon Vijay Abraham IPreviously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the device name of the controller had *.auto* in it. Since with using PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, the data given in usb_bind_phy became obsolete and usb_get_phy was failing. So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding change is done in board file here.
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)
arch/arm/mach-omap2/board-2430sdp.c +1 -1
@@ -246,7 +246,7 @@ static void __init omap_2430sdp_init(void)omap_hsmmc_init (mmc);omap_mux_init_signal ("usb0hs_stp" ,OMAP_PULL_ENA |OMAP_PULL_UP ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );board_smc91x_init ();
arch/arm/mach-omap2/board-3430sdp.c +1 -1
@@ -607,7 +607,7 @@ static void __init omap_3430sdp_init(void)omap_ads7846_init (1 , gpio_pendown,310 ,NULL );omap_serial_init ();omap_sdrc_init (hyb18m512160af6_sdrc_params,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );board_smc91x_init ();board_flash_init (sdp_flash_partitions, chip_sel_3430,0 );
arch/arm/mach-omap2/board-cm-t35.c +1 -1
@@ -725,7 +725,7 @@ static void __init cm_t3x_common_init(void)cm_t35_init_display ();omap_twl4030_audio_init ("cm-t3x" ,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );cm_t35_init_usbh ();cm_t35_init_camera ();
arch/arm/mach-omap2/board-devkit8000.c +1 -1
@@ -628,7 +628,7 @@ static void __init devkit8000_init(void)omap_ads7846_init (2 ,OMAP3_DEVKIT_TS_GPIO ,0 ,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );usbhs_init (&usbhs_bdata); board_nand_init(devkit8000_nand_partitions,
arch/arm/mach-omap2/board-ldp.c +1 -1
@@ -402,7 +402,7 @@ static void __init omap_ldp_init(void)omap_ads7846_init (1 ,54 ,310 ,NULL );omap_serial_init ();omap_sdrc_init (NULL ,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );board_nand_init (ldp_nand_partitions,ARRAY_SIZE (ldp_nand_partitions),0 ,0 , nand_default_timings);
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
@@ -561,7 +561,7 @@ static void __init omap3_beagle_init(void)omap_sdrc_init (mt46h32m32lf6_sdrc_params, mt46h32m32lf6_sdrc_params); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );usbhs_init (&usbhs_bdata);
arch/arm/mach-omap2/board-omap3logic.c +1 -1
@@ -216,7 +216,7 @@ static void __init omap3logic_init(void)board_mmc_init ();board_smsc911x_init (); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );/* Ensure SDRC pins are mux'd for self-refresh */
arch/arm/mach-omap2/board-omap3pandora.c +1 -1
@@ -607,7 +607,7 @@ static void __init omap3pandora_init(void)usbhs_init_phys (phy_data,ARRAY_SIZE (phy_data));usbhs_init (&usbhs_bdata); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );gpmc_nand_init (&pandora_nand_data,NULL );
arch/arm/mach-omap2/board-omap3stalker.c +1 -1
@@ -407,7 +407,7 @@ static void __init omap3_stalker_init(void)omap_serial_init ();omap_sdrc_init (mt46h32m32lf6_sdrc_params,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );usbhs_init_phys (phy_data,ARRAY_SIZE (phy_data));
arch/arm/mach-omap2/board-omap3touchbook.c +1 -1
@@ -367,7 +367,7 @@ static void __init omap3_touchbook_init(void)/* Touchscreen and accelerometer */ omap_ads7846_init (4 ,OMAP3_TS_GPIO ,310 , &ads7846_pdata); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );usbhs_init_phys (phy_data,ARRAY_SIZE (phy_data));
arch/arm/mach-omap2/board-overo.c +1 -1
@@ -511,7 +511,7 @@ static void __init overo_init(void) mt46h32m32lf6_sdrc_params);board_nand_init (overo_nand_partitions,ARRAY_SIZE (overo_nand_partitions),NAND_CS ,0 ,NULL ); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (NULL );usbhs_init_phys (phy_data,ARRAY_SIZE (phy_data));
arch/arm/mach-omap2/board-rx51.c +1 -1
@@ -103,7 +103,7 @@ static void __init rx51_init(void) sdrc_params =nokia_get_sdram_timings ();omap_sdrc_init (sdrc_params, sdrc_params); -usb_bind_phy ("musb-hdrc.0.auto" ,0 ,"twl4030_usb" ); +usb_bind_phy ("musb-hdrc.0" ,0 ,"twl4030_usb" );usb_musb_init (&musb_board_data);rx51_peripherals_init ();
Signature · 1 line
1.7.10.4
Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Hi Kishon,
Quoted 9 lines · Kishon Vijay Abraham I
Previously MUSB wrapper (OMAP) device used
PLATFORM_DEVID_AUTOwhile creating MUSB core device. So inusb_bind_phy(binds the controller with the PHY), the device name of the controller had *.auto* in it. Since with usingPLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, the data given inusb_bind_phybecame obsolete andusb_get_phywas failing. So MUSB wrapper was modified not to usePLATFORM_DEVID_AUTO. Corresponding change is done in board file here.Signed-off-by Kishon Vijay Abraham I <[email protected]>
Quoted 15 lines
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)
You can drop this patch since boards files are being removed for v3.14
Thanks a lot and best regards,
Javier
Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Hi,
Quoted 26 lines · Javier Martinez Canillas
Quoted 9 lines · Kishon Vijay Abraham I
Previously MUSB wrapper (OMAP) device used
PLATFORM_DEVID_AUTOwhile creating MUSB core device. So inusb_bind_phy(binds the controller with the PHY), the device name of the controller had *.auto* in it. Since with usingPLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, the data given inusb_bind_phybecame obsolete andusb_get_phywas failing. So MUSB wrapper was modified not to usePLATFORM_DEVID_AUTO. Corresponding change is done in board file here.Signed-off-by Kishon Vijay Abraham I <[email protected]>Quoted 15 lines
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)
Quoted 1 line
You can drop this patch since boards files are being removed for v3.14
if we can drop this patch, the whole series is invalid, since we'll be using DT phandles to find PHYs going forward, no ?
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131206/25469874/attachment.sig>
Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Hi,
Quoted 29 lines · Felipe Balbi
Hi,
Quoted 26 lines · Javier Martinez Canillas
Quoted 24 lines · Kishon Vijay Abraham I
Previously MUSB wrapper (OMAP) device used
PLATFORM_DEVID_AUTOwhile creating MUSB core device. So inusb_bind_phy(binds the controller with the PHY), the device name of the controller had *.auto* in it. Since with usingPLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance, the data given inusb_bind_phybecame obsolete andusb_get_phywas failing. So MUSB wrapper was modified not to usePLATFORM_DEVID_AUTO. Corresponding change is done in board file here.Signed-off-by Kishon Vijay Abraham I <[email protected]>--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)
Quoted 5 lines
Quoted 1 line
You can drop this patch since boards files are being removed for v3.14
if we can drop this patch, the whole series is invalid, since we'll be using DT phandles to find PHYs going forward, no ?
yeah. But in one of the other threads, Tony seemed ok to take a patch that fixes the same issue in mach-omap2/twl-common.c. So it's better to confirm with Tony.
Thanks
Kishon
Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Hi Kishon,
Quoted 45 lines · Kishon Vijay Abraham I
Hi,
Quoted 41 lines · Felipe Balbi
Hi,
Quoted 35 lines · Javier Martinez Canillas
Quoted 15 lines · Kishon Vijay Abraham I
Previously MUSB wrapper (OMAP) device used
PLATFORM_DEVID_AUTOwhile creating
MUSB core device. So inusb_bind_phy(binds the controller with the PHY), the
device name of the controller had *.auto* in it. Since with usingPLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance,
the data given inusb_bind_phybecame obsolete andusb_get_phywas failing.
So MUSB wrapper was modified not to usePLATFORM_DEVID_AUTO. Corresponding
change is done in board file here.Signed-off-by Kishon Vijay Abraham I <[email protected]>Quoted 15 lines
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)You can drop this patch since boards files are being removed for v3.14
Quoted 7 lines
Quoted 3 lines
if we can drop this patch, the whole series is invalid, since we'll be using DT phandles to find PHYs going forward, no ?
yeah. But in one of the other threads, Tony seemed ok to take a patch that fixes the same issue in
mach-omap2/twl-common.c. So it's better to confirm with Tony.
Yes, I just read the other thread ("[PATCH] omap: twl-common: Fix musb-hdrc device name") and I see that these patches are fixing a v3.13 regression and are meant for the -rc cycle and not for v3.14.
Sorry for the noise then.
Best regards,
Javier
Quoted 2 lines
Thanks
Kishon
Tony Lindgren
maintainerRe: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind_phy
Quoted 51 lines · Javier Martinez Canillas
Hi Kishon,
Quoted 48 lines · Kishon Vijay Abraham I
Hi,
Quoted 44 lines · Felipe Balbi
Hi,
Quoted 34 lines · Javier Martinez Canillas
Quoted 15 lines · Kishon Vijay Abraham I
Previously MUSB wrapper (OMAP) device used
PLATFORM_DEVID_AUTOwhile creating
MUSB core device. So inusb_bind_phy(binds the controller with the PHY), the
device name of the controller had *.auto* in it. Since with usingPLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance,
the data given inusb_bind_phybecame obsolete andusb_get_phywas failing.
So MUSB wrapper was modified not to usePLATFORM_DEVID_AUTO. Corresponding
change is done in board file here.Signed-off-by Kishon Vijay Abraham I <[email protected]>Quoted 15 lines
--- arch/arm/mach-omap2/board-2430sdp.c | 2 +- arch/arm/mach-omap2/board-3430sdp.c | 2 +- arch/arm/mach-omap2/board-cm-t35.c | 2 +- arch/arm/mach-omap2/board-devkit8000.c | 2 +- arch/arm/mach-omap2/board-ldp.c | 2 +- arch/arm/mach-omap2/board-omap3beagle.c | 2 +- arch/arm/mach-omap2/board-omap3logic.c | 2 +- arch/arm/mach-omap2/board-omap3pandora.c | 2 +- arch/arm/mach-omap2/board-omap3stalker.c | 2 +- arch/arm/mach-omap2/board-omap3touchbook.c | 2 +- arch/arm/mach-omap2/board-overo.c | 2 +- arch/arm/mach-omap2/board-rx51.c | 2 +- 12 files changed, 12 insertions(+), 12 deletions(-)Quoted 1 line
You can drop this patch since boards files are being removed for v3.14
if we can drop this patch, the whole series is invalid, since we'll be using DT phandles to find PHYs going forward, no ?
Quoted 8 lines
Quoted 4 lines
yeah. But in one of the other threads, Tony seemed ok to take a patch that fixes the same issue in
mach-omap2/twl-common.c. So it's better to confirm with Tony.Yes, I just read the other thread ("[PATCH] omap: twl-common: Fix musb-hdrc device name") and I see that these patches are fixing a v3.13 regression and are meant for the -rc cycle and not for v3.14.
Sorry guys, I'm a bit lost with these USB regression fixes. Which regression fix do we need for v3.13-rc series?
If there's an option, I'd rather not touch all the board-*.c files as those are about to get dropped for v3.14.
Regards,
Tony