ARM64: dts: Add clock-frequency to model cpu nodes
PATCH 1/1 ARM64: dts: Add clock-frequency to model cpu nodes
From: Mark Brown <[email protected]>
The clock-frequency property is meaningless for the models but it's a mandatory property so claim that all the cores run at 1MHz.
--- arch/arm64/boot/dts/foundation-v8.dts | 4 ++++ arch/arm64/boot/dts/rtsm_ve-aemv8a.dts | 4 ++++ 2 files changed, 8 insertions(+)
arch/arm64/boot/dts/foundation-v8.dts +4 -0
@@ -34,6 +34,7 @@ reg = <0x0 0x0>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 1 { device_type = "cpu";
@@ -41,6 +42,7 @@ reg = <0x0 0x1>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 2 { device_type = "cpu";
@@ -48,6 +50,7 @@ reg = <0x0 0x2>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 3 { device_type = "cpu";
@@ -55,6 +58,7 @@ reg = <0x0 0x3>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; };
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts +4 -0
@@ -37,6 +37,7 @@ reg = <0x0 0x0>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 1 { device_type = "cpu";
@@ -44,6 +45,7 @@ reg = <0x0 0x1>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 2 { device_type = "cpu";
@@ -51,6 +53,7 @@ reg = <0x0 0x2>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 3 { device_type = "cpu";
@@ -58,6 +61,7 @@ reg = <0x0 0x3>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; };
Signature · 1 line
1.8.5.1
PATCH 1/1 ARM64: dts: Add clock-frequency to model cpu nodes
Quoted 4 lines · Mark Brown
From: Mark Brown <[email protected]>
The clock-frequency property is meaningless for the models but it's a mandatory property so claim that all the cores run at 1MHz.
Is it a mandatory property? I know we seem to get ugly warnings if it's missing but I see no mention of it at all in Documentation/devicetree/bindings/arm/cpus.txt (am I looking in the wrong place?)
I think this attribute got merged into the kernel with the early power related scheduling efforts, but given the state of all that at the moment I was guessing it might be obsolete.
-- Tixy
Quoted 78 lines
Signed-off-by Mark Brown <[email protected]>--- arch/arm64/boot/dts/foundation-v8.dts | 4 ++++ arch/arm64/boot/dts/rtsm_ve-aemv8a.dts | 4 ++++ 2 files changed, 8 insertions(+)arch/arm64/boot/dts/foundation-v8.dts +4
-0@@ -34,6 +34,7 @@ reg = <0x0 0x0>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 1 { device_type = "cpu";@@ -41,6 +42,7 @@ reg = <0x0 0x1>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 2 { device_type = "cpu";@@ -48,6 +50,7 @@ reg = <0x0 0x2>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 3 { device_type = "cpu";@@ -55,6 +58,7 @@ reg = <0x0 0x3>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; };arch/arm64/boot/dts/rtsm_ve-aemv8a.dts +4
-0@@ -37,6 +37,7 @@ reg = <0x0 0x0>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 1 { device_type = "cpu";@@ -44,6 +45,7 @@ reg = <0x0 0x1>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 2 { device_type = "cpu";@@ -51,6 +53,7 @@ reg = <0x0 0x2>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; cpu at 3 { device_type = "cpu";@@ -58,6 +61,7 @@ reg = <0x0 0x3>; enable-method = "spin-table"; cpu-release-addr = <0x0 0x8000fff8>; + clock-frequency = <1000000>; }; };
PATCH 1/1 ARM64: dts: Add clock-frequency to model cpu nodes
Quoted 9 lines · Jon Medhurst (Tixy)
Quoted 2 lines · Mark Brown
The clock-frequency property is meaningless for the models but it's a mandatory property so claim that all the cores run at 1MHz.
Is it a mandatory property? I know we seem to get ugly warnings if it's missing but I see no mention of it at all in
Documentation/devicetree/bindings/arm/cpus.txt(am I looking in the wrong place?)
It's mandatory according to ePAPR (see my separate patch copying the definition into our copy of the binding documents).
Quoted 3 lines
I think this attribute got merged into the kernel with the early power related scheduling efforts, but given the state of all that at the moment I was guessing it might be obsolete.
No, it's still being used. At the minute mainline should in theory
balance tasks well enough between the cores when they're all enabled, it
just won't figure out that it's useful to shut one of the clusters down.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131209/eb3a6602/attachment-0001.sig>