mfd: mc13xxx: Remove redundant checks
PATCH 1/1 mfd: mc13xxx: Remove redundant checks
Checking for maximal register is already provided by regmap API, so remove redundant checks.
Signed-off-by Alexander Shiyan <[email protected]>
--- drivers/mfd/mc13xxx-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mfd/mc13xxx-core.c +1 -4
@@ -158,9 +158,6 @@ int mc13xxx_reg_read(struct mc13xxx *mc13xxx, unsigned int offset, u32 *val) {int ret; -if (offset >MC13XXX_NUMREGS ) -return -EINVAL ; - ret =regmap_read (mc13xxx->regmap, offset, val);dev_vdbg (mc13xxx->dev,"[0x%02x] -> 0x%06x\n" , offset, *val);
@@ -172,7 +169,7 @@ int mc13xxx_reg_write(struct mc13xxx *mc13xxx, unsigned int offset, u32 val) {dev_vdbg (mc13xxx->dev,"[0x%02x] <- 0x%06x\n" , offset, val); -if (offset >MC13XXX_NUMREGS || val >0xffffff ) +if (val >=BIT (24 ))return -EINVAL ;return regmap_write (mc13xxx->regmap, offset, val);
Signature · 1 line
1.8.3.2
Lee Jones
AppliedQuoted 7 lines
Checking for maximal register is already provided by regmap API, so remove redundant checks.
Signed-off-by Alexander Shiyan <[email protected]>--- drivers/mfd/mc13xxx-core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Applied, thanks.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog