Skip to contentSkip to conversation

mfd: mc13xxx: Remove redundant checks

PATCH Applied Alexander Shiyan 2 participants 2 messages Dec 7, 2013 – Dec 9, 2013 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: mc13xxx: Remove redundant checks

Checking for maximal register is already provided by regmap API, so remove redundant checks.

---
 drivers/mfd/mc13xxx-core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/mfd/mc13xxx-core.c +1 -4
index dbbf8ee..b0c7cb0 100644
@@ -158,9 +158,6 @@ int mc13xxx_reg_read(struct mc13xxx *mc13xxx, unsigned int offset, u32 *val)
 {
 	int ret;
 
-	if (offset > MC13XXX_NUMREGS)
-		return -EINVAL;
-
 	ret = regmap_read(mc13xxx->regmap, offset, val);
 	dev_vdbg(mc13xxx->dev, "[0x%02x] -> 0x%06x\n", offset, *val);
 
@@ -172,7 +169,7 @@ int mc13xxx_reg_write(struct mc13xxx *mc13xxx, unsigned int offset, u32 val)
 {
 	dev_vdbg(mc13xxx->dev, "[0x%02x] <- 0x%06x\n", offset, val);
 
-	if (offset > MC13XXX_NUMREGS || val > 0xffffff)
+	if (val >= BIT(24))
 		return -EINVAL;
 
 	return regmap_write(mc13xxx->regmap, offset, val);
Signature · 1 line
1.8.3.2
Applied
#1 lore raw
Quoted 7 lines

Checking for maximal register is already provided by regmap API, so remove redundant checks.

---
 drivers/mfd/mc13xxx-core.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog