rtc: rtc-cmos: Remove superfluous name cast
Subsystems (2)
Geert Uytterhoeven
maintainerPATCH 1/3 rtc: rtc-cmos: Remove superfluous name cast
device_driver.name is "const char *"
--- drivers/rtc/rtc-cmos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-cmos.c +1 -1
@@ -1127,7 +1127,7 @@ static struct platform_driver cmos_platform_driver = { .remove = __exit_p(cmos_platform_remove), .shutdown = cmos_platform_shutdown, .driver = { - .name = (char *) driver_name, + .name = driver_name,#ifdef CONFIG_PM .pm = &cmos_pm_ops,#endif
Signature · 1 line
1.7.9.5
Geert Uytterhoeven
maintainerPATCH 2/3 m68k/atari: Hide RTC_PORT() macro from rtc-cmos
Rename RTC_PORT() to ATARI_RTC_PORT(), as the rtc-cmos RTC driver uses the presence of this macro to enable support for the second NVRAM bank, which Atari doesn't have ("Unable to handle kernel access at virtual address 00ff8965").
--- arch/m68k/include/asm/mc146818rtc.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/m68k/include/asm/mc146818rtc.h +5 -5
@@ -10,16 +10,16 @@#include <asm/atarihw.h> -#define RTC_PORT (x) (TT_RTC_BAS + 2*(x)) +#define ATARI_RTC_PORT (x) (TT_RTC_BAS + 2*(x))#define RTC_ALWAYS_BCD 0#define CMOS_READ (addr) ({ \ -atari_outb_p((addr),RTC_PORT(0)); \ -atari_inb_p(RTC_PORT(1)); \ +atari_outb_p((addr), ATARI_RTC_PORT(0)); \ +atari_inb_p(ATARI_RTC_PORT(1)); \ })#define CMOS_WRITE (val, addr) ({ \ -atari_outb_p((addr),RTC_PORT(0)); \ -atari_outb_p((val),RTC_PORT(1)); \ +atari_outb_p((addr), ATARI_RTC_PORT(0)); \ +atari_outb_p((val), ATARI_RTC_PORT(1)); \ })#endif /* CONFIG_ATARI */
Signature · 1 line
1.7.9.5
Geert Uytterhoeven
maintainerPATCH 3/3 rtc: Disable RTC_DRV_CMOS on Atari
In reply to Geert UytterhoevenOn ARAnyM (emulating an Atari Falcon, which doesn't have an RTC IRQ, as the Second Multi Function Peripheral MFP 68901 is available on Atari TT only), rtc-cmos doesn't work well:
- The date is of by 32 years (2045 instead of 2013):
rtc_cmos rtc_cmos: setting system clock to 2045-12-02 10:56:17 UTC (2395824977)
- The hwclock utility doesn't work:
hwclock: ioctl() to /dev/rtc to turn on update interrupts failed unexpectedly, errno=5: Input/output error.
As rtc-generic works fine for the RTC part, and nvram works for the NVRAM part, we'll continue on using that.
--- drivers/rtc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/Kconfig +1 -1
@@ -626,7 +626,7 @@ comment "Platform RTC drivers" config RTC_DRV_CMOS tristate "PC-style 'CMOS'" - depends on X86 || ARM || M32R || ATARI || PPC || MIPS || SPARC64 + depends on X86 || ARM || M32R || PPC || MIPS || SPARC64 default y if X86 help Say "yes" here to get direct support for the real time clock
Signature · 1 line
1.7.9.5