fix strict boot regression
cover fix strict boot regression
parsing of "strict" is wrongly removed, we need it. The first patch fixes a typo.
Amos Kong (2):
fix a typo of strict option
add parsing of "strict" boot parameter
pc-bios/bios.bin | Bin 131072 -> 131072 bytes vl.c | 3 ++- 2 files changed, 2 insertions(+), 1 deletions(-)
PATCH 1/2 fix a typo of strict option
The type of "strict" should be bool.
--- vl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
vl.c +1 -1
@@ -461,7 +461,7 @@ static QemuOptsList qemu_boot_opts = { .type = QEMU_OPT_STRING, }, { .name = "strict", - .type = QEMU_OPT_STRING, + .type = QEMU_OPT_BOOL, }, {/*End of list */ } },
Signature · 1 line
1.7.1
PATCH 2/2 add parsing of "strict" boot parameter
In reply to Amos KongCommit 6ef4716cecdfa1b3794c1a33edba9840e1aa6b5f cleaned up the parse code of boot parameter, parse code of "strict" wasn't re-implemented, it caused that strict boot feature is always disabled.
--- pc-bios/bios.bin | Bin 131072 -> 131072 bytes vl.c | 1 + 2 files changed, 1 insertions(+), 0 deletions(-)
pc-bios/bios.bin binary +0 -0
vl.c +1 -0
@@ -4074,6 +4074,7 @@ int main(int argc, char **argv, char **envp) } boot_menu =qemu_opt_get_bool (opts,"menu" , boot_menu); + boot_strict =qemu_opt_get_bool (opts,"strict" , false); }if (!kernel_cmdline) {
Signature · 1 line
1.7.1
Re: [Qemu-devel] [PATCH 2/2] add parsing of "strict" boot parameter
09.12.2013 11:51, Amos Kong пишет:
Quoted 9 lines
Commit
6ef4716cecdfa1b3794c1a33edba9840e1aa6b5fcleaned up the parse code of boot parameter, parse code of "strict" wasn't re-implemented, it caused that strict boot feature is always disabled.Signed-off-by Amos Kong <[email protected]>--- pc-bios/bios.bin | Bin 131072 -> 131072 bytes vl.c | 1 +
Did you really mean to patch bios.bin too, not only vl.c?
Note that kraxel requested a "bios split" patch to be pulled too, so now we should have bios-128k.bin and bios-256k.bin, but no bios.bin.
Thanks,
/mjt