Skip to contentSkip to conversation

xen/debugfs: Check debugfs initialization before using it

PATCH Superseded Ethan Zhao 1 participant 2 messages Dec 9, 2013

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Ethan Zhao

author
#0 lore raw

PATCH v2 1/1 xen/debugfs: Check debugfs initialization before using it

From: "Ethan Zhao" <[email protected]>

Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

V2: change to normative author name.

---
 arch/x86/xen/debugfs.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/xen/debugfs.c +6 -0
index c8377fb..85c0e0e 100644
@@ -9,12 +9,18 @@ static struct dentry *d_xen_debug;
 
 struct dentry * __init xen_init_debugfs(void)
 {
+	if (!debugfs_initialized()) {
+		d_xen_debug = NULL;
+		goto nodebugfs;
+	}
+
 	if (!d_xen_debug) {
 		d_xen_debug = debugfs_create_dir("xen", NULL);
 
 		if (!d_xen_debug)
 			pr_warning("Could not create 'xen' debugfs directory\n");
 	}
+nodebugfs:
 
 	return d_xen_debug;
 }
Signature · 1 line
1.8.3.4 (Apple Git-47)
author
#1 lore raw

All,
Please ignore this one, sorry, see v3.

Thanks,
Ethan

Quoted 39 lines · Ethan Zhao

From: "Ethan Zhao" <[email protected]>

Should check debugfs initialization with debugfs_initialized() before using it, Because if it isn't initialized, the return value of fake debugfs_create_dir() etc functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

V2: change to normative author name.

---
 arch/x86/xen/debugfs.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/x86/xen/debugfs.c +6 -1
index c8377fb..85c0e0e 100644
@@ -9,12 +9,18 @@ static struct dentry *d_xen_debug;
 
 struct dentry * __init xen_init_debugfs(void)
 {
+       if (!debugfs_initialized()) {
+               d_xen_debug = NULL;
+               goto nodebugfs;
+       }
+
        if (!d_xen_debug) {
                d_xen_debug = debugfs_create_dir("xen", NULL);
 
                if (!d_xen_debug)
                        pr_warning("Could not create 'xen' debugfs directory\n");
        }
+nodebugfs:
 
        return d_xen_debug;
 }
--

1.8.3.4 (Apple Git-47)