Skip to contentSkip to conversation

xinetd_tests.sh: explicitly enable IPv6

PATCH In review Simon Xu 3 participants 5 messages Dec 11, 2013 – Feb 10, 2014

lore
Share & tools
lore

Simon Xu

author
#0 lore raw

PATCH 1/1 xinetd_tests.sh: explicitly enable IPv6

Explicitly enable IPv6 because on older systems xinetd only listens on IPv4 by default.

Signed-off-by Simon Xu <[email protected]>
---
 testcases/network/xinetd/xinetd_tests.sh | 1 +
 1 file changed, 1 insertion(+)
testcases/network/xinetd/xinetd_tests.sh +1 -0
index 5024280..dac23a8 100755
@@ -134,6 +134,7 @@ service telnet
     server          = /usr/sbin/in.telnetd
     server_args     = -n
     no_access       =
+    flags           = IPv6
 }
 EOF
 RC=$?
Signature · 13 lines
1.8.4.2


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
author
#1 lore raw

Could anyone help to review this?

Thanks
Simon

Quoted 13 lines · Simon Xu

Explicitly enable IPv6 because on older systems xinetd only listens on IPv4 by default.

Signed-off-by Simon Xu <[email protected]>
---
  testcases/network/xinetd/xinetd_tests.sh | 1 +
  1 file changed, 1 insertion(+)
testcases/network/xinetd/xinetd_tests.sh +0 -0
index 5024280..dac23a8 100755

testcases/network/xinetd/xinetd_tests.sh service telnet · line 140

Quoted 7 lines
testcases/network/xinetd/xinetd_tests.sh +1 -0
@@ -134,6 +134,7 @@ service telnet
      server          = /usr/sbin/in.telnetd
      server_args     = -n
      no_access       =
+    flags           = IPv6
  }
  EOF
  RC=$?

------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#2 lore raw

Could anyone help to review this?

Thanks
Simon

Quoted 14 lines · Simon Xu

Could anyone help to review this?

Thanks
Simon

Quoted 8 lines · Simon Xu

Explicitly enable IPv6 because on older systems xinetd only listens on IPv4 by default.

Signed-off-by Simon Xu <[email protected]>
---
   testcases/network/xinetd/xinetd_tests.sh | 1 +
   1 file changed, 1 insertion(+)
Quoted 12 lines

testcases/network/xinetd/xinetd_tests.sh service telnet · line 140

Quoted 12 lines
testcases/network/xinetd/xinetd_tests.sh +1 -0
index 5024280..dac23a8 100755
@@ -134,6 +134,7 @@ service telnet
       server          = /usr/sbin/in.telnetd
       server_args     = -n
       no_access       =
+    flags           = IPv6
   }
   EOF
   RC=$?

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reviewed-by
#3 lore raw

----- Original Message -----

Quoted 5 lines

From: "Simon Xu" <[email protected]>
To: [email protected]
Sent: Tuesday, 21 January, 2014 2:43:22 AM
Subject: Re: [LTP] [PATCH] xinetd_tests.sh: explicitly enable IPv6

Quoted 16 lines

Could anyone help to review this?

Thanks
Simon

Quoted 10 lines · Simon Xu

Could anyone help to review this?

Thanks
Simon

Quoted 4 lines · Simon Xu

Explicitly enable IPv6 because on older systems xinetd only listens on IPv4 by default.

Signed-off-by Simon Xu <[email protected]>

Hi,

Looks good to me. According to [1] it's supported since around 1.8.9, which appears to be older than anything I could find in RHEL distros.

Reviewed-by Jan Stancek <[email protected]>

[1] http://www.tldp.org/HOWTO/Linux%2BIPv6-HOWTO/hints-daemons-xinetd.html

Regards,
Jan

Quoted 20 lines
Quoted 4 lines
Quoted 4 lines
---
   testcases/network/xinetd/xinetd_tests.sh | 1 +
   1 file changed, 1 insertion(+)
Quoted 13 lines

testcases/network/xinetd/xinetd_tests.sh service telnet · line 140

Quoted 13 lines
testcases/network/xinetd/xinetd_tests.sh +1 -0
index 5024280..dac23a8 100755
@@ -134,6 +134,7 @@ service telnet
       server          = /usr/sbin/in.telnetd
       server_args     = -n
       no_access       =
+    flags           = IPv6
   }
   EOF
   RC=$?

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.

Quoted 9 lines

Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#4 lore raw

Hi!

Quoted 6 lines

Looks good to me. According to [1] it's supported since around 1.8.9, which appears to be older than anything I could find in RHEL distros.

Reviewed-by Jan Stancek <[email protected]>

[1] http://www.tldp.org/HOWTO/Linux%2BIPv6-HOWTO/hints-daemons-xinetd.html

Pushed, thanks.

Signature · 13 lines
Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Android&trade; apps run on BlackBerry&reg;10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience.  Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list