Skip to contentSkip to conversation

sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

PATCH In review Ethan Zhao 2 participants 5 messages Dec 11, 2013 – Jan 7, 2014 SPARC + UltraSPARC (sparc/sparc64)

lore
Share & tools
lore

Ethan Zhao

author
#0 lore raw

PATCH 1/1 sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()

Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever.

---
 arch/sparc/kernel/mdesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sparc/kernel/mdesc.c +1 -1
index b90bf23..e8d678c 100644
@@ -136,7 +136,7 @@ static struct mdesc_handle *mdesc_kmalloc(unsigned int mdesc_size)
 		       sizeof(struct mdesc_hdr) +
 		       mdesc_size);
 
-	base = kmalloc(handle_size + 15, GFP_KERNEL | __GFP_NOFAIL);
+	base = kmalloc(handle_size + 15, GFP_KERNEL | GFP_ATOMIC);
 	if (base) {
 		struct mdesc_handle *hp;
 		unsigned long addr;
Signature · 1 line
1.8.3.4 (Apple Git-47)
author
#2 lore raw

David,
Got it. thanks,

Ethan

Quoted 10 lines · David Miller

From: Ethan Zhao <[email protected]>
Date: Wed, 11 Dec 2013 22:54:21 +0800

Quoted 4 lines

Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever.

Please submit sparc patches with [email protected] at least CC:'d.

author
#3 lore raw
In reply to Ethan Zhao

cc [email protected]

Quoted 24 lines · Ethan Zhao

Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever.

---
 arch/sparc/kernel/mdesc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sparc/kernel/mdesc.c +1 -2
index b90bf23..e8d678c 100644
@@ -136,7 +136,7 @@ static struct mdesc_handle *mdesc_kmalloc(unsigned int mdesc_size)
                       sizeof(struct mdesc_hdr) +
                       mdesc_size);
 
-       base = kmalloc(handle_size + 15, GFP_KERNEL | __GFP_NOFAIL);
+       base = kmalloc(handle_size + 15, GFP_KERNEL | GFP_ATOMIC);
        if (base) {
                struct mdesc_handle *hp;
                unsigned long addr;
--

1.8.3.4 (Apple Git-47)