sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()
PATCH 1/1 sparc: replace __GFP_NOFAIL with GFP_ATOMIC in mdesc_kmalloc()
Has kmalloc() failure checking there, so it is unnecessary to allocate with __GFP_NOFAIL flag that might block forever.
--- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/sparc/kernel/mdesc.c +1 -1
@@ -136,7 +136,7 @@ static struct mdesc_handle *mdesc_kmalloc(unsigned int mdesc_size)sizeof (struct mdesc_hdr ) + mdesc_size); - base =kmalloc (handle_size +15 ,GFP_KERNEL | __GFP_NOFAIL); + base =kmalloc (handle_size +15 ,GFP_KERNEL |GFP_ATOMIC );if (base) {struct mdesc_handle *hp;unsigned long addr;
Signature · 1 line
1.8.3.4 (Apple Git-47)
David Miller
maintainerFrom: Ethan Zhao <[email protected]>
Date: Wed, 11 Dec 2013 22:54:21 +0800
Quoted 4 lines
Has
kmalloc()failure checking there, so it is unnecessary to allocate with__GFP_NOFAILflag that might block forever.Signed-off-by Ethan Zhao <[email protected]>
Please submit sparc patches with [email protected] at least CC:'d.
David,
Got it. thanks,
Ethan
Quoted 10 lines · David Miller
From: Ethan Zhao <[email protected]>
Date: Wed, 11 Dec 2013 22:54:21 +0800Quoted 4 lines
Has
kmalloc()failure checking there, so it is unnecessary to allocate with__GFP_NOFAILflag that might block forever.Signed-off-by Ethan Zhao <[email protected]>Please submit sparc patches with [email protected] at least CC:'d.
Quoted 24 lines · Ethan Zhao
Has
kmalloc()failure checking there, so it is unnecessary to allocate with__GFP_NOFAILflag that might block forever.Signed-off-by Ethan Zhao <[email protected]>--- arch/sparc/kernel/mdesc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/sparc/kernel/mdesc.c +1
-2@@ -136,7 +136,7 @@ static struct mdesc_handle *mdesc_kmalloc(unsigned int mdesc_size)sizeof (struct mdesc_hdr ) + mdesc_size); - base =kmalloc (handle_size +15 ,GFP_KERNEL | __GFP_NOFAIL); + base =kmalloc (handle_size +15 ,GFP_KERNEL |GFP_ATOMIC );if (base) {struct mdesc_handle *hp;unsigned long addr; --1.8.3.4 (Apple Git-47)
David Miller
maintainerFrom: Ethan Zhao <[email protected]>
Date: Tue, 7 Jan 2014 10:21:51 +0800
Quoted 1 line
Please make a fresh patch posting with sparclinux included so that your patch gets properly queued up and tracked in patchwork:
http://patchwork.ozlabs.org/project/sparclinux/list/
Thanks.