Skip to contentSkip to conversation

cpufreq: Make ARM big.LITTLE switcher depend on ARM

PATCH In review Mark Brown 3 participants 5 messages Dec 11, 2013 – Dec 22, 2013 CPU frequency scaling framework

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/2 cpufreq: Make ARM big.LITTLE switcher depend on ARM

From: Mark Brown <[email protected]>

The patch currently under review to enable ARM cpufreq drivers for ARM64 which is useful due to the large amount of shared IP between ARM and ARM64 SoCs. However the big.LITTLE switcher relies on an architecture interface to build which is not present on ARM64. Add a dependency until that is resolved.

---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +1 -1
index ce52ed949249..0a141109fd29 100644
@@ -4,7 +4,7 @@
 
 config ARM_BIG_LITTLE_CPUFREQ
 	tristate "Generic ARM big LITTLE CPUfreq driver"
-	depends on ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK
+	depends on ARM && ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK
 	help
 	  This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
 
Signature · 1 line
1.8.5.1
author
#1 lore raw

PATCH 2/2 cpufreq: Select PM_OPP rather than depending on it

From: Mark Brown <[email protected]>

PM_OPP is a helper library used by several of the existing cpufreq drivers. Some of the drivers select this symbol while others depend on it and rely on the architecture to enable it. Make this behaviour more consistent and obvious by having all the drivers select the symbol. This will also allow better build coverage of the affected drivers.

---
 drivers/cpufreq/Kconfig     | 3 ++-
 drivers/cpufreq/Kconfig.arm | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/cpufreq/Kconfig +2 -1
index e26fdcd14165..6947fdfca57c 100644
@@ -181,7 +181,8 @@ config CPU_FREQ_GOV_CONSERVATIVE
 
 config GENERIC_CPUFREQ_CPU0
 	tristate "Generic CPU0 cpufreq driver"
-	depends on HAVE_CLK && REGULATOR && PM_OPP && OF
+	depends on HAVE_CLK && REGULATOR && OF
+	select PM_OPP
 	help
 	  This adds a generic cpufreq driver for CPU0 frequency management.
 	  It supports both uniprocessor (UP) and symmetric multiprocessor (SMP)
drivers/cpufreq/Kconfig.arm +4 -2
index 0a141109fd29..456ba5e1781c 100644
@@ -4,7 +4,8 @@
 
 config ARM_BIG_LITTLE_CPUFREQ
 	tristate "Generic ARM big LITTLE CPUfreq driver"
-	depends on ARM && ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK
+	depends on ARM && ARM_CPU_TOPOLOGY && HAVE_CLK
+	select PM_OPP
 	help
 	  This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
 
@@ -54,7 +55,8 @@ config ARM_EXYNOS5250_CPUFREQ
 config ARM_EXYNOS5440_CPUFREQ
 	bool "SAMSUNG EXYNOS5440"
 	depends on SOC_EXYNOS5440
-	depends on HAVE_CLK && PM_OPP && OF
+	depends on HAVE_CLK && OF
+	select PM_OPP
 	default y
 	help
 	  This adds the CPUFreq driver for Samsung EXYNOS5440
Signature · 1 line
1.8.5.1
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] cpufreq: Select PM_OPP rather than depending on it

Quoted 8 lines · Mark Brown

From: Mark Brown <[email protected]>

PM_OPP is a helper library used by several of the existing cpufreq drivers. Some of the drivers select this symbol while others depend on it and rely on the architecture to enable it. Make this behaviour more consistent and obvious by having all the drivers select the symbol. This will also allow better build coverage of the affected drivers.

Quoted 5 lines
---
 drivers/cpufreq/Kconfig     | 3 ++-
 drivers/cpufreq/Kconfig.arm | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)
maintainer Acked-by on v1 1/2
#3 lore raw
In reply to Mark Brown
Quoted 8 lines · Mark Brown

From: Mark Brown <[email protected]>

The patch currently under review to enable ARM cpufreq drivers for ARM64 which is useful due to the large amount of shared IP between ARM and ARM64 SoCs. However the big.LITTLE switcher relies on an architecture interface to build which is not present on ARM64. Add a dependency until that is resolved.

Quoted 4 lines
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#4 lore raw
In reply to Mark Brown
Quoted 9 lines · Mark Brown

From: Mark Brown <[email protected]>

The patch currently under review to enable ARM cpufreq drivers for ARM64 which is useful due to the large amount of shared IP between ARM and ARM64 SoCs. However the big.LITTLE switcher relies on an architecture interface to build which is not present on ARM64. Add a dependency until that is resolved.

Both [1-2/2] queued up for 3.14, thanks!

Quoted 18 lines
---
 drivers/cpufreq/Kconfig.arm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/Kconfig.arm +1 -1
index ce52ed949249..0a141109fd29 100644
@@ -4,7 +4,7 @@
 
 config ARM_BIG_LITTLE_CPUFREQ
 	tristate "Generic ARM big LITTLE CPUfreq driver"
-	depends on ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK
+	depends on ARM && ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK
 	help
 	  This enables the Generic CPUfreq driver for ARM big.LITTLE platforms.
 
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.