Skip to contentSkip to conversation

video: amba-clcd: Make CLCD driver available on more platforms

PATCH In review Mark Brown 4 participants 7 messages Dec 12, 2013 – Jan 10, 2014 Framebuffer layer

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 video: amba-clcd: Make CLCD driver available on more platforms

From: Mark Brown <[email protected]>

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64 to the list of dependencies. The driver also has no build time dependencies on ARM (stubs are provided for ARM-specific DMA functions in the code) so make it available with COMPILE_TEST in order to maximise build coverage.

---
 drivers/video/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/Kconfig +2 -1
index 4f2e1b35eb38..e6c7fb1a389b 100644
@@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
 
 config FB_ARMCLCD
 	tristate "ARM PrimeCell PL110 support"
-	depends on FB && ARM && ARM_AMBA
+	depends on ARM || ARM64 || COMPILE_TEST
+	depends on FB && ARM_AMBA
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
Signature · 1 line
1.8.5.1
#1 lore raw
Quoted 15 lines · Mark Brown

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64 to the list of dependencies. The driver also has no build time dependencies on ARM (stubs are provided for ARM-specific DMA functions in the code) so make it available with COMPILE_TEST in order to maximise build coverage.

---
 drivers/video/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/Kconfig +0 -0
index 4f2e1b35eb38..e6c7fb1a389b 100644

drivers/video/Kconfig config FB_PM2_FIFO_DISCONNECT · line 319

Quoted 9 lines
drivers/video/Kconfig +2 -1
@@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
 
 config FB_ARMCLCD
        tristate "ARM PrimeCell PL110 support"
-       depends on FB && ARM && ARM_AMBA
+       depends on ARM || ARM64 || COMPILE_TEST
+       depends on FB && ARM_AMBA
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT

Currently ARM_AMBA exists on arm/arm64 only.
Is there a patch in the pipeline to change that? Without such a change, this patch doesn't make any difference.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#2 lore raw
In reply to Mark Brown
Quoted 2 lines · Geert Uytterhoeven

Currently ARM_AMBA exists on arm/arm64 only.
Is there a patch in the pipeline to change that? Without such a change,

I don't know but it's plausible given how common AMBA is.

Quoted 1 line

this patch doesn't make any difference.

No, it does mean that ARM64 is included - previously the dependency was only on ARM so it wasn't available on ARM64. COMPILE_TEST won't have an impact though.

#3 lore raw
In reply to Mark Brown
Quoted 10 lines · Mark Brown
Quoted 2 lines · Geert Uytterhoeven

Currently ARM_AMBA exists on arm/arm64 only.
Is there a patch in the pipeline to change that? Without such a change,

I don't know but it's plausible given how common AMBA is.

Quoted 1 line

this patch doesn't make any difference.

No, it does mean that ARM64 is included - previously the dependency was

Sure.

Quoted 2 lines

only on ARM so it wasn't available on ARM64. COMPILE_TEST won't have an impact though.

Sorry, I meant it doesn't have any impact on COMPILE_TEST.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#4 lore raw
In reply to Mark Brown
Quoted 6 lines · Mark Brown

From: Mark Brown <[email protected]>

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64 to the list of dependencies. The driver also has no build time dependencies on ARM (stubs are provided for ARM-specific DMA functions in the code) so make it available with COMPILE_TEST in order to maximise build coverage.

I haven't followed other CLCD patches but for arm64 it requires support for DT. I have been carrying some patches (done by Linaro) for a long time and Pawel @ ARM has another set of patches. Do you know what the status for those is before enabling CLCD on arm64? That's unless you are only looking at compile-testing.

Signature · 1 line
Catalin
author
#5 lore raw
In reply to Mark Brown
Quoted 7 lines · Catalin Marinas
Quoted 4 lines · Mark Brown

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64 to the list of dependencies. The driver also has no build time dependencies on ARM (stubs are provided for ARM-specific DMA functions in the code) so make it available with COMPILE_TEST in order to maximise build coverage.

Quoted 5 lines

I haven't followed other CLCD patches but for arm64 it requires support for DT. I have been carrying some patches (done by Linaro) for a long time and Pawel @ ARM has another set of patches. Do you know what the status for those is before enabling CLCD on arm64? That's unless you are only looking at compile-testing.

Pawel's patches are going nowhere slowly as far as I can tell due to a slow feedback loop and extensive discussion of the DT bindings.

I think this patch is an orthogonal thing, though - as you say it's useful for compile testing on its own and it means the driver will load as soon as the DT bindings are supported. It's one less patch to carry out of tree and one less iteration when debugging why the framebuffer isn't supported when testing.

#6 lore raw
In reply to Mark Brown
Quoted 18 lines · Mark Brown

From: Mark Brown <[email protected]>

The CLCD driver is used on ARM reference models for ARMv8 so add ARM64 to the list of dependencies. The driver also has no build time dependencies on ARM (stubs are provided for ARM-specific DMA functions in the code) so make it available with COMPILE_TEST in order to maximise build coverage.

---
 drivers/video/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/video/Kconfig +0 -0
index 4f2e1b35eb38..e6c7fb1a389b 100644

drivers/video/Kconfig config FB_PM2_FIFO_DISCONNECT · line 319

Quoted 9 lines
drivers/video/Kconfig +2 -1
@@ -312,7 +312,8 @@ config FB_PM2_FIFO_DISCONNECT
 
 config FB_ARMCLCD
 	tristate "ARM PrimeCell PL110 support"
-	depends on FB && ARM && ARM_AMBA
+	depends on ARM || ARM64 || COMPILE_TEST
+	depends on FB && ARM_AMBA
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT

Queued for 3.14.

Tomi