Skip to contentSkip to conversation

ARM: shmobile: Add select MIGHT_HAVE_PCI for PCI-AHB bridge code

PATCH In review Ben Dooks 3 participants 7 messages Dec 12, 2013 – Dec 14, 2013

Subsystems (4)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 ARM: shmobile: Add select MIGHT_HAVE_PCI for PCI-AHB bridge code

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>
---
 arch/arm/mach-shmobile/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-shmobile/Kconfig +4 -0
index 3e57d45..010d2a6 100644
@@ -12,6 +12,7 @@ config ARCH_SHMOBILE_MULTI
 	select HAVE_SMP
 	select ARM_GIC
 	select MIGHT_HAVE_CACHE_L2X0
+	select MIGHT_HAVE_PCI
 	select NO_IOPORT
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
@@ -101,6 +102,7 @@ config ARCH_R8A7779
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select USB_ARCH_HAS_EHCI
 	select USB_ARCH_HAS_OHCI
@@ -111,6 +113,7 @@ config ARCH_R8A7790
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select RENESAS_IRQC
 
@@ -127,6 +130,7 @@ config ARCH_EMEV2
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select USE_OF
 	select AUTO_ZRELADDR
 
Signature · 1 line
1.8.5.1
#1 lore raw

Hello.

Quoted 22 lines · Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>
---
  arch/arm/mach-shmobile/Kconfig | 4 ++++
  1 file changed, 4 insertions(+)
arch/arm/mach-shmobile/Kconfig +0 -0
index 3e57d45..010d2a6 100644

[...]

arch/arm/mach-shmobile/Kconfig config ARCH_R8A7779 · line 108

Quoted 8 lines
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -101,6 +102,7 @@ config ARCH_R8A7779
  	select ARCH_WANT_OPTIONAL_GPIOLIB
  	select ARM_GIC
  	select CPU_V7
+	select MIGHT_HAVE_PCI
  	select SH_CLK_CPG
  	select USB_ARCH_HAS_EHCI
  	select USB_ARCH_HAS_OHCI

Er, this is R8A7779 section. This SoC doesn't have PCI-AHB bridge.

arch/arm/mach-shmobile/Kconfig config ARCH_R8A7790 · line 119

Quoted 8 lines
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -111,6 +113,7 @@ config ARCH_R8A7790
  	select ARCH_WANT_OPTIONAL_GPIOLIB
  	select ARM_GIC
  	select CPU_V7
+	select MIGHT_HAVE_PCI
  	select SH_CLK_CPG
  	select RENESAS_IRQC
 

R8A7791 section is contrarywise missing. BTW, there's stray letter 'c'
before that section.

WBR, Sergei

author
#2 lore raw
In reply to Ben Dooks
Quoted 39 lines · Sergei Shtylyov

Hello.

Quoted 23 lines · Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>
---
  arch/arm/mach-shmobile/Kconfig | 4 ++++
  1 file changed, 4 insertions(+)
arch/arm/mach-shmobile/Kconfig +0 -0
index 3e57d45..010d2a6 100644

[...]

arch/arm/mach-shmobile/Kconfig config ARCH_R8A7779 · line 108

Quoted 8 lines
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -101,6 +102,7 @@ config ARCH_R8A7779
      select ARCH_WANT_OPTIONAL_GPIOLIB
      select ARM_GIC
      select CPU_V7
+    select MIGHT_HAVE_PCI
      select SH_CLK_CPG
      select USB_ARCH_HAS_EHCI
      select USB_ARCH_HAS_OHCI

Er, this is R8A7779 section. This SoC doesn't have PCI-AHB bridge.

Quoted 11 lines

arch/arm/mach-shmobile/Kconfig config ARCH_R8A7790 · line 119

Quoted 8 lines
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -111,6 +113,7 @@ config ARCH_R8A7790
      select ARCH_WANT_OPTIONAL_GPIOLIB
      select ARM_GIC
      select CPU_V7
+    select MIGHT_HAVE_PCI
      select SH_CLK_CPG
      select RENESAS_IRQC
 

R8A7791 section is contrarywise missing. BTW, there's stray letter
'c' before that section.

Thanks. I've fixed the R8A7791. I cannot see the stray 'c'.

Quoted 2 lines

WBR, Sergei

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
author
#3 lore raw

PATCH 1/1 ARM: shmobile: Add select MIGHT_HAVE_PCI for PCI-AHB bridge code

In reply to Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>
---
 arch/arm/mach-shmobile/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm/mach-shmobile/Kconfig +5 -0
index 3e57d45..4dcb216 100644
@@ -12,6 +12,7 @@ config ARCH_SHMOBILE_MULTI
 	select HAVE_SMP
 	select ARM_GIC
 	select MIGHT_HAVE_CACHE_L2X0
+	select MIGHT_HAVE_PCI
 	select NO_IOPORT
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
@@ -101,6 +102,7 @@ config ARCH_R8A7779
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select USB_ARCH_HAS_EHCI
 	select USB_ARCH_HAS_OHCI
@@ -111,6 +113,7 @@ config ARCH_R8A7790
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select RENESAS_IRQC
 
@@ -119,6 +122,7 @@ config ARCH_R8A7791
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select RENESAS_IRQC
 
@@ -127,6 +131,7 @@ config ARCH_EMEV2
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select USE_OF
 	select AUTO_ZRELADDR
 
Signature · 1 line
1.8.5.1
author
#4 lore raw
In reply to Ben Dooks
Quoted 9 lines · Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Quoted 5 lines
Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>

Argh, sorry did not remove the extra Kconfig entry.

Signature · 2 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius
author
#5 lore raw

PATCH 1/1 ARM: shmobile: Add select MIGHT_HAVE_PCI for PCI-AHB bridge code

In reply to Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
CC Linux SH List <[email protected]>
---
 arch/arm/mach-shmobile/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-shmobile/Kconfig +4 -0
index 3e57d45..f01e878 100644
@@ -12,6 +12,7 @@ config ARCH_SHMOBILE_MULTI
 	select HAVE_SMP
 	select ARM_GIC
 	select MIGHT_HAVE_CACHE_L2X0
+	select MIGHT_HAVE_PCI
 	select NO_IOPORT
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
@@ -111,6 +112,7 @@ config ARCH_R8A7790
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select RENESAS_IRQC
 
@@ -119,6 +121,7 @@ config ARCH_R8A7791
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select SH_CLK_CPG
 	select RENESAS_IRQC
 
@@ -127,6 +130,7 @@ config ARCH_EMEV2
 	select ARCH_WANT_OPTIONAL_GPIOLIB
 	select ARM_GIC
 	select CPU_V7
+	select MIGHT_HAVE_PCI
 	select USE_OF
 	select AUTO_ZRELADDR
 
Signature · 1 line
1.8.5.1
#6 lore raw
In reply to Ben Dooks
Quoted 8 lines · Ben Dooks

The PCI sub-system is not enabled by default on ARM and on certain Renesas devices the build does not select it. This means that there are configurations that do not allow the AHB-PCI bridge used for the USB sub-systems to be built.

For the R8A7790, R8A7791 and EMEV-2 select MIGHT_HAVE_PCI to allow the PCI drivers to be built. Also select MIGHT_HAVE_PCI for the multi-config where there may be many Reneasas devices selected.

Thanks, I will queue this up.