Skip to contentSkip to conversation

i2c: Fix i2c speed command

PATCH New Darwin Rambo 2 participants 2 messages Dec 13, 2013 – Dec 14, 2013 I2C

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c: Fix i2c speed command

This corrects i2c core to interpret the value returned by i2c_set_bus_speed as a success indicator rather than the actual speed that was set. When i2c_set_bus_speed returns a failure code, the speed is unknown so the adapter speed is set to zero.

---
 drivers/i2c/i2c_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c_core.c +1 -1
index e1767f4..18d6736 100644
@@ -349,7 +349,7 @@ unsigned int i2c_set_bus_speed(unsigned int speed)
 		return 0;
 	ret = I2C_ADAP->set_bus_speed(I2C_ADAP, speed);
 	if (gd->flags & GD_FLG_RELOC)
-		I2C_ADAP->speed = ret;
+		I2C_ADAP->speed = (ret == 0) ? speed : 0;
 
 	return ret;
 }
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 i2c: Fix i2c speed command

Quoted 18 lines · Darwin Rambo

This corrects i2c core to interpret the value returned by i2c_set_bus_speed as a success indicator rather than the actual speed that was set. When i2c_set_bus_speed returns a failure code, the speed is unknown so the adapter speed is set to zero.

---
 drivers/i2c/i2c_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c_core.c +0 -0
index e1767f4..18d6736 100644

drivers/i2c/i2c_core.c unsigned int i2c_set_bus_speed(unsigned int speed) · line 355

Quoted 8 lines
drivers/i2c/i2c_core.c +1 -1
@@ -349,7 +349,7 @@ unsigned int i2c_set_bus_speed(unsigned int speed)
                return 0;
        ret = I2C_ADAP->set_bus_speed(I2C_ADAP, speed);
        if (gd->flags & GD_FLG_RELOC)
-               I2C_ADAP->speed = ret;
+               I2C_ADAP->speed = (ret == 0) ? speed : 0;
 
        return ret;
 }
Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki