net: inet_diag: zero out uninitialized idiag_{src,dst} fields
Subsystems (2)
PATCH 1/1 net: inet_diag: zero out uninitialized idiag_{src,dst} fields
Jakub reported while working with nlmon netlink sniffer that parts of the inet_diag_sockid are not initialized when r->idiag_family != AF_INET6. That is, fields of r->id.idiag_src[1 ... 3], r->id.idiag_dst[1 ... 3].
In fact, it seems that we can leak 6 * sizeof(u32) byte of kernel [slab] memory through this. At least, in udp_dump_one(), we allocate a skb in ...
rep = nlmsg_new(sizeof(struct inet_diag_msg) + ..., GFP_KERNEL);
... and then pass that to inet_sk_diag_fill() that puts the whole struct inet_diag_msg into the skb, where we only fill out r->id.idiag_src[0], r->id.idiag_dst[0] and leave the rest untouched:
r->id.idiag_src[0] = inet->inet_rcv_saddr; r->id.idiag_dst[0] = inet->inet_daddr;
struct inet_diag_msg embeds struct inet_diag_sockid that is correctly / fully filled out in IPv6 case, but for IPv4 not.
So just zero them out by using plain memset (for this little amount of bytes it's probably not worth the extra check for idiag_family == AF_INET).
Similarly, fix also other places where we fill that out.
--- net/ipv4/inet_diag.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
net/ipv4/inet_diag.c +16 -0
@@ -106,6 +106,10 @@ int inet_sk_diag_fill(struct sock *sk, struct inet_connection_sock *icsk, r->id.idiag_sport = inet->inet_sport; r->id.idiag_dport = inet->inet_dport; + +memset (&r->id.idiag_src,0 ,sizeof (r->id.idiag_src)); +memset (&r->id.idiag_dst,0 ,sizeof (r->id.idiag_dst)); + r->id.idiag_src[0 ] = inet->inet_rcv_saddr; r->id.idiag_dst[0 ] = inet->inet_daddr;
@@ -240,12 +244,19 @@ static int inet_twsk_diag_fill(struct inet_timewait_sock *tw, r->idiag_family = tw->tw_family; r->idiag_retrans =0 ; + r->id.idiag_if = tw->tw_bound_dev_if;sock_diag_save_cookie (tw, r->id.idiag_cookie); + r->id.idiag_sport = tw->tw_sport; r->id.idiag_dport = tw->tw_dport; + +memset (&r->id.idiag_src,0 ,sizeof (r->id.idiag_src)); +memset (&r->id.idiag_dst,0 ,sizeof (r->id.idiag_dst)); + r->id.idiag_src[0 ] = tw->tw_rcv_saddr; r->id.idiag_dst[0 ] = tw->tw_daddr; + r->idiag_state = tw->tw_substate; r->idiag_timer =3 ; r->idiag_expires =jiffies_to_msecs (tmo);
@@ -726,8 +737,13 @@ static int inet_diag_fill_req(struct sk_buff *skb, struct sock *sk, r->id.idiag_sport = inet->inet_sport; r->id.idiag_dport = ireq->ir_rmt_port; + +memset (&r->id.idiag_src,0 ,sizeof (r->id.idiag_src)); +memset (&r->id.idiag_dst,0 ,sizeof (r->id.idiag_dst)); + r->id.idiag_src[0 ] = ireq->ir_loc_addr; r->id.idiag_dst[0 ] = ireq->ir_rmt_addr; + r->idiag_expires =jiffies_to_msecs (tmo); r->idiag_rqueue =0 ; r->idiag_wqueue =0 ;
Signature · 1 line
1.8.3.1
David Miller
maintainerFrom: Daniel Borkmann <[email protected]>
Date: Tue, 17 Dec 2013 00:38:39 +0100
Quoted 19 lines
Jakub reported while working with nlmon netlink sniffer that parts of the
inet_diag_sockidare not initialized whenr->idiag_family!=AF_INET6. That is, fields of r->id.idiag_src[1 ... 3], r->id.idiag_dst[1 ... 3].In fact, it seems that we can leak 6 * sizeof(u32) byte of kernel [slab] memory through this. At least, in
udp_dump_one(), we allocate a skb in ...rep = nlmsg_new(sizeof(struct inet_diag_msg) + ..., GFP_KERNEL);... and then pass that to
inet_sk_diag_fill()that puts the whole structinet_diag_msginto the skb, where we only fill out r->id.idiag_src[0], r->id.idiag_dst[0] and leave the rest untouched:r->id.idiag_src[0] = inet->inet_rcv_saddr; r->id.idiag_dst[0] = inet->inet_daddr;struct
inet_diag_msgembeds structinet_diag_sockidthat is correctly / fully filled out in IPv6 case, but for IPv4 not.
Quoted 7 lines
So just zero them out by using plain memset (for this little amount of bytes it's probably not worth the extra check for
idiag_family==AF_INET).Similarly, fix also other places where we fill that out.
Reported-by Jakub Zawadzki <[email protected]>Signed-off-by Daniel Borkmann <[email protected]>
Applied and queued up for -stable, thanks.