Skip to contentSkip to conversation

input: Port rotary_encoder to of_property_read_bool

PATCH In review Ben Gamari 2 participants 2 messages Dec 17, 2013 – Oct 3, 2015

Subsystems (2)
lore
Share & tools
lore

Ben Gamari

author
#0 lore raw

PATCH 1/1 input: Port rotary_encoder to of_property_read_bool

---
 drivers/input/misc/rotary_encoder.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/input/misc/rotary_encoder.c +3 -6
index f920ba7..52049db 100644
@@ -175,12 +175,9 @@ static struct rotary_encoder_platform_data *rotary_encoder_parse_dt(struct devic
 	pdata->gpio_b = of_get_gpio_flags(np, 1, &flags);
 	pdata->inverted_b = flags & OF_GPIO_ACTIVE_LOW;
 
-	pdata->relative_axis = !!of_get_property(np,
-					"rotary-encoder,relative-axis", NULL);
-	pdata->rollover = !!of_get_property(np,
-					"rotary-encoder,rollover", NULL);
-	pdata->half_period = !!of_get_property(np,
-					"rotary-encoder,half-period", NULL);
+	pdata->relative_axis = of_property_read_bool(np, "rotary-encoder,relative-axis");
+	pdata->rollover = of_property_read_bool(np, "rotary-encoder,rollover");
+	pdata->half_period = of_property_read_bool(np, "rotary-encoder,half-period");
 
 	return pdata;
 }
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 25 lines · Ben Gamari
---
 drivers/input/misc/rotary_encoder.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/input/misc/rotary_encoder.c +3 -7
index f920ba7..52049db 100644
@@ -175,12 +175,9 @@ static struct rotary_encoder_platform_data *rotary_encoder_parse_dt(struct devic
        pdata->gpio_b = of_get_gpio_flags(np, 1, &flags);
        pdata->inverted_b = flags & OF_GPIO_ACTIVE_LOW;
 
-       pdata->relative_axis = !!of_get_property(np,
-                                       "rotary-encoder,relative-axis", NULL);
-       pdata->rollover = !!of_get_property(np,
-                                       "rotary-encoder,rollover", NULL);
-       pdata->half_period = !!of_get_property(np,
-                                       "rotary-encoder,half-period", NULL);
+       pdata->relative_axis = of_property_read_bool(np, "rotary-encoder,relative-axis");
+       pdata->rollover = of_property_read_bool(np, "rotary-encoder,rollover");
+       pdata->half_period = of_property_read_bool(np, "rotary-encoder,half-period");
 
        return pdata;
 }
--
Quoted 2 lines

1.8.3.2

Hm, looks like this one felt through the cracks. It applies cleanly on linux-next
and it looks fine, except the commit log is a bit off.

Ben, you should resend this one. The format is not quite right:

* needs your Signed-off-by
* needs some commit log. Something simple like "This commit is a cosmetic cleanup,
changing the driver to use of_property_read_bool to read boolean devicetree properties."
* needs a better subject "input: rotary-encoder: Use of_property_read_bool".

Feel free to add my Acked-by to it.

Thanks,

Signature · 6 lines
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html