drivers/net/hamradio: Integer overflow in hdlcdrv_ioctl()
Subsystems (2)
PATCH 1/1 drivers/net/hamradio: Integer overflow in hdlcdrv_ioctl()
The local variable 'bi' comes from userspace. If userspace passed a large number to 'bi.data.calibrate', there would be an integer overflow in the following line:
s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;
Signed-off-by Wenliang Fan <[email protected]>
--- drivers/net/hamradio/hdlcdrv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/hamradio/hdlcdrv.c +2 -0
@@ -571,6 +571,8 @@ static int hdlcdrv_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)case HDLCDRVCTL_CALIBRATE :if (!capable (CAP_SYS_RAWIO ))return -EPERM ; +if (bi.data.calibrate >INT_MAX / s->par.bitrate) +return -EINVAL ; s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate /16 ;return 0 ;
Signature · 1 line
1.8.5.rc1.28.g7061504
David Miller
maintainerFrom: Wenliang Fan <[email protected]>
Date: Tue, 17 Dec 2013 11:25:28 +0800
Quoted 6 lines
The local variable 'bi' comes from userspace. If userspace passed a large number to 'bi.data.calibrate', there would be an integer overflow in the following line:
s->hdlctx.calibrate = bi.data.calibrate * s->par.bitrate / 16;Signed-off-by Wenliang Fan <[email protected]>
Applied and queued up for -stable, thanks.