net_sched: remove unnecessary null pointer check
Subsystems (3)
cover net_sched: remove unnecessary null pointer check
Remove unnecessary null pointer check outside of qdisc_put_rtab().
Yang Yingliang (2):
act_police: remove unnecessary null pointer check
sch_cbq: remove unnecessary null pointer check
net/sched/act_police.c | 6 ++---- net/sched/sch_cbq.c | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-)
Signature · 1 line
1.8.0
PATCH 1/2 act_police: remove unnecessary null pointer check
It already has a NULL pointer check of rtab in qdisc_put_rtab(). Remove the check outside of qdisc_put_rtab().
Signed-off-by Yang Yingliang <[email protected]>
--- net/sched/act_police.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
net/sched/act_police.c +2 -4
@@ -277,10 +277,8 @@ override: failure_unlock:spin_unlock_bh (&police->tcf_lock); failure: -if (P_tab) -qdisc_put_rtab (P_tab); -if (R_tab) -qdisc_put_rtab (R_tab); +qdisc_put_rtab (P_tab); +qdisc_put_rtab (R_tab);if (ret ==ACT_P_CREATED )kfree (police);return err;
Signature · 1 line
1.8.0
PATCH 2/2 sch_cbq: remove unnecessary null pointer check
In reply to Yang YingliangIt already has a NULL pointer check of rtab in qdisc_put_rtab(). Remove the check outside of qdisc_put_rtab().
Signed-off-by Yang Yingliang <[email protected]>
--- net/sched/sch_cbq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
net/sched/sch_cbq.c +1 -2
@@ -1783,8 +1783,7 @@ cbq_change_class(struct Qdisc *sch, u32 classid, u32 parentid, struct nlattr **tqdisc_root_sleeping_lock (sch), tca[TCA_RATE]);if (err) { -if (rtab) -qdisc_put_rtab (rtab); +qdisc_put_rtab (rtab);return err; } }
Signature · 1 line
1.8.0
David Miller
maintainerFrom: Yang Yingliang <[email protected]>
Date: Tue, 17 Dec 2013 15:29:15 +0800
Quoted 1 line
Remove unnecessary null pointer check outside of
qdisc_put_rtab().
Series applied, thanks.