Skip to contentSkip to conversation

mtd: omap2: use nand_base defaults for polled I/O

PATCH In review Brian Norris 2 participants 3 messages Dec 17, 2013 – Jan 3, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: omap2: use nand_base defaults for polled I/O

The omap_{read,write}_buf{8,16}() functions are identical to the default nand_base versions. Just let nand_base assign them in the NAND_OMAP_POLLED case.

---
Compile tested only

 drivers/mtd/nand/omap2.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/mtd/nand/omap2.c +1 -7
index e9e2c37c0a80..eadc76a57f45 100644
@@ -1730,13 +1730,7 @@ static int omap_nand_probe(struct platform_device *pdev)
 		break;
 
 	case NAND_OMAP_POLLED:
-		if (nand_chip->options & NAND_BUSWIDTH_16) {
-			nand_chip->read_buf   = omap_read_buf16;
-			nand_chip->write_buf  = omap_write_buf16;
-		} else {
-			nand_chip->read_buf   = omap_read_buf8;
-			nand_chip->write_buf  = omap_write_buf8;
-		}
+		/* Use nand_base defaults for {read,write}_buf */
 		break;
 
 	case NAND_OMAP_PREFETCH_DMA:
Signature · 1 line
1.8.3.2
Tested-by on v1 1/1
#1 lore raw
Quoted 33 lines

From: Brian Norris [mailto:[email protected]]

The omap_{read,write}_buf{8,16}() functions are identical to the default nand_base versions. Just let nand_base assign them in the NAND_OMAP_POLLED case.

---
Compile tested only

drivers/mtd/nand/omap2.c | 8 +-------

1 file changed, 1 insertion(+), 7 deletions(-)
drivers/mtd/nand/omap2.c +1 -8
index e9e2c37c0a80..eadc76a57f45 100644
@@ -1730,13 +1730,7 @@ static int omap_nand_probe(struct platform_device *pdev)
 		break;
 
 	case NAND_OMAP_POLLED:
-		if (nand_chip->options & NAND_BUSWIDTH_16) {
-			nand_chip->read_buf   = omap_read_buf16;
-			nand_chip->write_buf  = omap_write_buf16;
-		} else {
-			nand_chip->read_buf   = omap_read_buf8;
-			nand_chip->write_buf  = omap_write_buf8;
-		}
+		/* Use nand_base defaults for {read,write}_buf */
 		break;
 
 	case NAND_OMAP_PREFETCH_DMA:
--
Quoted 1 line

1.8.3.2

with regards, pekon