Skip to contentSkip to conversation

arm64: percpu: implement optimised pcpu access using tpidr_el1

PATCH New Will Deacon 1 participant 1 message Dec 17, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: percpu: implement optimised pcpu access using tpidr_el1

This patch implements optimised percpu variable accesses using the el1 r/w thread register (tpidr_el1) along the same lines as arch/arm/.

---
 arch/arm64/include/asm/Kbuild   |  1 -
 arch/arm64/include/asm/percpu.h | 41 +++++++++++++++++++++++++++++++++++++++++
 arch/arm64/kernel/setup.c       | 10 ++++++++++
 arch/arm64/kernel/smp.c         |  6 ++++--
 4 files changed, 55 insertions(+), 3 deletions(-)
 create mode 100644 arch/arm64/include/asm/percpu.h
arch/arm64/include/asm/Kbuild +0 -1
index 519f89f5b6a3..d0ff25de67ca 100644
@@ -26,7 +26,6 @@ generic-y += mman.h
 generic-y += msgbuf.h
 generic-y += mutex.h
 generic-y += pci.h
-generic-y += percpu.h
 generic-y += poll.h
 generic-y += posix_types.h
 generic-y += resource.h
arch/arm64/include/asm/percpu.h new file +41 -0

41 lines not on this page · raw message

arch/arm64/kernel/setup.c +10 -0
index bd9bbd0e44ed..97d90840a7fd 100644
@@ -108,6 +108,16 @@ void __init early_print(const char *str, ...)
 	printk("%s", buf);
 }
 
+void __init smp_setup_processor_id(void)
+{
+	/*
+	 * clear __my_cpu_offset on boot CPU to avoid hang caused by
+	 * using percpu variable early, for example, lockdep will
+	 * access percpu variable inside lock_release
+	 */
+	set_my_cpu_offset(0);
+}
+
 bool arch_match_cpu_phys_id(int cpu, u64 phys_id)
 {
 	return phys_id == cpu_logical_map(cpu);
arch/arm64/kernel/smp.c +4 -2
index a0c2ca602cf8..b5d2031c12c6 100644
@@ -122,8 +122,6 @@ asmlinkage void secondary_start_kernel(void)
 	struct mm_struct *mm = &init_mm;
 	unsigned int cpu = smp_processor_id();
 
-	printk("CPU%u: Booted secondary processor\n", cpu);
-
 	/*
 	 * All kernel threads share the same mm context; grab a
 	 * reference and switch to it.
@@ -132,6 +130,9 @@ asmlinkage void secondary_start_kernel(void)
 	current->active_mm = mm;
 	cpumask_set_cpu(cpu, mm_cpumask(mm));
 
+	set_my_cpu_offset(per_cpu_offset(smp_processor_id()));
+	printk("CPU%u: Booted secondary processor\n", cpu);
+
 	/*
 	 * TTBR0 is only used for the identity mapping at this stage. Make it
 	 * point to zero page to avoid speculatively fetching new entries.
@@ -271,6 +272,7 @@ void __init smp_cpus_done(unsigned int max_cpus)
 
 void __init smp_prepare_boot_cpu(void)
 {
+	set_my_cpu_offset(per_cpu_offset(smp_processor_id()));
 }
 
 static void (*smp_cross_call)(const struct cpumask *, unsigned int);
Signature · 1 line
1.8.2.2