PHYLIB: queue work on system_power_efficient_wq
Subsystems (3)
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 3/11 PHYLIB: queue work on system_power_efficient_wq
From: Viresh Kumar <[email protected]>
Phylib uses workqueues for multiple purposes. There is no real dependency of scheduling these on the cpu which scheduled them.
On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one.
This patch replaces system_wq with system_power_efficient_wq for PHYLIB.
Cc David S. Miller <[email protected]>
Signed-off-by Viresh Kumar <[email protected]>
Acked-by David S. Miller <[email protected]>
Signed-off-by Tejun Heo <[email protected]>
(cherry picked from commit bbb47bdeae756f04b896b55b51f230f3eb21f207)
Signed-off-by Mark Brown <[email protected]>
--- drivers/net/phy/phy.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/net/phy/phy.c +5 -4
@@ -439,7 +439,7 @@ void phy_start_machine(struct phy_device *phydev, { phydev->adjust_state = handler; -schedule_delayed_work (&phydev->state_queue,HZ ); +queue_delayed_work (system_power_efficient_wq, &phydev->state_queue,HZ ); }/**
@@ -500,7 +500,7 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat)disable_irq_nosync (irq);atomic_inc (&phydev->irq_disable); -schedule_work (&phydev->phy_queue); +queue_work (system_power_efficient_wq, &phydev->phy_queue);return IRQ_HANDLED ; }
@@ -655,7 +655,7 @@ static void phy_change(struct work_struct *work)/* reschedule state queue work to run as soon as possible */ cancel_delayed_work_sync (&phydev->state_queue); -schedule_delayed_work (&phydev->state_queue,0 ); +queue_delayed_work (system_power_efficient_wq, &phydev->state_queue,0 );return ;
@@ -918,7 +918,8 @@ void phy_state_machine(struct work_struct *work)if (err <0 )phy_error (phydev); -schedule_delayed_work (&phydev->state_queue,PHY_STATE_TIME *HZ ); +queue_delayed_work (system_power_efficient_wq, &phydev->state_queue, +PHY_STATE_TIME *HZ ); } static inline void mmd_phy_indirect(struct mii_bus *bus, int prtad, int devad,
Signature · 1 line
1.8.5.1